Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code/words don't display if you try to join a sync chain before starting a new one #2540

Closed
LaurenWags opened this issue Dec 13, 2018 · 1 comment · Fixed by brave/brave-core#1109

Comments

@LaurenWags
Copy link
Member

Description

Similar to #2533, #2537

If you open 'Enter a sync chain code' and then go to 'Start a new sync chain', the QR code and words won't display.

Steps to Reproduce

  1. Clean profile 0.58.12
  2. Navigate to brave://sync
  3. Click on Enter a sync chain code.
  4. Click Cancel or X
  5. Click on Start a new sync chain
  6. Choose Phone/Tablet or Computer

Actual result:

No QR code or words are displayed:
screen shot 2018-12-13 at 10 51 02 am

screen shot 2018-12-13 at 10 51 07 am

Expected result:

QR code/words should be displayed. Refresh of page resolves this issue.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? unsure

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 25, 2018

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows
  • Verified the STR mentioned in the issue.

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR mentioned in the issue.

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment