Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide side panel option from settings appearance page #25689

Closed
simonhong opened this issue Sep 29, 2022 · 3 comments · Fixed by brave/brave-core#15270
Closed

Hide side panel option from settings appearance page #25689

simonhong opened this issue Sep 29, 2022 · 3 comments · Fixed by brave/brave-core#15270

Comments

@simonhong
Copy link
Member

simonhong commented Sep 29, 2022

Description

Steps to Reproduce

  1. Load brave://settings/appearance

Actual result:

image

Expected result:

Not shown as we can't show sidebar on left side

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link
Collaborator

Not shown as we can't show sidebar on left side

@simonhong did you mean the right side?

@kjozwiak
Copy link
Member

The above requires 1.44.104 or higher for 1.44.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Sep 30, 2022

Verified with

Brave | 1.44.105 Chromium: 106.0.5249.91 (Official Build) (x86_64)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | macOS Version 12.6 (Build 21G115)

Verified test plan from brave/brave-core#15270 (comment).
Compared 1.44.101 to 1.44.105, confirmed specified setting is not displayed.

1.44.101 1.44.105
1 44 101 1 44 105

@rebron rebron added this to Completed in Settings Oct 4, 2022
@rebron rebron removed this from Completed in Settings Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants