Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group sidebar settings and update labels in brave://settings/appearance #25717

Closed
Brave-Matt opened this issue Sep 29, 2022 · 2 comments · Fixed by brave/brave-core#16078
Closed

Group sidebar settings and update labels in brave://settings/appearance #25717

Brave-Matt opened this issue Sep 29, 2022 · 2 comments · Fixed by brave/brave-core#16078
Assignees
@simonhong
Labels
feature/settings feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@Brave-Matt
Copy link

Description

As it is right now, the side bar has several options in Settings --> Appearance that are not grouped together and are not (imo) labeled properly.

  • There is the "Sidebar" which is the actual "vertical strip" where all the clickable sites/pages/options are
  • There is the "side panel" which is the resulting panel that "pops out" of the sidebar when there are additional options to be shown
  • There is the "Show side bar panel" button, which automatically opens the "reading list", but which subsequently opens the "sidebar" anyway
  • There is the "Side panel" option, that controls whether or not the panel — that is to say, the bar and the panel, show on the right or left side of the browser window

All of the above is confusing and looks messy in the UI. I would highly recommend tidying these options up to help clarify what the user is actually controlling. For example, I've created a [rather crude] mock up below:

image

Here I have:

  • Changed everything to read "Side bar" as there is no need to differentiate what the "panel is" in this context. If someone wants to jump straight to the "reading list" then the option should instead say "Show reading list button" as it is specific to that feature. Otherwise, the user is just, effectively, opening the Sidebar
  • Grouped the options together in the UI so anyone can see that all of these features are related at a glance

The changes suggested above are a straightfoward way of keeping all the different options available to the user without causing any unnecessary confusion.
@Brave-Matt Brave-Matt added design A design change, especially one which needs input from the design team OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Sep 29, 2022
@rebron rebron added feature/settings priority/P4 Planned work. We expect to get to it "soon". design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Oct 3, 2022
@simonhong simonhong self-assigned this Oct 4, 2022
@simonhong
Copy link
Member

As side panel option is enabled again by brave/brave-core#15315, I also think scattered sidebar(panel) related options should be grouped.

@rebron rebron added this to On Deck in Settings Oct 4, 2022
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 22, 2022
@simonhong simonhong moved this from On Deck to In progress in Settings Nov 24, 2022
@simonhong simonhong mentioned this issue Nov 24, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Nov 30, 2022
@simonhong
Grouping sidebar related options together in settings
2be6c70 
fix brave/brave-browser#25717

Several sidebar options are grouped and located under autocomplete suggestion option.
Always show ful urls option is relocated under Use wide address bar
simonhong added a commit to brave/brave-core that referenced this issue Nov 30, 2022
@simonhong
Grouping sidebar related options together in settings
1ac1209 
fix brave/brave-browser#25717

Several sidebar options are grouped and located under autocomplete suggestion option.
Always show ful urls option is relocated under Use wide address bar
simonhong added a commit to brave/brave-core that referenced this issue Nov 30, 2022
@simonhong
Grouping sidebar related options together in settings
fdabf56 
fix brave/brave-browser#25717

Several sidebar options are grouped and located under autocomplete suggestion option.
Always show ful urls option is relocated under Use wide address bar
@rebron rebron changed the title Suggestion: Make Sidebar settings/UI more user friendly Group sidebar settings and update labels in brave://settings/appearance Nov 30, 2022
@rebron rebron removed design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Nov 30, 2022
simonhong added a commit to brave/brave-core that referenced this issue Dec 1, 2022
@simonhong
Grouping sidebar related options together in settings
cc310db 
fix brave/brave-browser#25717

Several sidebar options are grouped and located under autocomplete suggestion option.
Always show ful urls option is relocated under Use wide address bar
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 1, 2022
@rebron rebron moved this from In progress to Completed in Settings Dec 2, 2022
@stephendonner
Copy link

stephendonner commented Jan 18, 2023 •
edited

Verification PASSED using

Brave 1.48.129 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.48.129
  2. launched Brave
  3. loaded brave://settings/appearance

Confirmed Sidebar options are grouped together, beneath Show autocomplete suggestions in address bar

Confirmed Always show full URLs is located under Use wide address bar

Confirmed the Show Sidebar button's tooltip reads Show Sidebar

Sidebar option grouping Always show full URLs Show Sidebar tooltip
Screen Shot 2023-01-17 at 5 30 09 PM Screen Shot 2023-01-17 at 5 30 34 PM Screen Shot 2023-01-17 at 5 32 02 PM

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
@rebron rebron removed this from Completed in Settings Feb 28, 2023
sangwoo108 pushed a commit to brave/brave-core that referenced this issue Apr 4, 2023
@simonhong @sangwoo108
Grouping sidebar related options together in settings
3ebd391 
fix brave/brave-browser#25717

Several sidebar options are grouped and located under autocomplete suggestion option.
Always show ful urls option is relocated under Use wide address bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/settings feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Grouping sidebar options together in settings brave/brave-core
5 participants
@stephendonner @Brave-Matt @rebron @simonhong @brave-builds