Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Set default search engine screen for BR / AR #26182

Closed
rebron opened this issue Oct 21, 2022 · 4 comments · Fixed by brave/brave-core#15669
Closed

remove Set default search engine screen for BR / AR #26182

rebron opened this issue Oct 21, 2022 · 4 comments · Fixed by brave/brave-core#15669

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 21, 2022

Test plan

See #23814

Description

in brave://welcome remove Set default search engine screen for the following locales: BR / AR

135164087-0e746789-834d-49b8-86ca-4b19d33786db

Expected Result

  1. Install Brave from the following locales BR / AR
  2. Set default search engine screen should be removed from BR / AR (and previously CA / DE / FR / GB / US / AT / ES / MX). Screen should remain for all other locales.
  3. Onboarding should be four steps now instead of five.

Brave version (brave://version info)

Target version is 1.45.x maintenance release

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Dependency on #26181
Previous work for removing screen in CA/DE/FR/GB/US here: #18415
Previous work for removing screen in AT / ES / MX here: #23908

@rebron rebron added OS/Desktop Brave Search priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality QA/Yes QA/Test-Plan-Specified QA/Test-All-Platforms release-notes/exclude labels Oct 21, 2022
@rebron rebron added this to In progress in General Oct 25, 2022
@spylogsster spylogsster self-assigned this Oct 26, 2022
General automation moved this from In progress to Completed Oct 26, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 26, 2022
@rebron rebron moved this from Completed to Pending review/uplift or retest in General Nov 1, 2022
@kjozwiak kjozwiak removed the OS/Android Fixes related to Android browser functionality label Nov 1, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Nov 1, 2022

Believe the above is Desktop related and not OS/Android. The one for Android re: onboarding will be addressed via #26318.

@kjozwiak kjozwiak moved this from Pending review/uplift or retest to Completed in General Nov 4, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

The above requires 1.45.121 or higher for 1.45.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

@brave/qa-team please take a look at brave/brave-core#15669 (comment) for Test Case #1 and basically run through the same thing mentioned via #26181 (comment). Don't run through both BR & AR on one platform. Between the three platforms, both of the new locales will be covered. They've also been checked on Nightly as well before uplifting.

This can also be verified alongside #26181 and can use the format outlined via #26181 (comment).

@stephendonner
Copy link

stephendonner commented Nov 8, 2022

Verified PASSED using

Brave 1.45.121 Chromium: 107.0.5304.91 (Official build) (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
ОS macOS Version 11.7.1 (Build 20G918)

Verification notes can be found in #26181 (comment).


Verification PASSED on

Brave | 1.45.121 Chromium: 107.0.5304.91 (Official Build) (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 21H2 (Build 19044.2130)

Verification notes can be found in #26181 (comment)


Verification passed on

Brave 1.45.121 Chromium: 107.0.5304.91 (Official Build) (64-bit)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS Ubuntu 18.04 LTS

Verification notes can be found in #26181 (comment)

@kjozwiak kjozwiak removed this from the 1.45.x - Release #6 milestone Nov 8, 2022
@kjozwiak kjozwiak added this to the 1.45.x - Release #7 milestone Nov 8, 2022
@rebron rebron removed this from Completed in General Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment