Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation for Brave toolbar buttons #26245

Closed
samartnik opened this issue Oct 25, 2022 · 1 comment · Fixed by brave/brave-core#15654
Closed

Fix animation for Brave toolbar buttons #26245

samartnik opened this issue Oct 25, 2022 · 1 comment · Fixed by brave/brave-core#15654

Comments

@samartnik
Copy link
Contributor

Description

This is a follow up for #26155

screen-20221021-120408.mp4

Steps to reproduce

  1. Goto any scrollable website.
  2. Start scrolling so toolbar starts to disappear (see video above).
  3. Brave icons disappear with part of url bar.

Actual result

Brave icons disappear with part of url bar.

Expected result

Brave icons remain in url bar.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.47.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy GS 21 & Samsung Galaxy Tab S7 on the following version(s):

Brave	1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit) 
Revision	846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS	Android 12; Build/SP1A.210812.016
  • Verified icons in the tool bar do not disappear when scrolling
26245_fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants