Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Make eTLD+1 always visible in the URL bar #26155

Closed
SergeyZhukovsky opened this issue Oct 20, 2022 · 1 comment · Fixed by brave/brave-core#15574
Closed

[Security] Make eTLD+1 always visible in the URL bar #26155

SergeyZhukovsky opened this issue Oct 20, 2022 · 1 comment · Fixed by brave/brave-core#15574
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include security

Comments

@SergeyZhukovsky
Copy link
Member

Currently Brave and Chrome ways to show long URLs are different:
Screenshot 2022-10-14 at 14 41 00
We need to use the same approach as Chrome for now. Ideally we want to implement like it's described here #26052. But for now we are ok with a Chrome's approach.
A link to test with is https://long-extended-subdomain-name-containing-many-letters-and-dashes.badssl.com/ysigsgksgkskgslgsogslgslgslgslgslgsogsogsogslgsogsyosoys

@SergeyZhukovsky SergeyZhukovsky added security priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Oct 20, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Oct 20, 2022
@SergeyZhukovsky SergeyZhukovsky added this to Backlog in Android General via automation Oct 20, 2022
Android General automation moved this from Backlog to Done/Closed Oct 20, 2022
@SergeyZhukovsky SergeyZhukovsky added this to the 1.47.x - Nightly milestone Oct 20, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Dec 19, 2022

Reproduced the original issue on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.146 Chromium: 108.0.5359.128 (Official Build) (64-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/TQ1A.221205.011

Using the STR/Cases outlined via brave/brave-core#15574 (comment), reproduced the issue as per the following:

image

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.47.135 Chromium: 108.0.5359.128 (Official Build) beta (32-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/TQ1A.221205.011

Went through the STR/Cases outlined via brave/brave-core#15574 (comment) and ensured that the URL was correctly being displayed as per the following:

image


Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.47.135 Chromium: 108.0.5359.128 (Official Build) beta (32-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/TP1A.220624.014

Went through the STR/Cases outlined via brave/brave-core#15574 (comment) and ensured that the URL was correctly being displayed as per the following:

image

@LaurenWags LaurenWags changed the title Make eTLD+1 always visible in the URL bar [Security] Make eTLD+1 always visible in the URL bar Jan 10, 2023
@kjozwiak kjozwiak removed this from Done/Closed in Android General Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants