-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync available in Settings - follow up to 2609 #2642
Milestone
Comments
This was referenced Dec 19, 2018
Merged
For channels other than 0.58.x, we need to check if |
will be addressed in #2650 closed by brave/brave-core#1146 |
Verified passed with
Verified passed with
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Follow up to #2609
Build 0.58.15 should have Sync disabled by default. However, when navigating to brave://settings, Sync is still available in Settings.
Steps to Reproduce
Actual result:
Sync is displayed in settings:
Expected result:
Since sync is disabled by default due to #2609, it should not be displayed in settings.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
As expected, sync is not available from hamburger menu and navigating to brave://sync results in an error.
The text was updated successfully, but these errors were encountered: