Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync availability in settings (non 0.58.x) #2650

Closed
darkdh opened this issue Dec 19, 2018 · 3 comments · Fixed by brave/brave-core#1145
Closed

Sync availability in settings (non 0.58.x) #2650

darkdh opened this issue Dec 19, 2018 · 3 comments · Fixed by brave/brave-core#1145
Assignees
@darkdh
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@darkdh
Copy link
Member

darkdh commented Dec 19, 2018

follow up of #2642 (comment)
@darkdh darkdh added this to the 0.59.x - Beta milestone Dec 19, 2018
@darkdh darkdh self-assigned this Dec 19, 2018
@darkdh darkdh added this to Untriaged backlog in Sync via automation Dec 19, 2018
This was referenced Dec 19, 2018
Closed
Merged
@darkdh darkdh added the QA/Yes label Dec 19, 2018
Sync automation moved this from Untriaged backlog to Completed Dec 19, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2018 •
edited
Loading

@darkdh brave/brave-core#1145 (comment)
Brave sync section is still shown when we launch brave with --disable-brave-sync

image

Issue is reproducible on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows

@darkdh
Copy link
Member Author

darkdh commented Dec 24, 2018

0.59.12 doesn't contain the fix, please retest with 0.59.13 when it is available

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 29, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

  • Brave sync is not renamed to Sync in Hamburger menu hence logged new issue (Brave sync is not renamed to Sync on Linux platform #2758).

  • Verified there is sync section in both chrome://settings and Hamburger menu when we lauch brave without --disable-brave-sync flag
    image

  • Verified there is no sync section in chrome settings and Hamburger menu when we launch brave with --disable-brave-sync flag
    image

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

When Brave IS launched with --disable-brave-sync, Sync is not available and brave://sync page does not load:
screen shot 2019-01-02 at 1 37 46 pm
screen shot 2019-01-02 at 1 38 09 pm

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
@rebron rebron removed this from Completed in Sync Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Displaying sync in setting according to sync enable/disable status brave/brave-core
4 participants
@bbondy @darkdh @LaurenWags @GeetaSarvadnya