Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displaying sync in setting according to sync enable/disable status #1145

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Displaying sync in setting according to sync enable/disable status #1145

merged 1 commit into from
Dec 19, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 19, 2018 •
edited
Loading

fix brave/brave-browser#2650

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

sync disabled

  1. Launch Brave with --disable-brave-sync
  2. Go to chrome://settings/
  3. There should not be "Brave Sync" section

sync enabled

  1. Launch Brave without --disable-brave-sync
  2. Go to chrome://settings/
  3. You should see "Brave Sync" section

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

bbondy
bbondy previously approved these changes Dec 19, 2018
View reviewed changes
cezaraugusto
cezaraugusto previously approved these changes Dec 19, 2018
View reviewed changes
@darkdh darkdh self-assigned this Dec 19, 2018
@darkdh darkdh dismissed stale reviews from cezaraugusto and bbondy via 38a5fb3 December 19, 2018 22:19
@darkdh
Copy link
Member Author

darkdh commented Dec 19, 2018

rebased to chromium 72

@darkdh darkdh merged commit 6416a7d into master Dec 19, 2018
darkdh added a commit that referenced this pull request Dec 19, 2018
@darkdh
Merge pull request #1145 from brave/sync-setting-status
9c251e8 
Displaying sync in setting according to sync enable/disable status
@darkdh darkdh deleted the sync-setting-status branch December 19, 2018 22:46
@darkdh
Copy link
Member Author

darkdh commented Dec 19, 2018

master: 6416a7d
0.60.x: 9c251e8

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

darkdh added a commit that referenced this pull request Dec 20, 2018
@darkdh
Merge pull request #1145 from brave/sync-setting-status
483023b 
Displaying sync in setting according to sync enable/disable status
@darkdh
Copy link
Member Author

darkdh commented Dec 20, 2018

0.59.x: 483023b

@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Dec 24, 2018
Closed
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
4 participants
@darkdh @rebron @bbondy @cezaraugusto