Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom tip amount for publishers #2645

Closed
NejcZdovc opened this issue Dec 19, 2018 · 7 comments · Fixed by brave/brave-core#1164
Closed

Add support for custom tip amount for publishers #2645

NejcZdovc opened this issue Dec 19, 2018 · 7 comments · Fixed by brave/brave-core#1164

Comments

@NejcZdovc
Copy link
Contributor

We are getting tip amount for publisher custom banner. We need to add support for it. This needs to be reflected in site banner and panel where user can chose this amounts.

@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Dec 19, 2018
@kjozwiak kjozwiak added this to the 1.x Backlog milestone Dec 19, 2018
@kjozwiak
Copy link
Member

As @NejcZdovc mentioned above, changing the tip amounts on the Publishers website isn't being reflected under the Brave client. Quick example for more context:

Here's a preview of my banner under the Publishers website (notice the custom tips):

screen shot 2018-12-18 at 11 15 34 pm

Here's my actual website that's serving the new banner that I've created via Publishers (notice that the custom tips haven't been used):

screen shot 2018-12-18 at 11 13 24 pm

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Pending review in Rewards Dec 20, 2018
Rewards automation moved this from Pending review to Completed Dec 21, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 21, 2018
@NejcZdovc NejcZdovc moved this from Completed to Waiting uplift in Rewards Dec 21, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.60.x - Dev, 0.59.x - Beta Dec 21, 2018
@NejcZdovc NejcZdovc moved this from Waiting uplift to Completed in Rewards Dec 21, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2019

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Verified tipping banner shows custom amounts set on publisher website:
    screen shot 2019-01-03 at 9 14 44 am

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

image

Verified passed with

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

@kjozwiak
Copy link
Member

kjozwiak commented Jan 8, 2019

Attempted to tip 500 BAT to kjozwiakstaging.github.io via staging and ran into the following error:

[ RESPONSE - ReconcilePayloadCallback ]
> time: 1546891257
> result: Failure
> response: {"statusCode":503,"error":"Service Unavailable","message":"surveyor 6KTixOtZEpwfT4prbgyTG0MlPSwri6OsKsl1bSR+BuJ has 435 control surveyors, but needed 1454"}> headers cache-control: no-cache
> headers connection: keep-alive
> headers content-encoding: gzip
> headers content-type: application/json; charset=utf-8
> headers date: Mon, 07 Jan 2019 20:00:57 GMT
> headers retry-after: 5
> headers server: Cowboy
> headers transfer-encoding: chunked
> headers vary: accept-encoding
> headers via: 1.1 vegur
> headers x-rate-limit-limit: 60
> headers x-rate-limit-remaining: 59
> headers x-rate-limit-reset: 1546891317
[ END RESPONSE ]

It appears that the back-end doesn't support 500 BAT tips. Publishers team will change/remove the 500 BAT choice from the Publishers website.

Tipping 50 BAT & 100 BAT works as expected:

screen shot 2019-01-07 at 9 42 50 pm

@ChildishGiant
Copy link

I'd love if there was a way for a user to type in how many BAT they want to send, that way the user can give as much or as little as they want. I guess some publishers wouldn't want this so maybe they could set a min & max or just disable the custom amount option. Here's a terrible 30 second mockup
image

@mooleshacat
Copy link

mooleshacat commented Aug 6, 2019

I second (or whatever number I am) this feature

@SYK-08
Copy link

SYK-08 commented Jul 8, 2021

I am not able to add a custom tip amount on Brave Mobile, please help.

@LaurenWags
Copy link
Member

@SYK-08 custom tip amount will be implemented on Android with #16021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment