Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Tabs automatically hides the wallet icon on Solana Dapp #26583

Closed
srirambv opened this issue Nov 7, 2022 · 3 comments · Fixed by brave/brave-core#15904
Closed

Switching Tabs automatically hides the wallet icon on Solana Dapp #26583

srirambv opened this issue Nov 7, 2022 · 3 comments · Fixed by brave/brave-core#15904

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 7, 2022

Description

Switching Tabs automatically hides the wallet icon on Solana Dapp

Steps to reproduce

  1. Connect to a Solana Dapp
  2. Ensure wallet icon is shown in the URL bar
  3. Switch tab
  4. Go back to Solana Dapp tab, Wallet icons is not shown
  5. Reload Solana Dapp tab, shows wallet icon again

Actual result

Switching Tabs automatically hides the wallet icon on Solana Dapp

Expected result

Should continue to show the wallet irrespective of tab is in focus or not

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.46.96 x64 Beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Nov 7, 2022
@srirambv srirambv added this to Backlog in Android General via automation Nov 7, 2022
@Pavneet-Sing
Copy link

@srirambv I tested this on various sites (magic edan, pwgoom) but unable to reproduce, can you share the site name you used to reproduce this or maybe try this on latest nightly if you haven't?

wallet-icon.webm

@srirambv
Copy link
Contributor Author

srirambv commented Nov 7, 2022

@Pavneet-Sing here's a recording of the issue.

Missing.Wallet.icon.mp4

@srirambv
Copy link
Contributor Author

Verification passed on the following devices running

  • Verified steps from brave/brave-core#15904
  • Verified switching tabs doesn't hide the wallet button on Solana Dapp page
Oppo Reno 5 (Android 12) Lenovo Tab (Android 12)
26583-ARM.mp4
26583-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Done/Closed
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants