Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet icon in toolbar is not shown when Solana dapps is connected #25258

Closed
Pavneet-Sing opened this issue Sep 7, 2022 · 2 comments · Fixed by brave/brave-core#15593
Closed

Wallet icon in toolbar is not shown when Solana dapps is connected #25258

Pavneet-Sing opened this issue Sep 7, 2022 · 2 comments · Fixed by brave/brave-core#15593
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.46.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Sep 7, 2022 •
edited

Description

Wallet icon in toolbar is not shown when Solana dapps connection is established. The icon should be visible to interact with panel and dapps.

Steps to reproduce

  1. Create, unlock wallet and Go to solana dapps
  2. Connect with dapps
  3. The wallet icon is not visible but the Solana account is connected
solana-brave-wallet-icon.webm

Additional information

Seems like delegate_->ShowPanel(); is not being reached.

For Ethereum, walletInteractionDetected is triggered to show the icon

BTW, the icon shows up if the wallet is locked and connection request is triggered.

cc: @darkdh @SergeyZhukovsky
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/solana feature/web3/wallet/core labels Sep 7, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Sep 14, 2022
Merged
25 tasks
@srirambv srirambv mentioned this issue Oct 11, 2022
Closed
@Pavneet-Sing Pavneet-Sing mentioned this issue Oct 21, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 28, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Nov 4, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

The above requires 1.46.94 or higher for 1.46.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Nov 7, 2022

Verification passed on the following devices running 1.46.96 x64 Beta build

  • Verified the wallet icon is shown in toolbar when Solana Dapp is connected
  • Verified able to click the wallet icon once connected
  • Encountered #26583
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
25258-ARM.mp4
25258-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): implement solana dapps send tx brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds