Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENS, SNS, UD should use hardcoded endpoints for resolution. #26654

Closed
supermassive opened this issue Nov 10, 2022 · 1 comment · Fixed by brave/brave-core#16101
Closed

ENS, SNS, UD should use hardcoded endpoints for resolution. #26654

supermassive opened this issue Nov 10, 2022 · 1 comment · Fixed by brave/brave-core#16101
Assignees
@supermassive
Labels
feature/web3/ddns feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@supermassive
Copy link
Collaborator

supermassive commented Nov 10, 2022 •
edited

We provide such resolution as a service and should not depend on custom RPC endpoints
@supermassive supermassive self-assigned this Nov 10, 2022
@supermassive supermassive mentioned this issue Nov 28, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 1, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Verification passed on

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (arm64)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS macOS Version 13.0 (Build 22A380)
  • Verified Wallet and omnibox resolution for SNS, ENS and UD are using Brave RPC endpoints where applicable

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/ddns feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Use Brave endpoints for SNS and ENS brave/brave-core
3 participants
@supermassive @srirambv @brave-builds