Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Brave endpoints for SNS and ENS #16101

Merged
merged 1 commit into from Dec 1, 2022
Merged

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Nov 28, 2022

Resolves brave/brave-browser#26654

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Wallet and omnibox resolution for SNS, ENS and UD should use brave RPC endpoints instead of currently selected ones. In this PR behavior for UD did not change as it already works as expected.

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, just one question.
Is UD always using our ethereum mainnet and polygon endpoints currently? We should adjust it too if it's not.

@supermassive
Copy link
Collaborator Author

Code LGTM, just one question. Is UD always using our ethereum mainnet and polygon endpoints currently? We should adjust it too if it's not.

Yes, UD uses GetUnstoppableDomainsRpcUrl(chain_id) as network url

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 233a05d
reason: unsigned
Please follow the handbook to configure commit signing
cc: @supermassive

@supermassive supermassive merged commit aac08e9 into master Dec 1, 2022
@supermassive supermassive deleted the brave_rpcs_for_sns_ens branch December 1, 2022 02:26
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 1, 2022
sangwoo108 pushed a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants