Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy clean link to the macOS application menu bar #26825

Closed
fmarier opened this issue Nov 17, 2022 · 1 comment · Fixed by brave/brave-core#16274
Closed

Add copy clean link to the macOS application menu bar #26825

fmarier opened this issue Nov 17, 2022 · 1 comment · Fixed by brave/brave-core#16274
Assignees
@spylogsster
Labels
copy-clean-link OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Nov 17, 2022

The new "copy clean link" option is available in the contextual menu on macOS:
copy-clean-url1

but it should also be available in the application menu bar where the keyboard shortcut can be seen:
copy-clean-url2

(The keyboard shortcut is being changed to clean URLs by default in #26761.)
@rebron rebron added QA/Yes priority/P4 Planned work. We expect to get to it "soon". release-notes/include labels Nov 18, 2022
@rebron rebron added this to P4 backlog in Front End Nov 22, 2022
@spylogsster spylogsster self-assigned this Nov 28, 2022
@spylogsster spylogsster moved this from P4 backlog to In progress in Front End Dec 5, 2022
This was referenced Dec 6, 2022
Closed
Merged
@rebron rebron moved this from In progress to On Deck in Front End Dec 13, 2022
@spylogsster spylogsster mentioned this issue Dec 20, 2022
Closed
25 tasks
@spylogsster spylogsster moved this from On Deck to In progress in Front End Dec 20, 2022
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 19, 2023
@rebron rebron moved this from In progress to Completed in Front End Jan 24, 2023
@stephendonner stephendonner mentioned this issue Feb 13, 2023
Closed
@stephendonner
Copy link

stephendonner commented Feb 14, 2023 •
edited
Loading

Verification PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Case 1: URL selection

Steps:

  1. installed 1.49.96
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. clicked on the top-level macOS Edit application-menu item
  6. examined the shortcut options

Confirmed I got Copy Clean Link ⌘C

Screen Shot 2023-02-13 at 4 18 44 PM

Case 2: substring selection

(continued from Case 1)

  • selected substring fmarier/status/1574869891978784769
  • clicked on the top-level macOS Edit application-menu item
  • examined the shortcut options

Confirmed regular Copy ⌘C menu item

Screen Shot 2023-02-13 at 4 28 49 PM

Case 3: no selection

  • with no selection, clicked on the top-level macOS Edit application-menu item
  • examined the shortcut options

Confirmed regular Copy ⌘C menu item

Screen Shot 2023-02-13 at 4 30 11 PM

@rebron rebron removed this from Completed in Front End Mar 7, 2023
@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
copy-clean-link OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
5 participants
@fmarier @stephendonner @spylogsster @rebron @brave-builds