-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign Copy keyboard shortcut to "copy clean link" #26761
Comments
For Mac App menu part created another issue #27902 |
Verified
|
Brave | 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64) |
---|---|
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839} |
OS | macOS Version 11.7.3 (Build 20G1116) |
Case 1: Copy Clean Link - PASSED
- installed
1.49.96
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected the URL
- pressed
command
+C
to copy - pressed
command
+V
to paste
Confirmed Copy Clean Link
was used, as the pasted URL is https://twitter.com/fmarier/status/1574869891978784769?fbclid=1234
(removed s=21
, and t=lkf...
params)
Copy Clean Link shortcut command + C used |
command + v |
---|---|
Case 2: Copy text - PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected a random substring of text from the URL
/157486989197878476
- pressed
command
+C
to copy - pressed
command
+V
to paste
Confirmed regular copy
and paste
operations for non-URL text pasted /157486989197878476
Copy shortcut command + C used |
command + V |
---|---|
Verification
Case 1: Copy Clean Link -
|
Copy Clean Link shortcut command + C used |
command + v |
---|---|
Case 2: Copy item from context menu should copy selected url without changes - PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected the URL
- select
Copy
from context menu - pressed
command
+V
to paste
Confirmed selected url is pasted without any changes or strip any parameters in the URL `https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes'
Copy from context menu |
Paste from context menu |
---|---|
Case 3: Copy text - PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected a random substring of text from the URL
/157486989197878476
- pressed
command
+C
to copy - pressed
command
+V
to paste
Confirmed regular copy
and paste
operations for non-URL text pasted /157486989197878476
Copy shortcut command + C used |
command + V |
---|---|
Case 4: Copy clean link should not be visible for selected text- PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected a random substring of text from the URL
/157486989197878476
- right click to open context menu
Confirmed context menu shows default hotkey Ctrl+c for Copy item and no Copy clean link
is available for non-URL text pasted /157486989197878476
Verification passed on
Case 1: Copy Clean Link -
|
Copy Clean Link shortcut control + C used |
control + v |
---|---|
Case 2: Copy item from context menu should copy selected url without changes - PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected the URL
- select
Copy
from context menu - pressed
control
+V
to paste
Confirmed selected url is pasted without any changes or strip any parameters in the URL `https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes'
Copy from context menu |
Paste from context menu |
---|---|
Case 3: Copy text - PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected a random substring of text from the URL
/157486989197878476
- pressed
control
+C
to copy - pressed
control
+V
to paste
Confirmed regular copy
and paste
operations for non-URL text pasted /157486989197878476
Copy shortcut control + C used |
control + V |
---|---|
Case 4: Copy clean link should not be visible for selected text- PASSED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected a random substring of text from the URL
/157486989197878476
- right click to open context menu
Confirmed context menu shows default hotkey Ctrl+c for Copy item and no Copy clean link
is available for non-URL text pasted /157486989197878476
Case 5: Copy clean link is assigned to control+c in context menu - FAILED
- new profile
- launched Brave
- loaded
https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
- selected the whole URL
- right click to open context menu
Visually the shortcut is not assigned on Linux. Logged #28891
In the version 1.56.14, I cannot use |
Users have been asking for "copy clean URLs" to be the default so that they don't have to remember to use it when copying from the URL bar.
We should change the keyboard shortcut:
The text was updated successfully, but these errors were encountered: