Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcut CTRL+M for muting a tab #26994

Closed
GregJArnold opened this issue Nov 26, 2022 · 4 comments · Fixed by brave/brave-core#16226
Closed

Add keyboard shortcut CTRL+M for muting a tab #26994

GregJArnold opened this issue Nov 26, 2022 · 4 comments · Fixed by brave/brave-core#16226
Assignees
@simonhong
Labels
design A design change, especially one which needs input from the design team feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include release-notes/social
Milestone
1.48.x - Release

Comments

@GregJArnold
Copy link

Description

Firefox allows you to mute a tab with CTRL+M. This is a nice feature, because, as far as I can tell, the only way to do so in Brave is to click the speaker icon in a tab.

Brave version

1.45.127 Chromium: 107.0.5304.110 (Official Build) (64-bit)
@simonhong
Copy link
Member

Nice request! @rebron I would happily take this issue if want :)

@rebron rebron changed the title [Feature Request] Keyboard Shortcut for muting a tab Add keyboard Shortcut for muting a tab Dec 1, 2022
@rebron rebron added design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA/Yes release-notes/include labels Dec 1, 2022
@rebron rebron added this to In progress in General Dec 2, 2022
simonhong added a commit to brave/brave-core that referenced this issue Dec 5, 2022
@simonhong
Toggle active tab's audio mute with ctrl + M
db8ddc4 
fix brave/brave-browser#26994
@simonhong simonhong mentioned this issue Dec 5, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Dec 5, 2022
@simonhong
Toggle active tab's audio mute with ctrl + m
e915dc9 
fix brave/brave-browser#26994
simonhong added a commit to brave/brave-core that referenced this issue Dec 6, 2022
@simonhong
Toggle active tab's audio mute with ctrl + m
11806b0 
fix brave/brave-browser#26994
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 6, 2022
General automation moved this from In progress to Completed Dec 6, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 6, 2022
@rebron rebron changed the title Add keyboard Shortcut for muting a tab Add keyboard shortcut CTRL+M for muting a tab Dec 20, 2022
@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jan 5, 2023
@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jan 10, 2023 •
edited

Verification PASSED using

Brave | 1.48.118 Chromium: 109.0.5414.80 (Official Build) beta (64-bit)
-- | --
Revision | 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Confirmed: Able to toggle active audio tab with keyboard shortcut CTRL+M to mute/unmute the tab

TOWER.BRIDGE.TOUR_.LONDON.ENGLAND.4K.-.YouTube.-.Brave.2023-01-09.16-55-55.mp4

@stephendonner
Copy link
Collaborator

stephendonner commented Jan 17, 2023 •
edited

Verified PASSED using

Brave 1.48.129 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.48.129
  2. launched Brave
  3. loaded https://www.youtube.com/watch?v=91BUM3WhCfo&t=3s
  4. clicked the Play button on the video
  5. noted sound
  6. pressed control + m
  7. confirmed the tab muted
  8. pressed control + m once more
  9. confirmed the tab unmuted

Screencast:

tab-mute.mp4

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jan 24, 2023 •
edited

Verification PASSED using

Brave | 1.48.137 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Linux
  1. Install 1.48.137
  2. launch Brave
  3. open a new-tab
  4. visit https://www.youtube.com/watch?v=DXZer9k27C8
  5. played the video
  6. pressed keyboard shortcut CTRL+M to mute the active audio tab
  7. confirmed the tab is muted
  8. pressed CTRL+M again
  9. confirmed the tab is unmuted
mutingtab.webm

@LaurenWags LaurenWags mentioned this issue Jan 26, 2023
Open
@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
@rebron rebron removed this from Completed in General Feb 16, 2023
sangwoo108 pushed a commit to brave/brave-core that referenced this issue Apr 4, 2023
@simonhong @sangwoo108
Toggle active tab's audio mute with ctrl + m
3ece312 
fix brave/brave-browser#26994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
design A design change, especially one which needs input from the design team feature-request OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include release-notes/social
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Toggle active tab's audio mute with ctrl + m brave/brave-core
7 participants
@stephendonner @rebron @simonhong @GregJArnold @LaurenWags @brave-builds @MadhaviSeelam