Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VPN set-up to make it easier for users to select a country #27014

Closed
anthonypkeane opened this issue Nov 28, 2022 · 2 comments · Fixed by brave/brave-core#21458
Closed
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@anthonypkeane
Copy link

Description Related to: brave/brave-ios#6499

Having the ability to select an exit point in a different country is a real plus for a VPN. Given some recent feedback (see Slack thread) we should rethink how we make this feature more easy to find.

Existing Country Selection Setting UI
Screenshot_20221128-100125

@anthonypkeane anthonypkeane added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality feature/vpn labels Nov 28, 2022
@deeppandya deeppandya added release-notes/include and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jan 12, 2024
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Jan 17, 2024
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Feb 2, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 9, 2024
@hffvld
Copy link
Contributor

hffvld commented Feb 10, 2024

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL / taimen-user  8.1.0 OPM2.171026.006.H1 release-keys
- Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
- Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.149
Chromium: 121.0.6167.164 (Official Build) beta (64-bit) 

Filed follow-up issue #35939

STEPS:

  1. Launch Brave
  2. Purchase a VPN subscription
  3. Enable VPN
  4. Tree-dot menu > Country flag icon
  5. Change to any other country > Verify

ACTUAL RESULTS:

  • Verified that the country flag icon is not shown in the main menu when a user doesn't have an active VPN subscription
  • Verified that the country flag icon is shown in the main menu when a user has an active VPN subscription
  • Verified that switching to another country/region is working when using the country flag icon in the main menu

Pixel 2 XL
1 2
1 2
1 2
Galaxy Tab S8
1 2
1 2
1 2
1 2
1 2
Pixel 7
1 2
1 2
1 2
1 2
1 2
timestamp_17-50-51_17-51-35.mp4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants