Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] YT Improvements - Settings to remove distracting elements #27095

Closed
timchilds opened this issue Dec 1, 2022 · 3 comments · Fixed by brave/brave-core#17791
Closed
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected enhancement OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@timchilds
Copy link

timchilds commented Dec 1, 2022

Description

We could improve the YT experience in Brave by giving users the option to remove "distracting" elements from the page. These could be enabled via a new settings group.

e.g.

  • Comments
  • Live chat
  • Related videos
  • etc

A couple of examples of other products doing this:

Spec

https://docs.google.com/document/d/1WVisEvd6HDr-QsJ5tZjl1m0ZKTTXIW-yqrAARxeZtS8/edit?usp=sharing

@timchilds timchilds added OS/Android Fixes related to Android browser functionality enhancement QA/Yes release-notes/include labels Dec 1, 2022
@timchilds timchilds changed the title [Android] YT Improvements - Settings to remove distracting elements on the page [Android] YT Improvements - Settings to remove distracting elements Dec 1, 2022
@timchilds
Copy link
Author

@timchilds timchilds removed their assignment Feb 9, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 31, 2023
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels May 10, 2023
@stephendonner
Copy link

Verified PASSED using a Google Pixel XL (arm64) running Android 9:

Brave	1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (32-bit)
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	Android 9; Build/PQ2A.190305.002; 28; REL

Steps:

  1. installed 1.52.102
  2. launched Brave
  3. tapped on the 3-dots menu
  4. tapped on Settings
  5. tapped on Brave Shields & privacy
  6. swiped down to Youtube (sic - issue filed on the typo)
  7. tapped to enable Hide YouTube Distracting Elements
  8. loaded https://www.youtube.com/watch?v=QMxm7z7VFoo

Confirmed comments, Subscribe button, Open App, live chat, like/dislike controls, etc. were hidden

Prefs

example example
Screenshot_20230518-144538 Screenshot_20230518-143831

YouTube content

example example
Screenshot_20230518-145117 (1) Screenshot_20230518-145215 (1)

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 23, 2023
@hffvld
Copy link
Contributor

hffvld commented May 23, 2023

Verified on Google Nexus 5X and Galaxy Tab S8 using version(s):

Device/OS: 
- Google Nexus 5X [Android 8.1]
- SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.52.109
Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision: 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}

STEPS:

  1. Install 1.52.x
  2. Launch Brave
  3. Open Hamburger Menu > Settings
  4. Brave Shields & privacy
  5. Find Youtube
  6. Enable toggle switch for Hide YouTube Distracting Elements
  7. Open youtube.com > Play any video

ACTUAL RESULTS:

  • Verified that Comments, Subscribe button, Open App, Live chat, Like/Dislike controls, etc. were hidden
Android 8 - PASS
Toggle OFF Portrait Toggle ON Portrait Toggle OFF Landscape Toggle ON Landscape
1 2 3 4
Android 13 Tablet - PASS
Toggle OFF Portrait Toggle ON Portrait Toggle OFF Landscape Toggle ON Landscape
1 2 3 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected enhancement OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants