Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Phone/Computer buttons until the device name is queried #2724

Closed
srirambv opened this issue Dec 24, 2018 · 1 comment · Fixed by brave/brave-core#1193
Closed

Disable Phone/Computer buttons until the device name is queried #2724

srirambv opened this issue Dec 24, 2018 · 1 comment · Fixed by brave/brave-core#1193

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 24, 2018

Test plan

See brave/brave-core#1193

Description

Disable Phone/Computer buttons until the device name is queried

Steps to Reproduce

  1. Install 0.60.4
  2. Enable Sync via hamburger menu or via brave://sync
  3. Wait for the device name to be queried. Time varies, sometime its instatnaeous and sometime there is a considerable delay
  4. UI shows Let’s sync a new device with “”. while its being queried
  5. Click on Computer, doesn't show the code words
  6. Click on Phone/Tablet doesn't show the QR code
  7. Close and reopen brave://sync, device name is instantly queried and you can see the QR/code words with appropriate option being selected

Actual result:

https://youtu.be/P4_vqKroqHc

Expected result:

Should query device name instantly and the computer/phone/tablet buttons should be inactive if there is a delay in getting the device name

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.4 Chromium: 72.0.3626.17 (Official Build) dev(64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

cc: @bradleyrichter for design input
@rebron @brave/legacy_qa

@srirambv srirambv added feature/sync design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P4 Planned work. We expect to get to it "soon". about-pages/sync QA/Yes release-notes/exclude labels Dec 24, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 24, 2018
@srirambv srirambv added this to Untriaged backlog in Sync via automation Dec 24, 2018
@srirambv srirambv moved this from Untriaged backlog to P3, P4 & P5 backlog in Sync Dec 24, 2018
@cezaraugusto cezaraugusto removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jan 2, 2019
Sync automation moved this from P3, P4 & P5 backlog to Completed Jan 4, 2019
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Jan 8, 2019

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux
  • Verified new UI doesn't show the quering of device name. The waiter message takes time to add the second device to chain which is good enough time to get the device name

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10
  • Verified new UI doesn't show the quering of device name. The waiter message takes time to add the second device to chain which is good enough time to get the device name

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants