Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer name is missing in Let’s sync a new device with “”. #2728

Closed
GeetaSarvadnya opened this issue Dec 24, 2018 · 1 comment · Fixed by brave/brave-core#1191
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2018

Description

Computer name is missing in Let’s sync a new device with “”.

Description

Device 1: Windows 10 x64 (0.60.4 dev build)
Device 2: Android Samsung Galaxy 5.1 (1.0.71 (sync3))

Steps to Reproduce

  1. Clean install 0.60.4
  2. Sync Windows and Android devices through QR code
  3. Once sync is established between two devices leave the sync chain on Windows
  4. Click on Start new sync chain

Actual result:

image 12

computer name missing

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.4 Chromium: 72.0.3626.17 (Official Build) dev (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? NA

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya added this to the 0.60.x - Dev milestone Dec 24, 2018
@GeetaSarvadnya GeetaSarvadnya added this to Untriaged backlog in Sync via automation Dec 24, 2018
@kjozwiak kjozwiak modified the milestones: 0.60.x - Dev, 1.x Backlog Dec 24, 2018
@darkdh darkdh self-assigned this Dec 27, 2018
@darkdh darkdh moved this from Untriaged backlog to Inprogress in Sync Dec 27, 2018
@darkdh darkdh added the QA/Yes label Dec 27, 2018
Sync automation moved this from Inprogress to Completed Dec 28, 2018
@darkdh darkdh modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 28, 2018
@kjozwiak kjozwiak modified the milestones: 0.60.x - Dev, 0.59.x - Beta Jan 4, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jan 4, 2019

Verified passed with

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verification passed on

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10

Verification passed on

Brave 0.59.18 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

@GeetaSarvadnya GeetaSarvadnya added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 7, 2019
@rebron rebron removed this from Completed in Sync Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment