Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset sync right away if devices size <= 1 #1191

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Reset sync right away if devices size <= 1 #1191

merged 1 commit into from
Dec 28, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 27, 2018

fix brave/brave-browser#2533
fix brave/brave-browser#2552
fix brave/brave-browser#2728
fix brave/brave-browser#2737

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Setup sync without second device

  1. Create new sync chain on device A
  2. Remember the sync code
  3. Close all dialog
  4. Create new sync chain on device A
  5. Sync code should be different than step 2
  6. Should able to see QR code

Setup sync with second device and delete second device

  1. Create new sync chain on device A
  2. Remember the sync code
  3. Connect device B
  4. Wait for device list synced on both devices
  5. Delete device B from device A
  6. Wait for both devices showing initial sync page
  7. Create new sync chain on device A
  8. Sync code should be different than step 2
  9. Create new sync chain on device B
  10. Sync code should be different than step 2

Setup sync with second device and self deleted

  1. Create new sync chain on device A
  2. Remember the sync code
  3. Connect device B
  4. Wait for device list synced on both devices
  5. Delete/reset device A on device A
  6. Wait for both devices showing initial sync page
  7. Create new sync chain on device A
  8. Sync code should be different than step 2
  9. Create new sync chain on device B
  10. Sync code should be different than step 2

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@AlexeyBarabash
Copy link
Contributor

Also fixes brave/brave-browser#2737 .

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@darkdh darkdh merged commit 4c5d9d8 into master Dec 28, 2018
darkdh added a commit that referenced this pull request Dec 28, 2018
Reset sync right away if devices size <= 1
@darkdh
Copy link
Member Author

darkdh commented Dec 28, 2018

master 4c5d9d8
0.60.x e956513

@darkdh darkdh deleted the sync-reset-fix branch December 28, 2018 17:05
bbondy pushed a commit that referenced this pull request Jan 2, 2019
Reset sync right away if devices size <= 1
@bbondy
Copy link
Member

bbondy commented Jan 2, 2019

0.59.x: a81ec8b

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

@bbondy looks like this landed in 0.59.x correct? The associated issues mentioned above are all in the 0.60.x milestone. Moving these into https://github.com/brave/brave-browser/milestone/15 (0.59.x).

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2019

Verification passed on 0.59.34. Verified test plan works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants