Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import from Yandex browser #27301

Closed
spylogsster opened this issue Dec 12, 2022 · 3 comments · Fixed by brave/brave-core#16441
Closed

Add import from Yandex browser #27301

spylogsster opened this issue Dec 12, 2022 · 3 comments · Fixed by brave/brave-core#16441
Assignees
@spylogsster @rebron
Labels
feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Dec 12, 2022 •
edited by bsclifton

Test plan

(taken from brave/brave-core#16441)
Install Yandex browser and check that History, Bookmarks and Extensions can be imported.

Description

Add Yandex browser to brave://settings/importData list
@rebron rebron added feature/importer onboarding Front-end related to helping a new user learn about features within the browser. priority/P4 Planned work. We expect to get to it "soon". labels Dec 12, 2022
@rebron rebron added this to Untriaged Backlog in General Dec 13, 2022
@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General Dec 13, 2022
@spylogsster spylogsster self-assigned this Dec 21, 2022
@spylogsster spylogsster moved this from P4 Backlog to In progress in General Dec 21, 2022
@spylogsster spylogsster mentioned this issue Dec 21, 2022
Merged
25 tasks
General automation moved this from In progress to Completed Dec 22, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 22, 2022
@rebron rebron self-assigned this Dec 28, 2022
@rebron rebron mentioned this issue Jan 4, 2023
Closed
@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jan 6, 2023 •
edited

Verification PASSED using

Brave | 1.48.113 Chromium: 109.0.5414.74 (Official Build) beta (64-bit)
-- | --
Revision | e7c5703604daa9cc128ccf5a5d3e993513758913-refs/branch-heads/5414@{#1172}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Pre-requisite: Download Yandex browser and have data for History, Bookmarks and Extensions

Profile 1: History, Bookmarks and Extensions image Profile 2: History, Bookmarks image

Profile 3: Bookmarks
image

Case 1: Import from brave://settings/importData - PASSED

  1. Install 1.48.113
  2. launch brave
  3. click Skip >> Skip >> Finish
  4. open brave://settings/importData in the new tab page
  5. verified Yandex option is displayed in the Import bookmarks and settings drop down
  6. select Yandex User 1
  7. keep default selections of Browsing history, Favorites/Bookmarks and Extensions
  8. click Import
  9. click Done

Confirmed Bookmarks are shown in the bookmarks bar & brave://bookmarks

Confirmed History is shown in brave://history

Confirmed Extensions are shown in toolbar and brave://extensions

step 4-5 step 7 step 8 bookmarks history extensions
image image image image image image

Case 2: Import from clicking Import bookmarks now... link on the bookmarks bar - PASSED

  1. new profile
  2. launch Brave
  3. click Skip >> Skip >> Finish
  4. click Import bookmarks now...in the bookmarks bar
  5. verified Yandex option displayed in the Import bookmarks and settings modal drop down
  6. select Yandex User 1
  7. unselect default selections and select Favorites/Bookmarks
  8. click import
  9. click Done

Confirmed Bookmarks are shown in the bookmarks bar and brave://bookmarks

step 4 step 5-8 step 9 bookmarks
image image image image

Case 3: Import from multiple profiles - PASSED

  1. new profile
  2. launch Brave
  3. click Skip >> Skip >> Finish
  4. click Hamburger menu >> Import bookmarks and settings...
  5. select Yandex Wild strawberry
  6. keep default selections for Browsing history Favorites/Bookmarks
  7. click import
  8. click Done
  9. repeat steps 5-8 to import Yandex cloud profile

Confirmed bookmarks and history are imported successfully

step 4 step 5-7 step 8 step 9 history bookmarks
image image image image image image

Case 4: Bookmarks imported from Yandex should Sync between devices - PASSED

device 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now... in the bookmarks bar
  4. select Yandex User 1 from Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions
  7. visit brave://sync
  8. click on Start using sync ---> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the Sync everything radio button
Step 5 Step6 Step10 Step 11
image image image image

device 2

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions synced successfully

Note:Browsing history not synced. Only URLs of the sites that were visited in the session are synced

Step 4 Step 7 bookmarks & extensions
image image image

Case 5: Upgrade - PASSED

  1. install 1.47.165
  2. launch Brave
  3. click Import bookmarks now... link in the bookmarks bar
  4. select Chrome Person 3 in the Import bookmarks and settings modal dialog
  5. keep default selections of Browsing history, Favorites/Bookmarks, Extensions and unselect Saved passwords and finish the import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions into Brave
  7. close the browser
  8. install 1.48.118
  9. relaunch Brave
  10. Browsing history, Favorites/Bookmarks, Extensions are retained from Chrome Person 3 import
  11. go to Hamburger menu >>Bookmarks >> Import bookmarks and settings
  12. confirmed Yandex User 1 is listed in the drop down menu of Import bookmarks and settings modal
  13. select Yandex User 1 and keep default selections of Browsing history, Favorites/Bookmarks, Extensions
  14. complete import

Confirmed successfully imported Browsing history, Favorites/Bookmarks, and Extensions from Yandex

Step 5 Step 6 Step 13 Steps 12 & 13 Step 14
image image image image image

@stephendonner
Copy link
Collaborator

stephendonner commented Jan 11, 2023 •
edited

Verification PASSED using

Brave 1.48.121 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Prerequisite: Yandex browser profile, populated with bookmarks, history, and extensions

Case 1: Import from brave://settings/importData - PASSED

  1. installed 1.48.121
  2. launched Brave
  3. clicked Skip -> Skip -> Finish
  4. opened brave://settings/importData in the new-tab page
  5. verified Yandex option is displayed in the Import bookmarks and settings dropdown
  6. selected Yandex User 1
  7. kept default selections of Browsing history, Favorites/Bookmarks and Extensions
  8. clicked Import
  9. clicked Done
steps 4-5 step 7 step 8 bookmarks history extensions
Screen Shot 2023-01-11 at 12 26 50 PM Screen Shot 2023-01-11 at 12 26 56 PM Screen Shot 2023-01-11 at 12 27 01 PM Screen Shot 2023-01-11 at 12 28 37 PM Screen Shot 2023-01-11 at 12 28 29 PM Screen Shot 2023-01-11 at 12 30 25 PM

Confirmed bookmarks are shown in the bookmarks bar & brave://bookmarks

Confirmed history is shown in brave://history

Confirmed extensions are shown in toolbar and brave://extensions

Case 2: Import from Import Bookmarks Now... - PASSED

  1. new profile
  2. launched Brave
  3. clicked Import bookmarks now... in the bookmarks bar
  4. verified Yandex option displayed in the Import bookmarks and settings modal dropdown
  5. selected Yandex User 1
  6. unselected default selections and selected Favorites/Bookmarks
  7. clicked Import
  8. clicked Done

Confirmed bookmarks are shown in the bookmarks bar and in brave://bookmarks

step 4 steps 5-8 step 9 brave://bookmarks
Screen Shot 2023-01-11 at 12 38 30 PM Screen Shot 2023-01-11 at 12 38 53 PM Screen Shot 2023-01-11 at 12 38 57 PM Screen Shot 2023-01-11 at 12 39 08 PM

Case 3: Import from multiple profiles - PASSED

Yandex profiles

Screen Shot 2023-01-11 at 2 09 07 PM
Yandex User 1 imported bookmarks Wild Strawberry imported bookmarks Doggie imported bookmarks
Screen Shot 2023-01-11 at 2 15 26 PM Screen Shot 2023-01-11 at 2 15 52 PM Screen Shot 2023-01-11 at 2 16 06 PM Screen Shot 2023-01-11 at 2 16 32 PM Screen Shot 2023-01-11 at 2 16 50 PM Screen Shot 2023-01-11 at 2 17 13 PM
brave://extensions brave://history
Screen Shot 2023-01-11 at 2 23 22 PM Screen Shot 2023-01-11 at 2 23 43 PM

Case 4: Bookmarks imported from Yandex should sync between devices - PASSED

device 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now... in the bookmarks bar
  4. select Yandex User 1 from Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions
  7. visit brave://sync
  8. click on Start using sync ---> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the Sync everything radio button
example example example example
Screen Shot 2023-01-11 at 2 50 41 PM Screen Shot 2023-01-11 at 2 50 48 PM Screen Shot 2023-01-11 at 2 51 10 PM Screen Shot 2023-01-11 at 2 51 25 PM

device 2

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions synced successfully

Note:Browsing history not synced. Only URLs of the sites that were visited in the session are synced

example example example example
Screenshot 2023-01-11 at 2 52 25 PM Screenshot 2023-01-11 at 2 52 38 PM Screenshot 2023-01-11 at 2 52 57 PM Screenshot 2023-01-11 at 2 53 03 PM

Case 5: Upgrade - PASSED

  1. install 1.47.169
  2. launch Brave
  3. click Import bookmarks now... link in the bookmarks bar
  4. select Chrome Canary Person 1 in the Import bookmarks and settings modal dialog
  5. kept default selections of Browsing history, Favorites/Bookmarks, Extensions and finished the import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions into Brave
  7. close the browser
  8. install 1.48.121
  9. relaunch Brave
  10. Browsing history, Favorites/Bookmarks, Extensions are retained from Chrome Canary Person 1 import
  11. go to Hamburger menu >>Bookmarks >> Import bookmarks and settings
  12. confirmed Yandex User 1 is listed in the drop down menu of Import bookmarks and settings modal
  13. selected Yandex User 1 and keep default selections of Browsing history, Favorites/Bookmarks, Extensions
  14. completed import

Confirmed successfully imported Browsing history, Favorites/Bookmarks, and Extensions from Yandex

example example example example
Screen Shot 2023-01-11 at 3 27 24 PM Screen Shot 2023-01-11 at 3 27 28 PM Screen Shot 2023-01-11 at 3 27 44 PM Screen Shot 2023-01-11 at 3 27 55 PM
example example example example
Screen Shot 2023-01-11 at 3 30 59 PM Screen Shot 2023-01-11 at 3 31 07 PM Screen Shot 2023-01-11 at 3 31 19 PM Screen Shot 2023-01-11 at 3 31 43 PM

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 11, 2023
@stephendonner stephendonner mentioned this issue Jan 11, 2023
Closed
@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 11, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 23, 2023
@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jan 23, 2023 •
edited

Verification PASSED using

Brave | 1.48.137 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Linux

Pre-requisite: Download Yandex browser and have data for History, Bookmarks and Extensions

Profile 1: History, Bookmarks and Extensions
Screenshot from 2023-01-23 09-47-27

Profile 2: History, Bookmarks
Screenshot from 2023-01-23 09-44-18

Profile 3: Bookmarks
Screenshot from 2023-01-23 10-05-08

Case 1: Import from brave://settings/importData - PASSED

  1. Install 1.48.137
  2. launch brave
  3. click Skip >> Skip >> Finish
  4. open brave://settings/importData in the new tab page
  5. verified Yandex option is displayed in the Import bookmarks and settings drop down
  6. select Yandex User 1
  7. keep default selections of Browsing history, Favorites/Bookmarks and Extensions
  8. click Import
  9. click Done

Confirmed Bookmarks are shown in the bookmarks bar & brave://bookmarks

Confirmed History is shown in brave://history

Confirmed Extensions are shown in toolbar and brave://extensions

step 4-5 step 6-8 step 9 bookmarks history extensions
image image image image image image

Case 2: Import from clicking Import bookmarks now... link on the bookmarks bar - PASSED

  1. new profile
  2. launch Brave
  3. click Skip >> Skip >> Finish
  4. click Import bookmarks now...in the bookmarks bar
  5. verified Yandex option displayed in the Import bookmarks and settings modal drop down
  6. select Yandex User 1
  7. unselect default selections and select Favorites/Bookmarks
  8. click import
  9. click Done

Confirmed Bookmarks are shown in the bookmarks bar and brave://bookmarks

step 4 step 5-8 step 9 bookmarks
image image image image

Case 3: Import from multiple profiles - PASSED

  1. new profile
  2. launch Brave
  3. click Skip >> Skip >> Finish
  4. click Hamburger menu >> Import bookmarks and settings...
  5. select Yandex Car
  6. keep default selections for Browsing history Favorites/Bookmarks
  7. click import
  8. click Done
  9. repeat steps 5-8 to import Yandex Ball profile

Confirmed bookmarks and history are imported successfully

step 4 step 5-7 step 8 step 9 bookmarks history
image image image image image image

Case 4: Bookmarks imported from Yandex should Sync between devices - PASSED

Pre- requisite: create two profiles

Profile 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now... in the bookmarks bar
  4. select Yandex User 1 from Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions
  7. visit brave://sync
  8. click on Start using sync ---> Start a new Sync Chain-->Computer
  9. copy the code words
  10. under Sync Settings, click on the Sync everything radio button
Step 5 Step6 Step9
image image image

Profile 2

  1. go to Profile 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions synced successfully

Note:Browsing history not synced. Only URLs of the sites that were visited in the session are synced

Step 4 Step 7 bookmarks & extensions
image image image

Case 5: Upgrade - PASSED

  1. install 1.47.171
  2. launch Brave
  3. click Skip >> Skip >> Finish
  4. click Import bookmarks now... link in the bookmarks bar
  5. select Chrome Person 1 in the Import bookmarks and settings modal dialog
  6. keep default selections of Browsing history, Favorites/Bookmarks, Extensions and unselect Saved passwords and finish the import
  7. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions into Brave
  8. close the browser
  9. install 1.48.137
  10. relaunch Brave
  11. Browsing history, Favorites/Bookmarks, Extensions are retained from Chrome Person 1 import
  12. go to Hamburger menu >>Bookmarks >> Import bookmarks and settings
  13. confirmed Yandex User 1 is listed in the drop down menu of Import bookmarks and settings modal
  14. select Yandex User 1 and keep default selections of Browsing history, Favorites/Bookmarks, Extensions
  15. complete import

Confirmed successfully imported Browsing history, Favorites/Bookmarks, and Extensions from Yandex User 1

step 1 step 5 step 9 step 11 steps 13 result
image image image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 24, 2023
@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
@rebron rebron removed this from Completed in General Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

@rebron rebron

Labels
feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Add import from Yandex browser brave/brave-core
5 participants
@stephendonner @spylogsster @rebron @brave-builds @MadhaviSeelam