Crash when viewing sync code

[Uni-verse]

Description

Crash when viewing sync code in brave://settings/braveSync/setup

Crash Report ID: 1c171b00-fcb4-3d09-0000-000000000000

Steps to Reproduce

Preconditions: Have existing sync chain with some devices

1. Open brave://settings/braveSync/setup
2. Remove 1 device from sync chain
3. Click on View Sync Code

Actual result:

App crashes

Expected result:

Sync codes should be presented

Reproduces how often:

intermittent, very uncommon

Brave version (brave://version info)

Brave	1.46.134 Chromium: 108.0.5359.94 (Official Build) (x86_64)
Revision	713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS	macOS Version 12.6 (Build 21G115)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? No

[AlexeyBarabash]

Here are the STR to make this crash

1. Setup the sync chain, enough to have one device
2. Open brave://settings/braveSync/setup
3. Press View sync code button
4. Adjust system time on two days before
5. Press View QR Code link

[MadhaviSeelam]

Verification PASSED using

Brave | 1.48.118 Chromium: 109.0.5414.80 (Official Build) beta (64-bit)
-- | --
Revision | 0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Reproduced the issue in 1.47.165 using the STR from #27343 (comment)

Steps:

1. Install 1.48.118
2. launch Brave
3. click Skip >> Skip >> Finish
4. visit brave://sync
5. click on Start using sync ---> Start a new Sync Chain
6. click Computer
7. click OK
8. click Manage your synced devices
9. click View Sync Code
10. go to Windows>>Time & language >> Date & Time
11. change system date to two days prior (i.e. from Jan 9 to Jan 7)
12. click View QR Code link

Confirmed QR code is shown

step3	step 4	step 7	step 9	step 10	step 11	step 12	QR code

[stephendonner]

Verified PASSED using

Brave	1.48.118 Chromium: 109.0.5414.80 (Official Build) beta (x86_64)
Revision	0f69b168d36a06cace4365e9f029fa987afa5633-refs/branch-heads/5414@{#1178}
OS	macOS Version 11.7.2 (Build 20G1020)

Steps:

1. installed 1.48.118
2. launched Brave
3. clicked Skip >> Skip >> Finish
4. visited brave://sync
5. clicked on Start using sync ---> Start a new Sync Chain
6. clicked Computer
7. clicked OK
8. clicked Manage your synced devices
9. clicked View Sync Code
10. go to Apple >> System Preferences >> Date & Time
11. change the time to two days prior (i.e. from Jan 9 to Jan 7)
12. click View QR Code link
13. fixed system date
14. joined the Sync chain using iOS

Confirmed no crash when viewing or joining the Sync chain using the QR code

step 3	step 4	step 7	step 9	step 11	step 12	QR code	step 14

[LaurenWags]

Marking as QA/Blocked as this will be uplifted to 1.47.x maintenance release and will need to be retested there. Also removed "QA Pass" labels.

[kjozwiak]

The above requires 1.47.176 or higher for 1.47.x verification 👍

[btlechowski]

Verification passed on

Brave	1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Ubuntu 18.04 LTS

Reproduced the issue in 1.47.169

Verified in 1.47.177

Steps:

1. Install 1.47.177
2. launch Brave
3. click Skip >> Skip >> Finish
4. visit brave://sync
5. click on Start using sync ---> Start a new Sync Chain
6. click Computer
7. click OK
8. click Manage your synced devices
9. click View Sync Code
10. change system date to two days prior (i.e. from Jan 9 to Jan 7)
11. click View QR Code link

Confirmed QR code is shown

step3	step 4	step 7	step 9	step 10	step 12

[MadhaviSeelam]

Verification PASSED

Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Steps:

1. Install 1.47.177
2. launch Brave
3. open a new-tab
4. visit brave://sync
5. click on Start using sync ---> Start a new Sync Chain
6. click Computer
7. click OK
8. click Manage your synced devices
9. click View Sync Code
10. go to Windows Settings>>Time & language >> Date & Time
11. change system date to two days prior (i.e. from Jan 19 to Jan 17)
12. click View QR Code link

Confirmed no crashes occurred and QR code is shown

step5	step 7	step 8	step 9	step 11	QR code

[stephendonner]

Verification PASSED using

Brave	1.47.177 Chromium: 109.0.5414.87 (Official Build) (x86_64)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	macOS Version 11.7.2 (Build 20G1020)

Steps:

1. installed 1.47.177
2. launched Brave
3. clicked Skip >> Skip >> Finish
4. visited brave://sync
5. clicked on Start using sync ---> Start a new Sync Chain
6. clicked Computer
7. clicked OK
8. clicked Manage your synced devices
9. clicked View Sync Code
10. go to Apple >> System Preferences >> Date & Time
11. change the time to two days prior (i.e. from Jan 19 to Jan 17)
12. click View QR Code link
13. fixed system date
14. joined the Sync chain using iOS

Confirmed no crash when viewing or joining the Sync chain using the QR code

step 3	step 4	step 7	step 9	step 11	step 12	QR code	step 14