Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sync code to Syncable Service #2754

Closed
darkdh opened this issue Dec 28, 2018 · 4 comments · Fixed by brave/brave-core#2010
Closed

Migrate sync code to Syncable Service #2754

darkdh opened this issue Dec 28, 2018 · 4 comments · Fixed by brave/brave-core#2010

Comments

@darkdh
Copy link
Member

darkdh commented Dec 28, 2018

https://www.chromium.org/developers/design-documents/sync/syncable-service-api

@darkdh darkdh self-assigned this Dec 28, 2018
@darkdh darkdh added this to Untriaged backlog in Sync via automation Dec 28, 2018
@darkdh darkdh moved this from Untriaged backlog to Inprogress in Sync Dec 28, 2018
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 2, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@darkdh
Copy link
Member Author

darkdh commented May 28, 2019

Test Plan:

  1. Test all sync test cases with fresh profile
  2. Test all sync test cases launching from legacy sync profile (previous version of Brave which doesn't contain this change)
  3. Use new sync device joining existing legacy sync chain (iOS and Android)
  4. Use legacy sync device(iOS and Android) joining new sync chain

Sync automation moved this from In progress to Completed Aug 20, 2019
@kjozwiak kjozwiak added this to the 0.71.x - Nightly milestone Aug 21, 2019
@btlechowski
Copy link

btlechowski commented Aug 26, 2019

LGTM.

Verified test plan from #2754 (comment)

sync 0.71.x with 0.71.x
[PASS] Existing bookmarks sync through code words
[PASS] New bookmark sync
[PASS] New folder sync
[PASS] Moved bookmark
[PASS] Moved bookmark folder
[PASS] Deleted bookmark
[PASS] Deleted bookmark folder
[PASS] 5000 bookmarks sync
[PASS] Sync after going offline

sync 0.71.x with 0.68.x
[PASS] Existing bookmarks sync through code words
[PASS] New bookmark sync
[PASS] New folder sync
[PASS] Moved bookmark
[PASS] Moved bookmark folder
[PASS] Deleted bookmark
[PASS] Deleted bookmark folder
[PASS] 5000 bookmarks sync

sync 0.71.x with Android
[PASS] Existing bookmarks sync through QR code
[PASS] New bookmark sync
[PASS] New folder sync
[PASS] Moved bookmark
[PASS] Moved bookmark folder
[PASS] Deleted bookmark
[PASS] Deleted bookmark folder
[PASS] 5000 bookmarks sync

sync 0.71.x with iOS
[PASS] Existing bookmarks sync through QR code
[PASS] New bookmark sync
[PASS] New folder sync
[PASS] Moved bookmark
[PASS] Moved bookmark folder
[PASS] Deleted bookmark
[PASS] Deleted bookmark folder

Also synced multiple devices at once.
Upgraded 0.68.x with existing sync chain to 0.71.x Made sure sync still works.

@bsclifton
Copy link
Member

Updated labels for QA + assigned milestone after uplifts were done 😄

@darkdh are there any other issues which were closed out with the uplift? If so, can you help me ID them / also mark them as 0.69.x?

@btlechowski
Copy link

btlechowski commented Sep 30, 2019

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified Sync part of manual testrun
Verified #2754 (comment)
Verified #2754 (comment)

Devices used:
Brave 0.69.130
Brave 0.68.142
Android 1.3.2
iOS 1.12.1

Verified passed with

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@rebron rebron removed this from Completed in Sync Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment