Cleanup Google Sign-In permission toggles #28177
Labels
feature/settings
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
release-notes/include
Currently, the Google Sign-In pref in brave://settings is the same as the one in brave://settings/socialBlocking (which shows up if the feature flag for Google Sign-In is off) which is
Allow use of third-party cookies for legacy Google Sign-In
. This is not accurate, because really what the pref should indicate is that sites can ask for 3p cookie access.Also, it's confusing that there's a toggle in brave://settings/content/googleSignIn which seems like a global toggle but is actually just the default toggle. We should get rid of that and only have one way of setting the pref. But then we need to remove the per-site pref from site details that shows up on (for e.g.) brave://settings/content/siteDetails?site=https%3A%2F%2Fgithub.com%2F and prevent the site permission from showing up in brave://settings/content. To do this we will need to restart the browser.
As an additional code-related cleanup, move privacy-related loadtime data booleans to browser/ui/webui/settings/brave_privacy_handler.cc instead of browser/ui/webui/brave_settings_ui.cc
In the future, we might want to sync the top-level pref with the site setting toggle.
To summarize:
The text was updated successfully, but these errors were encountered: