Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sometimes red or orange colored URLs appear in URL bar #28198

Closed
LaurenWags opened this issue Feb 1, 2023 · 7 comments · Fixed by brave/brave-core#18795
Closed

sometimes red or orange colored URLs appear in URL bar #28198

LaurenWags opened this issue Feb 1, 2023 · 7 comments · Fixed by brave/brave-core#18795
Assignees
Labels

Comments

@LaurenWags
Copy link
Member

Description

See the following slack threads:

Sometimes red or orange colored URLs display in the URL bar.

Steps to Reproduce

  1. Clean profile with C109 build, close/relaunch to pull griffin (not sure if necessary, but that's what I did)
  2. Navigated to github.com/brave/brave-core/commits
  3. Open brave://settings/appearance and enabled Always show full URLs (toggled it on, off and on again)
  4. Enabled Autocomplete searches and URLs under brave://settings/privacy
  5. Opened a new tab, typed "core" into URL bar and selected github.com/brave/brave-core/commits to navigate to it
  6. Opened another new tab, typed "core" --> saw red/orange URL in URL bar

Actual result:

some URLs are red/orange, additional examples in slack threads above

Screen Shot 2023-02-01 at 7 14 03 AM

Expected result:

normal color I guess

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.47.186 Chromium: 109.0.5414.119 (Official Build) (x86_64)
-- | --
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | macOS Version 12.6.3 (Build 21G419)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes 1.47.x
  • Can you reproduce this issue with the beta channel? yes 1.48.x
  • Can you reproduce this issue with the nightly channel? unsure, probably yes

Other Additional Information:

Miscellaneous Information:

cc @brave/qa-team

@wknapik
Copy link
Contributor

wknapik commented Feb 1, 2023

The issue here is that hits in red can't be edited. They can either be used as they are, or not at all.

@rebron rebron added this to On Deck in General Feb 1, 2023
@BrajBliss
Copy link

What even is this? Any idea?

@stephendonner
Copy link

What even is this? Any idea?

I don't think we've figured it out, yet - it's perplexed us, too, so far!

@rebron
Copy link
Collaborator

rebron commented Feb 16, 2023

I was able to reproduce following the str. Selecting x for the entry in the url bar, I can't get it come back again.

@markg85
Copy link

markg85 commented Jun 5, 2023

Found the upstream discussion for this: https://bugs.chromium.org/p/chromium/issues/detail?id=1394443

@markg85
Copy link

markg85 commented Jun 5, 2023

As per the above. Disabling it is possible! (just disabled it here locally)
chrome://flags/#omnibox-rich-autocompletion-promising

For the brave devs. Can we please have this feature disabled by default?

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Jun 7, 2023
@rebron rebron moved this from On Deck to In progress in General Jun 13, 2023
General automation moved this from In progress to Completed Jun 15, 2023
@mkarolin mkarolin self-assigned this Jun 15, 2023
@mkarolin mkarolin added this to the 1.54.x - Nightly milestone Jun 15, 2023
@rebron rebron moved this from Completed to Pending review/uplift or retest in General Jun 20, 2023
@stephendonner
Copy link

stephendonner commented Jul 4, 2023

Verification PASSED using

Brave | 1.54.90 Chromium: 115.0.5790.56 (Official Build) beta (x86_64)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | macOS Version 11.7.8 (Build 20G1351)

Followed the steps to reproduce from #28198 (comment).

First, easily reproduced this using 1.47.186. Then, successfully verified the fix in 1.54.90.

1.54.90 1.47.186
Screen Shot 2023-07-04 at 12 15 12 AM Screen Shot 2023-07-03 at 11 01 28 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 4, 2023
@rebron rebron moved this from Pending review/uplift or retest to Completed in General Jul 11, 2023
@rebron rebron removed this from Completed in General Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants