Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show pending transactions in descendant order #28409

Closed
cypt4 opened this issue Feb 9, 2023 · 1 comment · Fixed by brave/brave-core#18310
Closed

Show pending transactions in descendant order #28409

cypt4 opened this issue Feb 9, 2023 · 1 comment · Fixed by brave/brave-core#18310
Assignees
@cypt4
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@cypt4
Copy link
Collaborator

cypt4 commented Feb 9, 2023

When there are pending transactions and users adds a new one then old transaction is shown in the wallet panel.
We need to show them in desc order.
@cypt4 cypt4 self-assigned this Feb 9, 2023
@cypt4 cypt4 added priority/P4 Planned work. We expect to get to it "soon". feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes release-notes/include labels Feb 9, 2023
@cypt4 cypt4 mentioned this issue Apr 30, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Apr 30, 2023
@cypt4
Show pending transactions in descendant order
4253a68 
Resolves brave/brave-browser#28409
cypt4 added a commit to brave/brave-core that referenced this issue May 17, 2023
@cypt4
Show pending transactions in descendant order (#18310)
191f53e 
Resolves brave/brave-browser#28409
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 17, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18310
  • Verified the most recent unapproved transaction is shown first
  • Verified the first submitted unapproved transaction is shown last
  • Encountered #31140
28409.mp4

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Show pending transactions in descendant order brave/brave-core
3 participants
@srirambv @brave-builds @cypt4