Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The preview images of pictures and web links in the discord forum do not load properly #28428

Closed
lovebigbear opened this issue Feb 10, 2023 · 6 comments · Fixed by brave/brave-core#17199
Assignees

Comments

@lovebigbear
Copy link

lovebigbear commented Feb 10, 2023

Description

After I upgraded brave to version 1.48.158 Chromium: 110.0.5481.77 (official version) (arm64), The preview images of pictures and web links in the discord forum do not load properly.
I could only keep refreshing the browser page to load the image, and all of brave's security blocking features were turned on and off repeatedly, but to no avail. chrome with the same Chromium core does not have this problem.

Brave version (brave://version info)

1.48.158 Chromium: 110.0.5481.77 (official version) (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Yes
  • Can you reproduce this issue with the beta channel?
  • I have not try
  • Can you reproduce this issue with the nightly channel?
  • I have not try

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • No
  • Does the issue resolve itself when disabling Brave Rewards?
  • No
  • Is the issue reproducible on the latest version of Chrome?
  • No

Miscellaneous Information:

@jharwig
Copy link

jharwig commented Feb 10, 2023

It seems that Brave is sometimes not firing onload (or onerror) events for images. I made a test page that tries loading a broken image and ensures onerror is called. It fails for me (i.e. a timeout occurs instead of onerror event) in brave randomly in less than 100 attempts. No other browser fails (safari, chrome, chrome canary.) Discord probably checks the that images are available before displaying (I have an application that does similar check and this being broken causes images to not show.)

https://codesandbox.io/s/brave-onload-testing-d9xofv

(Not sure if other events are not working: document.onload, etc)

@Brave-Matt
Copy link

@ryanbr
Copy link

ryanbr commented Feb 14, 2023

I believe this occurred between the Chromium 109->110 bump if someone can confirm? (Nightly build use a sperate profile)

Nightly v1.44.32 (Chromium 104.0.5112.81) OK
Nightly v1.47.91 (Chromium 108.0.5359.48) OK
Nightly v1.49.14 (Chromium 109.0.5414.87) OK
Nightly v1.49.62 (Chromium 109.0.5414.119) OK
Nightly v1.49.64 (Chromium 110.0.5481.52) BAD
Nightly v1.49.69 (Chromium 110.0.5481.52) BAD
Nightly v1.49.77 (Chromium 110.0.5481.52) BAD

@kjozwiak kjozwiak added bug webcompat/not-shields-related Sites are breaking because of something other than Shields. QA/Yes labels Feb 14, 2023
@goodov goodov self-assigned this Feb 14, 2023
@MDouglas345
Copy link

MDouglas345 commented Feb 14, 2023

I have a similar issue, confirm this site is experiencing the same. Issue not present on Chromium 109.0.5414.119 but is present on 110.0.5481.77.

Community link

@kjozwiak
Copy link
Member

The above requires 1.48.164 or higher for 1.48.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.48.171 Chromium: 110.0.5481.177 (Official Build) (64-bit)
-- | --
Revision | f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Went through various Discord channels and ensured that images and link previews are appearing correctly on various channels as per the following:

Example Example Example Example
ds1 ds2 ds3 ds4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants