Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the :-abp-has() procedural selector in adblock rules #28609

Closed
lazymonkey2 opened this issue Feb 19, 2023 · 5 comments · Fixed by brave/brave-core#17313
Closed

Support the :-abp-has() procedural selector in adblock rules #28609

lazymonkey2 opened this issue Feb 19, 2023 · 5 comments · Fixed by brave/brave-core#17313

Comments

@lazymonkey2
Copy link

Description

on https://9gag.com there are "promoted" posts that are not blocked.
they popup after scrolling down on the main page.

here is an example:
image

I have inspected the code:

image

the issue is that the article id is random.

Steps to Reproduce

  1. load the main 9gag page
  2. scroll down until you see a promoted post

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@lazymonkey2 lazymonkey2 added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 19, 2023
@ghost
Copy link

ghost commented Feb 21, 2023

9gag.com#?#article:-abp-has(.promoted) in Easylist is not supported by Brave, it shall be fixed when brave/adblock-rust#273 is merged.

I don't know if Stable already has :has support but Nightly does, so you can temporary add 9gag.com##article:has(.promoted) until Brave team merges that PR and it gets compatibility with those ABP extended CSS selectors.

@antonok-edm antonok-edm self-assigned this Feb 21, 2023
@antonok-edm antonok-edm added the feature/shields/adblock Blocking ads & trackers with Shields label Feb 21, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 22, 2023
@antonok-edm antonok-edm changed the title 9gag promoted ads Support the :-abp-has() procedural selector in adblock rules Feb 22, 2023
@LaurenWags LaurenWags added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 14, 2023
@LaurenWags
Copy link
Member

Not seeing a difference between 1.49.120 (current release) and 1.51.91 (beta).

Asked about it here - https://bravesoftware.slack.com/archives/C3GNZANPR/p1678887643343389.

Labelling as QA/Blocked until we figure this out.

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Mar 15, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Mar 15, 2023

Verified with

Brave | 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

Verified STR from description.
Confirmed when using Aggressive blocking for trackers and ads the promoted posts are not displayed on the site.

Standard (Default) Aggressive
1 50 91 - std 1 50 91 - aggressive

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Verified STR from description.
Confirmed when using Aggressive blocking for trackers and ads the promoted posts are not displayed on the site.

Standard (Default) Aggressive
image image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 15, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.50.99 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Verified STR from description.
Confirmed when using Aggressive blocking for trackers and ads the promoted posts are not displayed on the site.

Standard (Default) Aggressive
image image

@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.112 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230305.008.E1

Went through the STR/Cases outlined via #28609 (comment) and ensured that Promoted posts/content isn't being displayed when Aggressive blocking is being used as per the following:

Example Example
Screenshot_20230403-232712 Screenshot_20230403-232734

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.50.112 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TP1A.220624.014

Went through the STR/Cases outlined via #28609 (comment) and ensured that Promoted posts/content isn't being displayed when Aggressive blocking is being used as per the following:

Example Example
Screenshot_20230403_233129_Brave Screenshot_20230403_233144_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants