Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share via menu item doesn't work in Custom Tabs #28805

Closed
SergeyZhukovsky opened this issue Feb 28, 2023 · 2 comments · Fixed by brave/brave-core#17604
Closed

Share via menu item doesn't work in Custom Tabs #28805

SergeyZhukovsky opened this issue Feb 28, 2023 · 2 comments · Fixed by brave/brave-core#17604
Assignees
@AlexeyBarabash
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.49.x - Release #3

Comments

@SergeyZhukovsky
Copy link
Member

STR:

  1. Open a link in Custom Tabs, from slack or gmail.
  2. Click on a 3 dots menu.
  3. Click Share via...

Actual result:
nothing happens

Expected result:
opens a share with screen selection
@SergeyZhukovsky SergeyZhukovsky added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Feb 28, 2023
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 7, 2023
@AlexeyBarabash
Disable upstream's WarmupManager.initializeViewHierarchy to have Acti…
6feff58 
…vity context and show all Brave menus; fixes brave/brave-browser#28805
@AlexeyBarabash AlexeyBarabash mentioned this issue Mar 7, 2023
Closed
25 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 10, 2023
@AlexeyBarabash
Disable upstream's WarmupManager.initializeViewHierarchy to have Acti…
e13c45b 
…vity context and show all Brave menus; fixes brave/brave-browser#28805
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 10, 2023
@AlexeyBarabash
Disable upstream's WarmupManager.initializeViewHierarchy to have Acti…
9c641a9 
…vity context and show all Brave menus; fixes brave/brave-browser#28805
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 14, 2023
@AlexeyBarabash
Proper initialization of BraveShieldsHandler.mContext
38e03ea 
for custom tabs created via WarmupManager.inflateViewHierarchy

Fixes brave/brave-browser#28805
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 14, 2023
@AlexeyBarabash
Proper initialization of BraveShieldsHandler.mContext
2999e6f 
for custom tabs created via WarmupManager.inflateViewHierarchy

Fixes brave/brave-browser#28805
@AlexeyBarabash AlexeyBarabash mentioned this issue Mar 14, 2023
Merged
25 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Mar 15, 2023
@AlexeyBarabash
Proper initialization of BraveShieldsHandler.mContext
c06f78b 
for custom tabs created via WarmupManager.inflateViewHierarchy

Fixes brave/brave-browser#28805
@AlexeyBarabash AlexeyBarabash added this to the 1.51.x - Nightly milestone Mar 15, 2023
This was referenced Mar 15, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.49.125 or higher for 1.49.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G using version(s):

Brave	1.49.126 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Android 13; Build/TP1A.220624.014

Using STR in #28805 (comment)

  • Ensured that share menu is opening in custom tabs
  • Ensured that user is able to pick a share often
Example Example Example
screenshot-1679504168600 screenshot-1679504185867 screenshot-1679504226188

This was referenced Mar 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release #3
5 participants
@kjozwiak @SergeyZhukovsky @Uni-verse @AlexeyBarabash @brave-builds