Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid asset highlighted on Buy and Deposit #28829

Closed
Pavneet-Sing opened this issue Mar 1, 2023 · 2 comments · Fixed by brave/brave-core#17538
Closed

Invalid asset highlighted on Buy and Deposit #28829

Pavneet-Sing opened this issue Mar 1, 2023 · 2 comments · Fixed by brave/brave-core#17538
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Mar 1, 2023 •
edited
Loading

Description

Mostly Solana assets are being selected irrespective of selected asset chain.

invalid-selected-deposit-asset.webm

Expected result:

Should select the correct asset with chain

Reproduces how often:

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current release? Y
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? Y
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 1, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 9, 2023
This was referenced Mar 9, 2023
Merged
Merged
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@srirambv
Copy link
Contributor

Verified as part of #26246 (comment)

@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
@srirambv
Copy link
Contributor

srirambv commented May 3, 2023

Removing OS/Android label as this is desktop only. Android has a different flow on Buy screen as of now.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Pre-Fill Search on Fund Screens brave/brave-core
4 participants
@Pavneet-Sing @srirambv @Douglashdaniel @brave-builds