Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Portfolio Asset Routing #17544

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Mar 9, 2023

Description

We will now include chainId as a param when selecting any assets from the Portfolio page.

  • Fixes a bug where selecting Ethereum on Optimism or Aurora would select Ethereum on Ethereum Mainnet
  • Fixes a bug where when selecting a tokens from the panel was only passing the Symbol as a Param

Routes are now normalized for the following situations

  • Native Assets: crypto/portfolio/chainId/symbol
  • Fungible Tokens: crypto/portfolio/chainId/contractAddress
  • Non-Fungible Tokens: crypto/portfolio/chaindId/contractAddress/tokenId
  • Market Data: crypto/market/symbol (chainId and contractAddress are not available in this situation.)

Resolves brave/brave-browser#28976

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Portfolio page and select ETH on Optimism, it should load ETH on Optimism on the asset details page.
  2. Go to the Portfolio page and select ETH on Aurora, it should load ETH on Aurora on the asset details page.
  3. Open the Panel and click View account assets, select a token. It route correctly to the assets details page.

Before:

AssetDetailsBefore.mov

After:

Screen.Recording.12.mov

@Douglashdaniel Douglashdaniel self-assigned this Mar 9, 2023
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner March 9, 2023 19:09
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Mar 9, 2023
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take the opportunity to normalize routes for all assets? There are some tokens that are deployed to the same address (using CREATE2) across networks that'll suffer from similar bugs.

This is the format I propose:

/crypto/portfolio/0xa/ETH -> optimism eth
/crypto/portfolio/0xa/0x94b008aa00579c1307b0ef2c499ad98a8ce58e58 -> optimism USDT
/crypto/portfolio/0xa/USDT -> optimism USDT

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel
Copy link
Contributor Author

Can we take the opportunity to normalize routes for all assets? There are some tokens that are deployed to the same address (using CREATE2) across networks that'll suffer from similar bugs.

This is the format I propose:

/crypto/portfolio/0xa/ETH -> optimism eth
/crypto/portfolio/0xa/0x94b008aa00579c1307b0ef2c499ad98a8ce58e58 -> optimism USDT
/crypto/portfolio/0xa/USDT -> optimism USDT

Updated the routes to work as so:

  • Native Assets: crypto/portfolio/chainId/symbol
  • Fungible Tokens: crypto/portfolio/chainId/contractAddress
  • Non-Fungible Tokens: crypto/portfolio/chaindId/contractAddress/tokenId
  • Market Data: crypto/market/symbol (chainId and contractAddress are not available in this situation.)

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
3 participants