Crash at ChromePreferenceKeyChecker

[AlexeyBarabash]

There is a crash report on GP that indicates ChromePreferenceKeyChecker.

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.handleReceiver (ActivityThread.java:4369)
  at android.app.ActivityThread.access$1600 (ActivityThread.java:268)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2106)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:201)
  at android.os.Looper.loop (Looper.java:288)
  at android.app.ActivityThread.main (ActivityThread.java:7941)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:553)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)
Caused by java.lang.RuntimeException:
  at org.chromium.chrome.browser.preferences.ChromePreferenceKeyChecker.checkIsKeyInUse (ChromePreferenceKeyChecker.java:69)
  at org.chromium.chrome.browser.preferences.SharedPreferencesManager.writeBoolean (SharedPreferencesManager.java:492)
  at org.chromium.chrome.browser.widget.quickactionsearchandbookmark.utils.BraveSearchWidgetUtils.setShouldShowWidgetPromo (BraveSearchWidgetUtils.java:32)
  at org.chromium.chrome.browser.widget.quickactionsearchandbookmark.QuickActionSearchAndBookmarkWidgetProvider.onReceive (QuickActionSearchAndBookmarkWidgetProvider.java:179)
  at android.app.ActivityThread.handleReceiver (ActivityThread.java:4359)

Never happens on Stable and Beta builds.

Upstream's SharedPreferencesManager simplifies work with SharedPreferences , but also uses ChromePreferenceKeyChecker to allow work with only registered prefs.

Brave's code already has the places where this check is disabled with SharedPreferencesManager.getInstance().disableKeyCheckerForTesting();:

• https://github.com/brave/brave-core/blob/master/android/java/org/chromium/chrome/browser/app/BraveActivity.java#L271
• https://github.com/brave/brave-core/blob/master/android/java/org/chromium/chrome/browser/document/BraveLauncherActivity.java#L26

There is at least one other place I saw where check happens without disabling, the one from the above. I also could see it once.

The solution is to disable the check at the SharedPreferencesManager or ChromePreferenceKeyChecker class, at one place.

[GeetaSarvadnya]

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.52.72 and Bravemonoarm64.apk_1.51.105

Verified the test plan from brave/brave-core#17431 and ensured that there is no crash when Nightly widget is added to the home screen

vidma_recorder_27042023_104056.mp4