Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet Permission Duration (Desktop UI) #28841

Closed
darkdh opened this issue Mar 1, 2023 · 1 comment · Fixed by brave/brave-core#17700
Closed

Wallet Permission Duration (Desktop UI) #28841

darkdh opened this issue Mar 1, 2023 · 1 comment · Fixed by brave/brave-core#17700
Assignees
@Douglashdaniel
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Mar 1, 2023

Parent issue: #28840
Pass user chosen lifetime option (kPageClosed, k24Hours, k7Days and kForever) to new mojo PanelHandler::ConnectToSite API.
QA should at least test kPageClosed and kForever
@darkdh darkdh added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 1, 2023
@jamesmudgett jamesmudgett added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 3, 2023
@muliswilliam muliswilliam self-assigned this Mar 9, 2023
@Douglashdaniel Douglashdaniel added release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 15, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Mar 21, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 24, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Mar 27, 2023
Merged
25 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Linux
  • Verified steps from brave/brave-core#17700
  • Verified permission duration is shown before connecting to Dapp
  • Verified permission is removed when the dapp is closed when set to Until I close the site
  • Verified for both Solana and Ethereum Dapps
28841.mp4

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17700
  • Verified permission duration is shown before connecting to Dapp
  • Verified permission is removed when the dapp is closed when set to Until I close the site
  • Verified for both Solana and Ethereum Dapps
28841.mp4

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (arm64)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17700
  • Verified permission duration is shown before connecting to Dapp
  • Verified permission is removed when the dapp is closed when set to Until I close the site
  • Verified for both Solana and Ethereum Dapps
28841.mov

@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Permissions Duration UI brave/brave-core
7 participants
@jamesmudgett @darkdh @HEagle18 @srirambv @Douglashdaniel @brave-builds @muliswilliam