Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Token Amount instead of Fiat Amount in Offramp Flow #28960

Closed
Douglashdaniel opened this issue Mar 8, 2023 · 1 comment · Fixed by brave/brave-core#17535
Closed

Use Token Amount instead of Fiat Amount in Offramp Flow #28960

Douglashdaniel opened this issue Mar 8, 2023 · 1 comment · Fixed by brave/brave-core#17535
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to update the Offramp flow to have the users enter the Token amount they want to sell instead of Fiat amount

  • Enter crypto amount instead of fiat amount
  • Remove fiat balances
  • Remove the minimum threshold of $50 for entered amount
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 8, 2023
@Douglashdaniel Douglashdaniel self-assigned this Mar 8, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Mar 8, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Linux
  • Verified steps from brave/brave-core#17535
  • Verified input amount is now taking Token amount and not Fiat amount
  • Verified minimum $50 sell amount message is not shown anymore
  • Verified input amount is carry forwarded to the off-ramp page
28960.mp4

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17535
  • Verified input amount is now taking Token amount and not Fiat amount
  • Verified minimum $50 sell amount message is not shown anymore
  • Verified input amount is carry forwarded to the off-ramp page
28960.mp4

Verification passed on

Brave 1.51.103 Chromium: 112.0.5615.165 (Official Build) beta (arm64)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17535
  • Verified input amount is now taking Token amount and not Fiat amount
  • Verified minimum $50 sell amount message is not shown anymore
  • Verified input amount is carry forwarded to the off-ramp page
28960.mov

@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Remove Fiat from Offramp Flow brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds