Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ETH icons for EVM networks with ETH as the Native Asset #29225

Closed
Douglashdaniel opened this issue Mar 22, 2023 · 1 comment · Fixed by brave/brave-core#17716
Closed

Use ETH icons for EVM networks with ETH as the Native Asset #29225

Douglashdaniel opened this issue Mar 22, 2023 · 1 comment · Fixed by brave/brave-core#17716
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@Douglashdaniel
Copy link

Description

Use ETH icon for EVM networks with ETH as the Native Asset

Example Aurora Mainnet and Optimism

Screenshot 35
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 22, 2023
@Douglashdaniel Douglashdaniel self-assigned this Mar 22, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Mar 22, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 23, 2023
@srirambv
Copy link
Contributor

**Verification passed on **

Brave 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Linux
  • Verified steps from brave/brave-core#17716
  • Verified ETH icon is shown for native asset for Aurora and Optimism EVM's with network icon
  • Verified selecting the native asset shows the correct network name
29225.mp4

Verification passed on

Brave 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17716
  • Verified ETH icon is shown for native asset for Aurora and Optimism EVM's with network icon
  • Verified selecting the native asset shows the correct network name
29225.mp4

Verification passed on

Brave 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (arm64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17716
  • Verified ETH icon is shown for native asset for Aurora and Optimism EVM's with network icon
  • Verified selecting the native asset shows the correct network name
29225.mov

This was referenced May 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Use ETH icon for Native ETH Assets brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds