Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Improve Search suggestions setting to default on for Brave Search #29517

Open
1 of 2 tasks
rebron opened this issue Apr 5, 2023 · 5 comments · May be fixed by brave/brave-core#18157
Open
1 of 2 tasks

Turn Improve Search suggestions setting to default on for Brave Search #29517

rebron opened this issue Apr 5, 2023 · 5 comments · May be fixed by brave/brave-core#18157
Assignees
Projects

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 5, 2023

Description

Design (placeholder)

Brave version (brave://version info)

Target version tbd.

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related: #18331, #23814, #26181, #27709

@rebron
Copy link
Collaborator Author

rebron commented Apr 14, 2023

cc: @aguscruiz design mock of setting in the proper location when you get a chance, should be a quick one.

@simonhong simonhong self-assigned this Apr 14, 2023
@simonhong
Copy link
Member

simonhong commented Apr 17, 2023

should be defaulted on for the following regions for IN / CA / DE / FR / GB / US / AT / ES / MX / BR / AR for new and existing Brave Search users.

@rebron When we set on as a default for these regions and Brave Search users,
then we should set off again when users in that area choose another search provider?

@rebron
Copy link
Collaborator Author

rebron commented Apr 18, 2023

@simonhong Yes. Should act similarly to how we do autocomplete suggestions. It maybe that we need to change the UI/UX for this and make it a checkbox.

@simonhong
Copy link
Member

Ok, got it. changing default value based on current search provider.
Whenever user change search provider, set default value as On if user selected Brave Search.
Otherwise, set default value Off.

and IMO current toggle box seems ok because we only need to control its on/off?

@simonhong simonhong moved this from On Deck to In progress in Settings Apr 20, 2023
simonhong added a commit to brave/brave-core that referenced this issue Apr 20, 2023
fix brave/brave-browser#29517

We'll turn it on when Brave Search is default provider in specific countries.
simonhong added a commit to brave/brave-core that referenced this issue Apr 21, 2023
fix brave/brave-browser#29517

We'll turn it on when Brave Search is default provider in specific countries.
simonhong added a commit to brave/brave-core that referenced this issue Apr 21, 2023
fix brave/brave-browser#29517

We'll turn it on when Brave Search is default provider in specific countries.
simonhong added a commit to brave/brave-core that referenced this issue Apr 24, 2023
fix brave/brave-browser#29517

We'll turn it on when Brave Search is default provider in specific countries.
@aguscruiz
Copy link

@rebron rebron moved this from In progress to On Deck in Settings Feb 13, 2024
@rebron rebron moved this from On Deck to P1 & P2 Backlog in Settings May 3, 2024
@rebron rebron moved this from P1 & P2 Backlog to In progress in Settings May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Settings
In progress
Development

Successfully merging a pull request may close this issue.

3 participants