Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Buy-Send-Swap actions on Portfolio, NFT, Account tab and use default network for BSS #29695

Closed
2 tasks done
Pavneet-Sing opened this issue Apr 13, 2023 · 2 comments · Fixed by brave/brave-core#18343
Closed
2 tasks done

Show Buy-Send-Swap actions on Portfolio, NFT, Account tab and use default network for BSS #29695

Pavneet-Sing opened this issue Apr 13, 2023 · 2 comments · Fixed by brave/brave-core#18343
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Apr 13, 2023 •
edited

Description

Bind Buy Send Swap actions to

Tasks
Beta Give feedback

More info link

Related:
@Pavneet-Sing Pavneet-Sing added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include labels Apr 13, 2023
@Pavneet-Sing Pavneet-Sing changed the title Bind Buy-Send-Swap actions with Portfolio and NFT tab network selector Show Buy-Send-Swap actions on Portfolio, NFT, Account tab and use default network for BSS Apr 14, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 14, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Apr 14, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue May 3, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 4, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue May 4, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.52.95 or higher for 1.52.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.52.113 x64 build

  • Verified steps from brave/brave-core#18343
  • Verified Buys/Send/Swap button is shown on Portfolio/NFT/Accounts tab and defaults to Ethereum when selected
29695.mp4

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Always show buy send swap action brave/brave-core
5 participants
@jamesmudgett @kjozwiak @Pavneet-Sing @srirambv @brave-builds