Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ensure users can see Swap functionality on portfolio page for new wallet users #6811

Closed
HEagle18 opened this issue Jan 20, 2023 · 1 comment · Fixed by #6935
Closed

Ensure users can see Swap functionality on portfolio page for new wallet users #6811

HEagle18 opened this issue Jan 20, 2023 · 1 comment · Fixed by #6935

Comments

@HEagle18
Copy link

Description

Right now on iOS, when a new wallet is setup. The users default account goes to Solana and since we don't currently have Solana swaps on Mobile, we don't show this option.

A temporary fix to this is to show the swap functionality on the portfolio screen beside BUY and SEND, even though Solana swaps isn't supported yet.

Link to conversation https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1674231066776899

Steps to Reproduce

  1. Set up a new wallet
  2. Click the action button at bottom of the screen

Actual result:

IMG_6592

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@StephenHeaps StephenHeaps transferred this issue from brave/brave-browser Jan 20, 2023
@StephenHeaps StephenHeaps self-assigned this Feb 10, 2023
StephenHeaps added a commit that referenced this issue Feb 13, 2023
Always show Buy and Swap in the Wallet buy/send/swap pan modal, regardless of currently selected network. Network can be changed in Buy/Swap if unsupported.
@iccub iccub added this to the 1.48 milestone Feb 13, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.48 (23.2.15.17)

  • Verified steps from #6935
  • Verified Buy, Send and Swap buttons are shown for all networks
  • Verified for unsupported network, selecting Swap shows message
  • Encountered #6965
iPhone 7+ (iOS 14.8.1) iPhone XR (iOS 15.7.1) iPad Pro (16.2)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.