Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement new Rewards onboarding ("giftbox") #30309

Closed
Miyayes opened this issue May 12, 2023 · 6 comments · Fixed by brave/brave-core#18996
Closed

[Android] Implement new Rewards onboarding ("giftbox") #30309

Miyayes opened this issue May 12, 2023 · 6 comments · Fixed by brave/brave-core#18996
Assignees
@sujitacharya2005
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Milestone
1.58.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 12, 2023 •
edited
Loading

Description

Designs: https://www.figma.com/file/VIkvO8TBQXVBnvKn4w8iYu/BR-onboarding?type=design&node-id=0-1

For brave://rewards page when user is non-connected, have this behavior: #31592 (no "Start using Rewards" button, but just text that tells user to press the BAT icon in the URL bar).
@Miyayes Miyayes added feature/rewards QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 12, 2023
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation May 12, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 17, 2023
@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards May 17, 2023
@Miyayes Miyayes moved this from Backlog to In progress in Brave Rewards Jun 8, 2023
@sujitacharya2005 sujitacharya2005 mentioned this issue Jun 22, 2023
Merged
25 tasks
Brave Rewards automation moved this from In progress to Done Jul 5, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jul 5, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jul 12, 2023 •
edited
Loading

QA, please note that the brave://rewards portion was not implemented as part of the PR for this issue. It'll be implemented here: #31592 But you can QA it as part of this larger issue. #31592 will make it into a later build, so let's test this new Rewards onboarding in a build that #31592 is in. cc: @GeetaSarvadnya

@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Aug 23, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 5, 2023 •
edited
Loading

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.58.114

  • Verified the Figma and description from [Android] Implement new Rewards onboarding ("giftbox") #30309 (comment)
  • Confirmed that content of the each slide is as per the Figma spec and content is inlined with Desktop
  • Confirmed that animation of each slide is as per the Figma spec
  • Open brave and Open a NTP and tap on the BAT logo or open any publisher page and tap on the BR panel opens up the Start using Rewards slide with the How does it work? link. Confirmed that the click on the link redirects to the https://brave.com/rewards-tour/
  • Confirmed that click on the Learn more link brave rewrads page redirects to the https://brave.com/rewards-tour/
  • Confirmed that click on How does Brave Rewrads work? link in the Woohoo! You're all set! slide redirects to https://brave.com/rewards-tour/ page
  • Confirmed that click on Done in the Woohoo! You're all set! slide redirects to https://brave.com/rewards-tour/ page
  • Confirmed that click on the Brave Rewards via Hamburger menu opens up the brave://rewrads page with the test message Press the BAT icon in the URL bar to start message as expected

Entry points for onboarding slides

Example Example Example
Screenshot_20230906_161414 Screenshot_20230906_162035 Screenshot_20230906_162659

Onboarding slides

Example Example Example Example
Screenshot_20230906_135912 Screenshot_20230906_140048 Screenshot_20230906_140201 Screenshot_20230906_154111

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 5, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 13, 2023 •
edited
Loading

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.58.121

Logged #32973

  • Verified the Figma and description from [Android] Implement new Rewards onboarding ("giftbox") #30309 (comment)
  • Confirmed that content of the each slide is as per the Figma spec and content is inlined with Desktop
  • Confirmed that animation of each slide is as per the Figma spec
  • Open brave and Open a NTP and tap on the BAT logo or open any publisher page and tap on the BR panel opens up the Start using Rewards slide with the How does it work? link. Confirmed that the click on the link redirects to the https://brave.com/rewards-tour/
  • Confirmed that click on the Learn more link brave rewrads page redirects to the https://brave.com/rewards-tour/
  • Confirmed that click on How does Brave Rewrads work? link in the Woohoo! You're all set! slide redirects to https://brave.com/rewards-tour/ page
  • Confirmed that click on Done in the Woohoo! You're all set! slide redirects to https://brave.com/rewards-tour/ page
  • Confirmed that click on the Brave Rewards via Hamburger menu opens up the brave://rewrads page with the test message Press the BAT icon in the URL bar to start message as expected

Entry points for onboarding slides

Example Example Example
Screenshot_20230913-165619_Brave Screenshot_20230913-165843_Brave Screenshot_20230913-170417_Brave

Onboarding slides

Example Example Example Example
Screenshot_20230913-170447_Brave Screenshot_20230913-170504_Brave Screenshot_20230913-170510_Brave Screenshot_20230913-170517_Brave

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 13, 2023 •
edited
Loading

@Miyayes @deeppandya : User can't scroll navigate through the onboarding slides in Tablet like Android ARM . The next button is present to navigate through the slides also user can click on each slide header to view the content of each slide same like Desktop. I am not sure this is exepcted or should it made same like Android ARM. Figma spec doesn't have Android Tablet specifications. I just wanted to bring it to your notice.

cc: @LaurenWags

@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 13, 2023

@Miyayes @deeppandya : User can't scroll navigate through the onboarding slides in Tablet like Android ARM . The next button is present to navigate through the slides also user can click on each slide header to view the content of each slide same like Desktop. I am not sure this is exepcted or should it made same like Android ARM. Figma spec doesn't have Android Tablet specifications. I just wanted to bring it to your notice.

cc: @LaurenWags

I think we should file @GeetaSarvadnya

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 13, 2023
Open
@Uni-verse
Copy link
Contributor

Verified on Pixel 2 XL running Android 8.1.0 using version(s)

Brave	1.58.122 Chromium: 117.0.5938.62 (Official Build) (64-bit) 
Revision	623437a8c792953b7bc4574f2d9ccdfd59e0ca67
OS	Android 8.1.0; Build/OPM2.171026.006.H1; 27; REL

Encountered: #32988

  • Verified the Figma and description from [Android] Implement new Rewards onboarding ("giftbox") #30309 (comment)
  • Confirmed that content of the each slide is as per the Figma spec and content is inlined with Desktop
  • Confirmed that animation of each slide is as per the Figma spec
  • Open brave and Open a NTP and tap on the BAT logo or open any publisher page and tap on the BR panel opens up the Start using Rewards slide with the How does it work? link. Confirmed that the click on the link redirects to the https://brave.com/rewards-tour/
  • Confirmed that click on the Learn more link brave rewrads page redirects to the https://brave.com/rewards-tour/
  • Confirmed that click on How does Brave Rewrads work? link in the Woohoo! You're all set! slide redirects to https://brave.com/rewards-tour/ page
  • Confirmed that click on Done in the Woohoo! You're all set! slide redirects to https://brave.com/rewards-tour/ page
  • Confirmed that click on the Brave Rewards via Hamburger menu opens up the brave://rewrads page with the test message Press the BAT icon in the URL bar to start message as expected
Example Example Example Example
Screenshot 2023-09-13 at 5 05 44 PM Screenshot 2023-09-13 at 5 05 57 PM Screenshot 2023-09-13 at 5 36 13 PM Screenshot 2023-09-13 at 5 40 37 PM

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujitacharya2005 sujitacharya2005

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Rewards onBoarding brave/brave-core
6 participants
@kjozwiak @Miyayes @Uni-verse @sujitacharya2005 @GeetaSarvadnya @brave-builds