Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave pkg installer creates BraveSoftware folder as root #30546

Closed
spylogsster opened this issue May 24, 2023 · 8 comments · Fixed by brave/brave-core#18593
Closed

Brave pkg installer creates BraveSoftware folder as root #30546

spylogsster opened this issue May 24, 2023 · 8 comments · Fixed by brave/brave-core#18593
Assignees
@spylogsster
Labels
bug OS/Desktop OS/macOS QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include setup/installer
Milestone
1.56.x - Release #7

Comments

@spylogsster
Copy link

spylogsster commented May 24, 2023 •
edited

Description

Pkg installer sets root permission to ~/Library/Application Support/BraveSoftware folder.
drwxr-xr-x 3 root staff 96 May 24 13:10 BraveSoftware.
It doesnt allow browsers from other channels to create their profiles.

Steps to Reproduce

  1. Install brave stable from pkg
  2. Install brave Nightly/Beta from dmg or build from sources

Actual result:

Browser crashed on start

Expected result:

Browser launched successfully

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@spylogsster spylogsster mentioned this issue May 24, 2023
Merged
25 tasks
@spylogsster spylogsster self-assigned this May 24, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone May 24, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 27, 2023 •
edited

@spylogsster will this fix anyone currently experiencing this issue or will this only prevent the problem going forward?

Marking as QA/Blocked until the above is confirmed and discussion in https://bravesoftware.slack.com/archives/C01826CM3J9/p1690214773687379 is resolved/understood.

@LaurenWags
Copy link
Member

Per discussion in above thread, this prevents the problem going forward, it will not fix anyone currently experiencing this issue.

From @spylogsster via https://bravesoftware.slack.com/archives/C01826CM3J9/p1690469928520929?thread_ts=1690214773.687379&cid=C01826CM3J9:

In theory the issue should be fixed if users will re-install the new version using new pkg, otherwise need either:
remove ~/Library/Application Support/BraveSoftware and relaunch
or fix folder permissions sudo chown -R $USER ~/Library/Application\ Support/BraveSoftware

Note - removing the BraveSoftware folder will remove your profile. Proceed with caution on either option if you choose to use one.

@rebron rebron added this to Completed in General Jul 27, 2023
@rebron rebron moved this from Completed to Pending review/uplift or retest in General Jul 27, 2023
@bsclifton bsclifton mentioned this issue Jul 27, 2023
Merged
7 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Jul 27, 2023 •
edited

Verified with

Brave	1.57.27 Chromium: 115.0.5790.114 (Official Build) beta (arm64) 
Revision	18977fb43f693d5a8deeb48bd1cfa52651d3f73e
OS	macOS Version 13.5 (Build 22G74)

Reproduced the issue using STR from description.

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) .pkg file (can use GH or brave.com) - note, .pkg from brave.com is ref code tagged
  3. Downloaded Nightly (1.58.x) .dmg (can use GH or brave.com/download-nightly)
  4. Installed Release from .pkg
  5. Installed Nightly from .dmg
  6. Release launches fine, no issues
  7. Nightly crashes on launch
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
    drwxr-xr-x 3 root staff 96 Jul 28 08:40 BraveSoftware

Case 1 - Install 1.57.x (Beta) using refcode tagged .pkg and install 1.58.x (Nightly) using .dmg - PASSED

Covers:

  • Installing a beta version with the fix via .pkg and a nightly version with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on both channels (from a version with the fix to a version with the fix for both channels)
  • checking permissions on BraveSoftware profile folder
  • promo code check for Beta version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) .dmg (used GH to get this)
  4. Installed Beta from .pkg
  5. Installed Nightly from .dmg
  6. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  7. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 laurenwags  staff   96 Jul 28 10:47 BraveSoftware
  1. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  2. Confirm Beta launches fine, no issues
  3. Check brave://local-state for promo code data

beta 1

  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Watch logs for both versions to confirm that background updates are found for both Beta and Nightly
  4. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  5. Launch Nightly with logs again as above
  6. Confirm Nightly is updated to version listed in logs, quit Nightly
  7. Launch Beta with logs again as above
  8. Confirm Beta is updated to version listed in logs.
  9. Confirm promo code data in brave://local-state:

beta 2

Case 2 - Install version on 1.57.x without this fix and then update to the latest - PASSED

Covers:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Nightly (1.54.3) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code (note, first version with this fix is 1.54.4 per https://github.com/brave/brave-core/commits/master?after=937a82201c8cba2f4709f7731b40561e8422e5cd+1469&branch=master&qualified_name=refs%2Fheads%2Fmaster)
  3. Installed Nightly from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwxr-xr-x   3 root        staff   96 Jul 28 11:44 BraveSoftware
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Check brave://local-state for promo code data

N1

  1. Watch logs for to confirm that background updates are found
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit
  3. Launch Nightly with logs again as above
  4. Confirm Nightly is updated to version listed in logs.
  5. Confirm promo code data in brave://local-state:

N2

Case 3 - Re-run Case 1 but as non-Admin user - PASSED

Covers:

  • Installing a beta version with the fix via .pkg and a nightly version with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on both channels (from a version with the fix to a version with the fix for both channels)
  • checking permissions on BraveSoftware profile folder
  • promo code check for Beta version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) .dmg (used GH to get this)
  4. Installed Beta from .pkg
  5. Installed Nightly from .dmg
  6. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  7. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x  3 nonadmin  staff   96 Jul 28 12:34 BraveSoftware
  1. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  2. Confirm Beta launches fine, no issues (enter password for keychain access if prompted and select "Always Allow")
  3. Check brave://local-state for promo code data
B1
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues (enter password for keychain access if prompted and select "Always Allow")
  3. Watch logs for both versions to confirm that background updates are found for both Beta and Nightly
  4. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  • Note, if you don't see this, close both and relaunch both from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update)
  1. Install update(s) and relaunch
  2. Confirm promo code data in brave://local-state:
B2

Case 4 - Spot check on-demand updates - PASSED

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version with the fix to a version with the fix
    • on-demand updates going from a version without the fix to a version with the fix

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Installed Beta from .pkg
  4. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  5. Confirm Beta launches fine, no issues
  6. Quickly close Beta before background update is found
  7. Relaunch Beta and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Beta is updated to latest
Example Example
1 2
  1. Removed previous installs and profiles as follows:
  • Deleted all Brave instances from Applications folder
  • Deleted BraveSoftware folder from ~/Library/Application Support
  • Deleted BraveSoftware folder from ~/Library/Caches
  • Don't need to worry about other items this time or restarting the machine
  1. Downloaded a 1.53.99 Beta (this is 1.56.x code base) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  2. Installed Beta from .pkg
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Quickly close Beta before background update is found
  6. Relaunch Beta and navigate to brave://settings/help
  7. Confirm update is found
  8. Relaunch and confirm Beta is updated to latest
Example Example
3 4

Non-Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Installed Beta from .pkg
  4. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  5. Confirm Beta launches fine, no issues
  6. Quickly close Beta before background update is found
  7. Relaunch Beta and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Beta is updated to latest
Example Example Example
1 2 3
  1. Removed previous installs and profiles as follows:
  • Deleted all Brave instances from Applications folder
  • Deleted BraveSoftware folder from ~/Library/Application Support
  • Deleted BraveSoftware folder from ~/Library/Caches
  • Don't need to worry about other items this time or restarting the machine
  1. Downloaded a 1.53.99 Beta (this is 1.56.x code base) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  2. Installed Beta from .pkg
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Quickly close Beta before background update is found
  6. Relaunch Beta and navigate to brave://settings/help
  7. Confirm update is found
  8. Relaunch and confirm Beta is updated to latest
Example Example Example
4 5 6

@kjozwiak
Copy link
Member

The above requires 1.56.18 or higher for 1.56.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 1, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Aug 1, 2023 •
edited

Verified with

Brave	1.56.18 Chromium: 115.0.5790.138 (Official Build) (x86_64) 
Revision	0567db0e7dcdfee5c109c167119ac2a92b9b3e1a-refs/branch-heads/5790_85@{#9}
OS	macOS Version 12.6.8 (Build 21G725)

Reproduced the issue using STR from description.

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) .pkg file (can use GH or brave.com) - note, .pkg from brave.com is ref code tagged
  3. Downloaded Nightly (1.58.x) .dmg (can use GH or brave.com/download-nightly). Do the same for Beta (1.57.x)
  4. Installed Release from .pkg
  5. Installed Nightly and Beta from .dmg
  6. Release launches fine, no issues
  7. Nightly crashes on launch. Beta crashes on launch.
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
drwxr-xr-x   3 root    staff    96 Aug  1 09:28 BraveSoftware

Existing User Case - attempt to manually fix install currently experiencing this issue - PASSED

Note, per internal discussions, simply upgrading to latest version will not fix the issue it just prevents it from occurring in the future. However, following the below steps (installing latest from brave.com over your existing install) does fix the permissions issue.

  1. Run through STR to reproduce the issue using 1.56.14 (current release version).
  2. Install 1.56.18 (via .pkg) over existing 1.56.14 install.
  3. Confirm able to launch Beta and Nightly now.
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
drwxr-xr-x   3 lauren  staff    96 Aug  1 09:28 BraveSoftware

Case 1 - Install 1.56.x (RC) using refcode tagged .pkg and install 1.58.x (Nightly), 1.57.x (Beta) using .dmg - Partially PASSED

Note, since we only have one RC which contains this fix, unable to check updating on Release from one version with the fix to another version with the fix. This was checked prior to uplift on both Nightly and Beta though.

Covers:

  • Installing RC version with the fix via .pkg and nightly + beta versions with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on Beta/Nightly channels (from a version with the fix to a version with the fix for all channels) - unable to check Release as there's only one RC with the fix at the moment
  • checking permissions on BraveSoftware profile folder
  • promo code check for RC version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) universal .dmg (used GH to get this)
  4. Downloaded Beta (1.57.17) universal .dmg (used GH to get this)
  5. Installed RC from .pkg
  6. Installed Beta from .dmg
  7. Installed Nightly from .dmg
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 lauren  staff    96 Aug  1 09:47 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data

RC1

  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Watch logs for all versions to confirm that background updates are found for both Beta and Nightly
  6. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  7. Launch Nightly with logs again as above
  8. Confirm Nightly is updated to version listed in logs, quit Nightly
  9. Launch Beta with logs again as above
  10. Confirm Beta is updated to version listed in logs.
  11. Close and relaunch RC
  12. Confirm promo code data is retained in brave://local-state:

RC2

Case 2 - Install version on 1.56.x (Release) without this fix and then update to the latest (using background updates) - PASSED

Covers:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwxr-xr-x   3 root    staff    96 Aug  1 10:10 BraveSoftware
  1. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  2. Confirm Release launches fine, no issues
  3. Check brave://local-state for promo code data

1 56 14

  1. Watch logs for to confirm that background updates are found
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit
  3. Launch Release with logs again as above
  4. Confirm Release is updated to version listed in logs with the fix (1.56.18)
  5. Confirm promo code data in brave://local-state:

1 56 18

  1. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  2. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwxr-xr-x   3 root    staff    96 Aug  1 10:10 BraveSoftware
  1. In terminal, enter sudo chown -R $USER ~/Library/Application\ Support/BraveSoftware
  2. Recheck permissions on BraveSoftware folder

Screen Shot 2023-08-01 at 10 17 09 AM

Case 3 - Re-run Case 1 but as non-Admin user - Partially PASSED

Note, since we only have one RC which contains this fix, unable to check updating on Release from one version with the fix to another version with the fix. This was checked prior to uplift on both Nightly and Beta though.

Covers:

  • Installing RC version with the fix via .pkg and beta and nightly versions with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on Beta/Nightly channels (from a version with the fix to a version with the fix for both channels) - unable to check Release as there's only one RC with the fix at the moment
  • checking permissions on BraveSoftware profile folder
  • promo code check for RC version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) universal .dmg (used GH to get this)
  4. Downloaded Beta (1.57.17) universal .dmg (used GH to get this)
  5. Installed RC from .pkg
  6. Installed Beta from .dmg
  7. Installed Nightly from .dmg
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 nonadmin  staff   96 Aug  1 10:56 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data
RC1
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues (enter password if prompted for keychain access)
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues (enter password if prompted for keychain access)
  5. Watch logs for all versions to confirm that background updates are found for both Beta and Nightly
  6. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  • Note, if you don't see this, close both and relaunch both from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update)
  1. Install update(s) and relaunch (following any prompts that appear), confirming updated to appropriate versions per logs
  2. Close and relaunch RC
  3. Confirm promo code data is retained in brave://local-state:
RC2

Case 4 - Spot check on-demand updates - Partially PASSED

Note, as mentioned above, since there's only one RC with this fix, unable to verify on-demand updates going from a version with the fix to a version with the fix.

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version without the fix to a version with the fix

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version
Example Example
1 2

Non-Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version (follow any prompts you receive)
Example Example Example
1 2 3 
Brave	1.56.20 Chromium: 115.0.5790.171 (Official Build) (x86_64) 
Revision	cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}
OS	macOS Version 12.6.8 (Build 21G725)

Case 1 - Install 1.56.x (RC with fix) using refcode tagged .pkg and update to another version with the fix using background updates - Remainder PASSED

Covers:

  • case of updating via background updates on an RC with the fix (1.56.18) to another version with the fix (1.56.20).
  • promo code check for RC version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed RC from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 lauren  staff    96 Aug  3 12:52 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:

1

  1. Watch logs to confirm that background updates are found for Release
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  3. Close and relaunch RC
  4. Confirm updated to version mentioned in logs (1.56.20)
  5. Confirm promo code data is retained in brave://local-state:

2

Case 3 - Re-run Case 1 but as non-Admin user - Remainder PASSED

Covers:

  • case of updating via background updates on an RC with the fix (1.56.18) to another version with the fix (1.56.20).
  • promo code check for RC version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed RC from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 nonadmin  staff   96 Aug  3 13:05 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:
1

  1. Watch logs to confirm that background updates are found for Release

  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version

  • Note, if you don't see this, close and relaunch from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update.
  1. Install update and relaunch (following any prompts that appear), confirming updated to appropriate versions per logs
  2. Confirm promo code data is retained in brave://local-state:
2

Case 4 - Spot check on-demand updates - Remainder PASSED

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version with the fix to a version with the fix

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release with logs /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version
Example Example
1 2

Non-Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release with logs /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version (follow any prompts you receive)
Example Example Example
1 2 3

@stephendonner
Copy link
Collaborator

stephendonner commented Aug 1, 2023 •
edited

Verified PASSED using

Brave | 1.56.18 Chromium: 115.0.5790.138 (Official Build) (x86_64)
-- | --
Revision | 0567db0e7dcdfee5c109c167119ac2a92b9b3e1a-refs/branch-heads/5790_85@{#9}
OS | macOS Version 11.7.9 (Build 20G1426)

First, reproduced the issue using STR from the description - PASSED

  1. removed previous installs and profiles as follows:
  • Deleted all Brave instances from Applications folder
  • Deleted BraveSoftware folder from ~/Library/Application Support
  • Deleted BraveSoftware folder from ~/Library/Caches
  • Deleted com.brave.* folders from ~/Library/Caches
  • Deleted com.brave.* files from ~/Library/Preferences
  • Restarted my machine
  1. Downloaded Release (1.56.14) .pkg file (can use GH or brave.com) - note, .pkg from brave.com is ref code tagged
  2. Downloaded Nightly (1.58.x) .dmg (can use GH or brave.com/download-nightly). Do the same for Beta (1.57.x)
  3. Installed Release from .pkg
  4. Installed Nightly and Beta from .dmg
  5. Release launches fine, no issues
  6. Nightly crashes on launch. Beta crashes on launch.
  7. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  8. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
drwxr-xr-x   4 root          staff  128 Aug  2 14:49 BraveSoftware

Case 1 - Install 1.56.x (RC) using refcode tagged .pkg and install 1.58.x (Nightly), 1.57.x (Beta) using .dmg - PASSED

Note, since we only have one RC which contains this fix, unable to check updating on Release from one version with the fix to another version with the fix. This was checked prior to uplift on both Nightly and Beta though.

Screen Shot 2023-08-02 at 6 25 32 PM

Covers:

  • Installing RC version with the fix via .pkg and nightly + beta versions with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on Beta/Nightly channels (from a version with the fix to a version with the fix for all channels) - unable to check Release as there's only one RC with the fix at the moment
  • checking permissions on BraveSoftware profile folder
  • promo code check for RC version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) universal .dmg (used GH to get this)
  4. Downloaded Beta (1.57.17) universal .dmg (used GH to get this)
  5. Installed RC from .pkg
  6. Installed Beta from .dmg
  7. Installed Nightly from .dmg
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwx------    4 stephendonner  staff    128 Aug  2 10:18 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:
Screen Shot 2023-08-02 at 10 27 04 AM
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Watch logs for all versions to confirm that background updates are found for both Beta and Nightly
  6. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  7. Launch Nightly with logs again as above
  8. Confirm Nightly is updated to version listed in logs, quit Nightly
  9. Launch Beta with logs again as above
  10. Confirm Beta is updated to version listed in logs.
  11. Close and relaunch RC
  12. Confirm promo code data is retained in brave://local-state:
Screen Shot 2023-08-02 at 10 30 32 AM

Case 2 - Install version on 1.56.x (Release) without this fix and then update to the latest (using background updates) - PASSED

Covers:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and noted that it mentions root:
drwxr-xr-x   4 root          staff  128 Aug  2 14:49 BraveSoftware
  1. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  2. Confirm Release launches fine, no issues
  3. Check brave://local-state for promo code data:
Screen Shot 2023-08-02 at 4 09 25 PM
  1. Watch logs to confirm that background updates are found
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit
  3. Launch Release with logs again as above
  4. Confirm Release is updated to version listed in logs with the fix (1.56.18)
  5. Confirm promo code data in brave://local-state:
Screen Shot 2023-08-02 at 11 51 04 AM
  1. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  2. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwxr-xr-x   4 root          staff  128 Aug  2 14:49 BraveSoftware
  1. In terminal, enter sudo chown -R $USER ~/Library/Application\ Support/BraveSoftware
  2. Recheck permissions on BraveSoftware folder
Screen Shot 2023-08-02 at 4 30 03 PM

Case 3 - Re-run Case 1 but as non-Admin user - PASSED

Note, since we only have one RC which contains this fix, unable to check updating on Release from one version with the fix to another version with the fix. This was checked prior to uplift on both Nightly and Beta though.

Screen Shot 2023-08-02 at 6 17 18 PM

Covers:

  • Installing RC version with the fix via .pkg and beta and nightly versions with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on Beta/Nightly channels (from a version with the fix to a version with the fix for both channels) - unable to check Release as there's only one RC with the fix at the moment
  • checking permissions on BraveSoftware profile folder
  • promo code check for RC version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) universal .dmg (used GH to get this)
  4. Downloaded Beta (1.57.17) universal .dmg (used GH to get this)
  5. Installed RC from .pkg
  6. Installed Beta from .dmg
  7. Installed Nightly from .dmg
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   5 standarduser  staff   160 Aug  2 18:13 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:
Screen Shot 2023-08-02 at 6 11 42 PM
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues (enter password if prompted for keychain access)
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues (enter password if prompted for keychain access)
  5. Watch logs for all versions to confirm that background updates are found for both Beta and Nightly
  6. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  • Note, if you don't see this, close both and relaunch both from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update)
  1. Install update(s) and relaunch (following any prompts that appear), confirming updated to appropriate versions per logs
  2. Close and relaunch RC
  3. Confirm promo code data is retained in brave://local-state:
Screen Shot 2023-08-02 at 6 11 57 PM

Case 4 - Spot check on-demand updates - PASSED

Note, as mentioned above, since there's only one RC with this fix, unable to verify on-demand updates going from a version with the fix to a version with the fix.

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version without the fix to a version with the fix

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version
Example Example
Screenshot 2023-08-03 at 2 44 40 AM Screenshot 2023-08-03 at 2 45 18 AM

Non-Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version (follow any prompts you receive)
Example Example Example Example
Screenshot 2023-08-03 at 9 54 03 AM Screenshot 2023-08-03 at 9 54 14 AM Screenshot 2023-08-03 at 9 54 26 AM Screenshot 2023-08-03 at 9 54 36 AM

@LaurenWags
Copy link
Member

LaurenWags commented Aug 1, 2023 •
edited

Verified with

Brave	1.56.18 Chromium: 115.0.5790.138 (Official Build) (arm64) 
Revision	0567db0e7dcdfee5c109c167119ac2a92b9b3e1a-refs/branch-heads/5790_85@{#9}
OS	macOS Version 13.5 (Build 22G74)

Reproduced the issue using STR from description.

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) .pkg file (can use GH or brave.com) - note, .pkg from brave.com is ref code tagged
  3. Downloaded Nightly (1.58.x) .dmg (can use GH or brave.com/download-nightly). Do the same for Beta (1.57.x)
  4. Installed Release from .pkg
  5. Installed Nightly and Beta from .dmg
  6. Release launches fine, no issues
  7. Nightly crashes on launch. Beta crashes on launch.
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
drwxr-xr-x   3 root        staff   96 Aug  1 13:26 BraveSoftware

Existing User Case - attempt to manually fix install currently experiencing this issue - PASSED

Note, per internal discussions, simply upgrading to latest version will not fix the issue it just prevents it from occurring in the future. However, following the below steps (installing latest from brave.com over your existing install) does fix the permissions issue.

  1. Run through STR to reproduce the issue using 1.56.14 (current release version).
  2. Install 1.56.18 (via .pkg) over existing 1.56.14 install.
  3. Confirm able to launch Beta and Nightly now.
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
drwxr-xr-x   5 laurenwags  staff  160 Aug  1 15:02 BraveSoftware

Case 1 - Install 1.56.x (RC) using refcode tagged .pkg and install 1.58.x (Nightly), 1.57.x (Beta) using .dmg - Partially PASSED

Note, since we only have one RC which contains this fix, unable to check updating on Release from one version with the fix to another version with the fix. This was checked prior to uplift on both Nightly and Beta though.

Covers:

  • Installing RC version with the fix via .pkg and nightly + beta versions with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on Beta/Nightly channels (from a version with the fix to a version with the fix for all channels) - unable to check Release as there's only one RC with the fix at the moment
  • checking permissions on BraveSoftware profile folder
  • promo code check for RC version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) universal .dmg (used GH to get this)
  4. Downloaded Beta (1.57.17) universal .dmg (used GH to get this)
  5. Installed RC from .pkg
  6. Installed Beta from .dmg
  7. Installed Nightly from .dmg
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 laurenwags  staff   96 Aug  1 15:07 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:

RC1

  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Watch logs for all versions to confirm that background updates are found for both Beta and Nightly
  6. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  7. Launch Nightly with logs again as above
  8. Confirm Nightly is updated to version listed in logs, quit Nightly
  9. Launch Beta with logs again as above
  10. Confirm Beta is updated to version listed in logs.
  11. Close and relaunch RC
  12. Confirm promo code data is retained in brave://local-state:

RC2

Case 2 - Install version on 1.56.x (Release) without this fix and then update to the latest (using background updates) - PASSED

Covers:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwxr-xr-x   3 root        staff   96 Aug  1 15:18 BraveSoftware
  1. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  2. Confirm Release launches fine, no issues
  3. Check brave://local-state for promo code data:

1

  1. Watch logs for to confirm that background updates are found
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit
  3. Launch Release with logs again as above
  4. Confirm Release is updated to version listed in logs with the fix (1.56.18)
  5. Confirm promo code data in brave://local-state:

2

  1. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  2. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwxr-xr-x   3 root        staff   96 Aug  1 15:18 BraveSoftware
  1. In terminal, enter sudo chown -R $USER ~/Library/Application\ Support/BraveSoftware
  2. Recheck permissions on BraveSoftware folder

3

Case 3 - Re-run Case 1 but as non-Admin user - Partially PASSED

Note, since we only have one RC which contains this fix, unable to check updating on Release from one version with the fix to another version with the fix. This was checked prior to uplift on both Nightly and Beta though.

Covers:

  • Installing RC version with the fix via .pkg and beta and nightly versions with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on Beta/Nightly channels (from a version with the fix to a version with the fix for both channels) - unable to check Release as there's only one RC with the fix at the moment
  • checking permissions on BraveSoftware profile folder
  • promo code check for RC version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) universal .dmg (used GH to get this)
  4. Downloaded Beta (1.57.17) universal .dmg (used GH to get this)
  5. Installed RC from .pkg
  6. Installed Beta from .dmg
  7. Installed Nightly from .dmg
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x  3 nonadmin  staff   96 Aug  1 16:21 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:
1
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues (enter password if prompted for keychain access)
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues (enter password if prompted for keychain access)
  5. Watch logs for all versions to confirm that background updates are found for both Beta and Nightly
  6. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  • Note, if you don't see this, close both and relaunch both from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update)
  1. Install update(s) and relaunch (following any prompts that appear), confirming updated to appropriate versions per logs
  2. Close and relaunch RC
  3. Confirm promo code data is retained in brave://local-state:
2

Case 4 - Spot check on-demand updates - Partially PASSED

Note, as mentioned above, since there's only one RC with this fix, unable to verify on-demand updates going from a version with the fix to a version with the fix.

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version without the fix to a version with the fix

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version
Example Example
1 2

Non-Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.14) universal .pkg file (used GH to get this, could also use brave.com) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version (follow any prompts you receive)
Example Example Example
1 2 3 
Brave	1.56.20 Chromium: 115.0.5790.171 (Official Build) (arm64) 
Revision	cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}
OS	macOS Version 13.5 (Build 22G74)

Case 1 - Install 1.56.x (RC with fix) using refcode tagged .pkg and update to another version with the fix using background updates - Remainder PASSED

Covers:

  • case of updating via background updates on an RC with the fix (1.56.18) to another version with the fix (1.56.20).
  • promo code check for RC version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed RC from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 laurenwags  staff   96 Aug  3 11:57 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:

1

  1. Watch logs to confirm that background updates are found for Release
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  3. Close and relaunch RC
  4. Confirm updated to version mentioned in logs (1.56.20)
  5. Confirm promo code data is retained in brave://local-state:

2

Case 3 - Re-run Case 1 but as non-Admin user - Remainder PASSED

Covers:

  • case of updating via background updates on an RC with the fix (1.56.18) to another version with the fix (1.56.20).
  • promo code check for RC version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded RC (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed RC from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwxr-xr-x   3 nonadmin  staff   96 Aug  3 12:19 BraveSoftware
  1. Launch RC with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml
  2. Confirm RC launches fine, no issues
  3. Check brave://local-state for promo code data:
1

  1. Watch logs to confirm that background updates are found for Release

  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version

  • Note, if you don't see this, close and relaunch from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update.
  1. Install update and relaunch (following any prompts that appear), confirming updated to appropriate versions per logs
  2. Confirm promo code data is retained in brave://local-state:
2

Case 4 - Spot check on-demand updates - Remainder PASSED

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version with the fix to a version with the fix

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release with logs /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version
Example Example
1 2

Non-Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Don't need to worry about other items this time or restarting the machine
  2. Downloaded Release (1.56.18) universal .pkg file (used GH to get this) and changed -universal to -BRV002 to simulate it being tagged for ref code
  3. Installed Release from .pkg
  4. Launch Release with logs: /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr
  5. Confirm Release launches fine, no issues
  6. Quickly close Release before background update is found
  7. Relaunch Release with logs /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test-arm64/appcast.xml and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to RC version (follow any prompts you receive)
Example Example Example
1 2 3

@rebron rebron moved this from Pending review/uplift or retest to Completed in General Aug 1, 2023
@LaurenWags LaurenWags mentioned this issue Aug 2, 2023
Closed
@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 2, 2023
@stephendonner
Copy link
Collaborator

stephendonner commented Aug 3, 2023 •
edited

Verification PASSED using

Brave | 1.56.20 Chromium: 115.0.5790.171 (Official Build) (arm64)
-- | --
Revision | cf9067bf10d8f798c24643029af1d24e275646d6-refs/branch-heads/5790@{#1924}
OS | macOS Version 13.5 (Build 22G74)

Unable to reproduce the original issue; instead of root, the username it uses to install is stephendonner. Continued and passed testing due to being able to reproduce it on macOS-x64 in #30546 (comment) (applied the same testing).

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Release (1.56.14) .pkg file (can use GH or brave.com) - note, .pkg from brave.com is ref code tagged
  3. Downloaded Nightly (1.58.x) .dmg (can use GH or brave.com/download-nightly)
  4. Installed Release from .pkg
  5. Installed Nightly from .dmg
  6. Release launches fine, no issues
  7. Nightly crashes on launch
  8. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  9. Check the permissions on BraveSoftware folder and see that they mention root as in the description:
drwx------  29 stephendonner  staff   928 Aug  3 13:03 Brave-Browser

Case 1 - Install 1.57.x (Beta) using refcode tagged .pkg and install 1.58.x (Nightly) using .dmg - PASSED

Covers:

  • Installing a beta version with the fix via .pkg and a nightly version with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on both channels (from a version with the fix to a version with the fix for both channels)
  • checking permissions on BraveSoftware profile folder
  • promo code check for Beta version installed via .pkg
  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) .dmg (used GH to get this)
  4. Installed Beta from .pkg
  5. Installed Nightly from .dmg
  6. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  7. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwx------   4 stephendonner  staff    128 Aug  2 21:29 BraveSoftware
  1. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  2. Confirm Beta launches fine, no issues
  3. Check brave://local-state for promo code data
Screenshot 2023-08-03 at 10 39 05 AM
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Watch logs for both versions to confirm that background updates are found for both Beta and Nightly
  4. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  5. Launch Nightly with logs again as above
  6. Confirm Nightly is updated to version listed in logs, quit Nightly
  7. Launch Beta with logs again as above
  8. Confirm Beta is updated to version listed in logs.
  9. Confirm promo code data in brave://local-state:
Screenshot 2023-08-03 at 10 39 54 AM

Case 2 - Install version on 1.57.x without this fix and then update to the latest - PASSED

Covers:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Nightly (1.54.3) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code (note, first version with this fix is 1.54.4 per https://github.com/brave/brave-core/commits/master?after=937a82201c8cba2f4709f7731b40561e8422e5cd+1469&branch=master&qualified_name=refs%2Fheads%2Fmaster)
  3. Installed Nightly from .pkg
  4. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  5. Check the permissions on BraveSoftware folder and note that it still mentions root as in the description:
drwx------   6 stephendonner  staff    192 Aug  3 11:34 BraveSoftware
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues
  3. Check brave://local-state for promo code data
Screenshot 2023-08-03 at 11 00 24 AM
  1. Watch logs for to confirm that background updates are found
  2. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit
  3. Launch Nightly with logs again as above
  4. Confirm Nightly is updated to version listed in logs.
  5. Confirm promo code data in brave://local-state:
Screenshot 2023-08-03 at 11 03 15 AM

Case 3 - Re-run Case 1 but as non-Admin user - PASSED

Covers:

  • Installing a beta version with the fix via .pkg and a nightly version with the fix via .dmg to confirm both can launch without crashing
  • Background upgrades on both channels (from a version with the fix to a version with the fix for both channels)
  • checking permissions on BraveSoftware profile folder
  • promo code check for Beta version installed via .pkg

pre-req: be logged in to machine as non-admin user

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Downloaded Nightly (1.58.42) .dmg (used GH to get this)
  4. Installed Beta from .pkg
  5. Installed Nightly from .dmg
  6. Open terminal, enter cd ~/Library/Application\ Support, press return. Enter ls -l and press return.
  7. Check the permissions on BraveSoftware folder and confirm that it does not mention root as in the description:
drwx------  4 standarduser  staff  128 Aug  3 12:46 BraveSoftware
  1. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  2. Confirm Beta launches fine, no issues (enter password for keychain access if prompted and select "Always Allow")
  3. Check brave://local-state for promo code data
Screenshot 2023-08-03 at 11 14 00 AM
  1. Launch Nightly with logs: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr
  2. Confirm Nightly launches fine, no issues (enter password for keychain access if prompted and select "Always Allow")
  3. Watch logs for both versions to confirm that background updates are found for both Beta and Nightly
  4. Once you see something like brave update: will install update on quit with AppcastItem... in logs, you can quit each version
  • Note, if you don't see this, close both and relaunch both from terminal, non-admin users can behave a little differently than admin users. On relaunch you may be prompted on your update preferences. Be sure to select the "Check automatically" option. You will likely then be alerted an update is available, follow prompts to install update)
  1. Install update(s) and relaunch
  2. Confirm promo code data in brave://local-state:
Screenshot 2023-08-03 at 11 15 26 AM

Case 4 - Spot check on-demand updates - PASSED

Covers:

  • on-demand updates for admin and non-admin users:
    • on-demand updates going from a version with the fix to a version with the fix
    • on-demand updates going from a version without the fix to a version with the fix

Release channel

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Installed Beta from .pkg
  4. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  5. Confirm Beta launches fine, no issues
  6. Quickly close Beta before background update is found
  7. Relaunch Beta and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Release is updated to latest
Example Example
Screenshot 2023-08-03 at 11 28 45 AM Screenshot 2023-08-03 at 11 28 55 AM

Non-Admin user:

Removed previous installs and profiles as follows:

  • Deleted all Brave instances from Applications folder
  • Deleted BraveSoftware folder from ~/Library/Application Support
  • Deleted BraveSoftware folder from ~/Library/Caches
  • Don't need to worry about other items this time or restarting the machine
  1. Downloaded a 1.53.99 Beta (this is 1.56.x code base) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  2. Installed Beta from .pkg
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Quickly close Beta before background update is found
  6. Relaunch Beta and navigate to brave://settings/help
  7. Confirm update is found
  8. Relaunch and confirm Release is updated to latest
Example Example Example
Screenshot 2023-08-03 at 12 27 28 PM Screenshot 2023-08-03 at 12 27 37 PM Screenshot 2023-08-03 at 12 28 01 PM

Beta channel

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Installed Beta from .pkg
  4. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  5. Confirm Beta launches fine, no issues
  6. Quickly close Beta before background update is found
  7. Relaunch Beta and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Beta is updated to latest
Example Example
Screenshot 2023-08-03 at 11 33 46 AM Screenshot 2023-08-03 at 11 33 55 AM

Non-Admin user:

Removed previous installs and profiles as follows:

  • Deleted all Brave instances from Applications folder
  • Deleted BraveSoftware folder from ~/Library/Application Support
  • Deleted BraveSoftware folder from ~/Library/Caches
  • Don't need to worry about other items this time or restarting the machine
  1. Downloaded a 1.53.99 Beta (this is 1.56.x code base) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  2. Installed Beta from .pkg
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Quickly close Beta before background update is found
  6. Relaunch Beta and navigate to brave://settings/help
  7. Confirm update is found
  8. Relaunch and confirm Beta is updated to latest
Example Example Example
Screenshot 2023-08-03 at 12 18 24 PM Screenshot 2023-08-03 at 12 18 34 PM Screenshot 2023-08-03 at 12 18 45 PM

Nightly channel

Admin user:

  1. Removed previous installs and profiles as follows:
    • Deleted all Brave instances from Applications folder
    • Deleted BraveSoftware folder from ~/Library/Application Support
    • Deleted BraveSoftware folder from ~/Library/Caches
    • Deleted com.brave.* folders from ~/Library/Caches
    • Deleted com.brave.* files from ~/Library/Preferences
    • Restarted my machine
  2. Downloaded Beta (1.57.17) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  3. Installed Beta from .pkg
  4. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  5. Confirm Beta launches fine, no issues
  6. Quickly close Beta before background update is found
  7. Relaunch Beta and navigate to brave://settings/help
  8. Confirm update is found
  9. Relaunch and confirm Nightly is updated to latest
Example Example
Screenshot 2023-08-03 at 11 36 28 AM Screenshot 2023-08-03 at 11 36 35 AM

Non-Admin user:

Removed previous installs and profiles as follows:

  • Deleted all Brave instances from Applications folder
  • Deleted BraveSoftware folder from ~/Library/Application Support
  • Deleted BraveSoftware folder from ~/Library/Caches
  • Don't need to worry about other items this time or restarting the machine
  1. Downloaded a 1.53.99 Beta (this is 1.56.x code base) universal .pkg file (used GH to get this) and added -BRV002 to simulate it being tagged for ref code
  2. Installed Beta from .pkg
  3. Launch Beta with logs: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Confirm Beta launches fine, no issues
  5. Quickly close Beta before background update is found
  6. Relaunch Beta and navigate to brave://settings/help
  7. Confirm update is found
  8. Relaunch and confirm Nightly is updated to latest
Example Example Example
Screenshot 2023-08-03 at 12 37 37 PM Screenshot 2023-08-03 at 12 37 45 PM Screenshot 2023-08-03 at 12 38 03 PM

@rebron rebron mentioned this issue Aug 3, 2023
Closed
@rebron rebron removed this from Completed in General Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
bug OS/Desktop OS/macOS QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include setup/installer
Projects
None yet
Milestone
1.56.x - Release #7
Development

Successfully merging a pull request may close this issue.

Fix permissions for BraveSoftware folder brave/brave-core
6 participants
@stephendonner @kjozwiak @spylogsster @rebron @LaurenWags @brave-builds