Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EIP-6963 #30595

Closed
bbondy opened this issue May 25, 2023 · 2 comments · Fixed by brave/brave-core#18751
Closed

Add support for EIP-6963 #30595

bbondy opened this issue May 25, 2023 · 2 comments · Fixed by brave/brave-core#18751
Assignees
@cypt4
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented May 25, 2023

Add support for EIP-6963 https://eips.ethereum.org/EIPS/eip-6963
You can test via:
https://eip6963.org/
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels May 25, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 26, 2023
@cypt4 cypt4 self-assigned this May 29, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Jun 5, 2023
@cypt4
Implement eip-6963
655cefa 
Resolves brave/brave-browser#30595
@cypt4 cypt4 mentioned this issue Jun 5, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Jun 5, 2023
@cypt4
Implement eip-6963
a792df9 
Resolves brave/brave-browser#30595
cypt4 added a commit to brave/brave-core that referenced this issue Jun 27, 2023
@cypt4
Implement eip-6963
9f38a26 
Resolves brave/brave-browser#30595
cypt4 added a commit to brave/brave-core that referenced this issue Jun 29, 2023
@cypt4
Implement eip-6963
bbb70d2 
Resolves brave/brave-browser#30595
cypt4 added a commit to brave/brave-core that referenced this issue Jun 30, 2023
@cypt4
Implement eip-6963
41dfb2b 
Resolves brave/brave-browser#30595
@StephenHeaps StephenHeaps mentioned this issue Jul 25, 2023
Closed
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Jul 27, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 27, 2023
@kdenhartog kdenhartog mentioned this issue Aug 21, 2023
Open
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.108 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision f08ffbe3ce0069ad8207b9d2d7dee38afcccc1b9
OS Windows 11 Version 22H2 (Build 22621.2215)
Brave Wallet Extensions (Brave Wallet fallback) Extensions (no fallback)
Brave.Wallet.mp4
Extensions.Brave.Wallet.fallback.mp4
Extensions.no.fallback.mp4

@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified steps from brave/brave-core#18751
  • Verified Brave Wallet is detected with or without Brave wallet being created
30595.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Implement eip-6963 brave/brave-core
5 participants
@jamesmudgett @bbondy @srirambv @brave-builds @cypt4