-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Manage Brave Ads #30637
Comments
An excellent update, adding transparency, more intuitive UX and finer grained controls over each ad unit. Big win from the team; looking forward to testing in Nightly. |
Per discussion with @btlechowski @GeetaSarvadnya marking this one as The plan for testing is as follows:
|
Verification PASSED on
Clean profile_Toggle the switches_PASSEDCase 1: Both the switches ON_PASSED
Case 2: Both the switches OFF_PASSEDCase 3: When `Notification ads` switch is disabled_PASSEDCase 4: When `New tab page ads` switch is disabled_PASSEDUpgrade profile_Toggle the switches_PASSEDCase 1: View an Inline content ad and upgrade the profile to 1.58.x_PASSED
Case 2: Grandfathered unverified state upgrade_PASSED
New profile test case_PASSED
step 3 - New tab page ads switch ON: step 3 - New tab page ads switch OFF: step 4 - customize dashboard NTP SI swictch ON/OFF Upgrade profile case (view counts and ad settings)_PASSEDNote: Main things to worry about are turning on ads for someone who had them off in previous version.
Additional Testing on step 9
Reset Rewards case_PASSED
New profile in no custodian region_PASSED
|
Verified with
Clean profile_Toggle the switches - 3 PASSED, 1 FAILEDCase 1: Both the switches ON - PASSED
![]() Case 2: Both the switches OFF - PASSED
Case 3: When `Notification ads` switch is disabled - FAILED
Logged #32581 as follow up, NTP SI ads not served when notification ads are off. Case 4: When `New tab page ads` switch is disabled - PASSED
Upgrade profile_Toggle the switches - 3 PASSEDCase 1: View an Inline content ad and upgrade the profile to 1.58.x - PASSED
Case 2: Grandfathered unverified state upgrade (notification ads off prior to upgrade) - PASSED
Case 3: Grandfathered unverified state upgrade (NTP ads off prior to upgrade) - PASSED
Below cases were provided by Chris via Gdoc: New profile test case - PASSED
![]()
![]()
Before connecting custodian vs After (and viewing at least one of each ad type to confirm ad counters increment as expected)
Upgrade profile case (view counts and ad settings) - FAILED, follow up issue loggedNote: Main things to worry about are turning on ads for someone who had them off in previous version.
Reset Rewards case - PASSED
New profile in no custodian region - PASSED
|
Description
Tasks
https://www.figma.com/file/A77Iv5PtEygWFwI0cfV6f1/Estimated-earnings-counter?type=design&node-id=1001%3A36023&t=f1Rw5JB22QIwiqNC-1
The text was updated successfully, but these errors were encountered: