Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement Manage Brave Ads #30638

Closed
Miyayes opened this issue May 27, 2023 · 5 comments · Fixed by brave/brave-core#19382
Closed

[Android] Implement Manage Brave Ads #30638

Miyayes opened this issue May 27, 2023 · 5 comments · Fixed by brave/brave-core#19382
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/ads feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 27, 2023

Android version of: #30637

@Miyayes Miyayes added this to New Issues in Brave Rewards via automation May 27, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 31, 2023
@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards May 31, 2023
@Miyayes Miyayes added blocked and removed blocked labels Jun 6, 2023
@Miyayes Miyayes moved this from Backlog to In progress in Brave Rewards Jul 22, 2023
Brave Rewards automation moved this from In progress to Done Jul 25, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 25, 2023
@LaurenWags
Copy link
Member

Per discussion with @btlechowski @GeetaSarvadnya marking this one as QA/Test-All-Platforms and QA/Test-All-Device-Types:

The plan for testing is as follows:

@kjozwiak kjozwiak added Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected and removed QA/Test-All-Device-Types labels Aug 23, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 6, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.58.117

Below cases were provided by Chris via Gdoc:

Note:

  1. I have updated the steps as Android doesn't have NTP Customize dashboard settings
  2. Users rewarded for viewing notification ads/inline content ads/new tab page ads are NOT shown on the UI and there is no DB to verify, hence deposited BAT for viewing ads is verified via logs
  3. Scroll through the brave news feeds will not count the inline content view event, min wait time on inline content ad is 100ms
Clean profile_Toggle the switches - PASSED
Case 1: Both the switches ON - PASSED
  • When rewards is enabled, both the switches New tab page ads and Notification ads switches are enabled by default
  • Confirmed that both New tab page ads and Notification ads are served to the user when both the switches are ON
Example Example
Screenshot_20230911-104653_Brave Screenshot_20230911-105007_Brave
Case 2: Both the switches OFF - PASSED
  • Disable both the switches New tab page ads and Notification ads via the brave://rewards
  • Confirmed that New tab page ads and Notification ads are NOT served to user when both the switches are OFF (opened several new tabs, no NTP SI observed. Navigated around for a bit, no notification ads observed)
  • Confirmed toggling New tab page ads OFF via brave://rewards also toggled off Show Sponsored Images under "Customize Dashboard" on the NTP
Example Example
Screenshot_20230911-105631_Brave Screenshot_20230911-112443_Brave
Case 3: When `Notification ads` switch is disabled - PASSED
  • Confirmed that Default notification ads are NOT served to the user - PASSED
  • Confirmed that new tab page ads are served to the user - PASSED

Screenshot_20230911-113217_Brave

Case 4: When `New tab page ads` switch is disabled - PASSED
  • Confirmed that default ad notification are served when the Notification ads switch is enabled
  • Confirmed that New tab page ads are NOT served to the user
  • Confirmed toggling New tab page ads OFF via brave://rewards also toggled off Show Sponsored Images under "Customize Dashboard" on the NTP

Screenshot_20230911-111828_Brave

Upgrade profile_Toggle the switches - 3 PASSED
Case 1: View an Inline content ad and upgrade the profile to 1.58.x - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards
  3. View a default notification (also viewed an NTP SI ad)
  4. Enable Brave news via NTP
  5. View a Inline content Ad
  6. Upgrade the profile to 1.58.x
  7. Confirmed that Inline content ads switch is enabled and counter next to inline content ads switch shows the correct number
  8. Confirmed NTP and notification ad switches are on and count displays as expected
  9. Open the ads history and confirmed that the ads history is shown correctly in an upgraded profile
1.57.x 1.58.x
Screenshot_20230908-173158_Brave - Beta Screenshot_20230908-173339_Brave - Beta
Case 2: Grandfathered unverified state upgrade (notification ads off prior to upgrade) - Logged #32894
  1. Clean profile, enable rewards and be in grandfathered unverified state
  2. Change ads per hours settings to Up to 4 ads per hour
  3. Disable both Brave Private Ads and Auto-Contribute switches
  4. Upgrade the profile to 1.58.x
  5. Confirmed that Notification ads as the brave private ads switch is OFF
  6. Confirmed that the ads per hours settings Max 4 per hour is retained in an upgraded profile
  7. Confirmed Auto Contribution is still off
  8. Enable notification ads and view a Ad
  9. Confirmed that notification ads counter is shown correctly
  10. Enable Brave News via NTP and view brave news ads
  11. Confirmed that brave news ads counter is shown correctly
1.57.x 1.57.x
1.58.x 1.58.x 1.58.x
Case 3: Grandfathered unverified state upgrade (NTP ads off prior to upgrade) - PASSED
  1. Clean profile, enable rewards and be in grandfathered unverified state
  2. Change ads per hours settings to Up to 5 ads per hour
  3. View a notification ad
  4. Disable Auto-Contribute switch on brave://rewards
  5. Open NTP and open "Customize Dashboard"
  6. Disable "Show Sponsored Images" under the "Background Image" section, confirm no NTP SI images are shown to user
  7. Upgrade the profile to 1.58.x
  8. Confirmed that Notification ads switch is on
  9. Confirmed that the ads per hours settings Max 5 per hour is retained in an upgraded profile
  10. Confirmed that "New tab page ads" switch is off on brave://rewards
  11. Confirmed Auto Contribution is still off
  12. Confirmed that "Show Sponsored Images" under "Background Image" of "Customize Dashboard" is still off
  13. Enabled "Show Sponsored Images" and viewed an NTP ad
  14. Confirmed that NTP ads counter is shown correctly
  15. View another notification ad
  16. Confirmed that notification ads counter is shown correctly
1.57.x 1.57.x 1.57.x 1.57.x
Screenshot_20230911-102727_Brave Screenshot_20230911-102822_Brave Screenshot_20230911-102838_Brave Screenshot_20230911-102912_Brave
1.58.x 1.58.x 1.58.x 1.58.x
Screenshot_20230911-102918_Brave Screenshot_20230911-102931_Brave Screenshot_20230911-102955_Brave Screenshot_20230911-103055_Brave

New profile test case - PASSED
  1. Clean profile 1.58.x
  2. Enable rewards
  3. Confirmed that the Manage Brave Ads section is shown in the brave://rewards page
  4. Confirmed that New tab page ads and Notification ads switches are enabled by default
  5. Confirmed that Max 10 ads per hour option is selected by default
  6. Confirmed that tooltip next to Brave News ads says that Brave News is disabled and digit on the right is grayed out
  7. Confirmed that Brave News ads tooltip says that Brave News Ads cannot be independently disabled and confirmed that the digit is no longer grayed out when brave news is enabled and the counter is working.
  8. Confirmed that New tab page ads and Notification ads are served to the users when the swicthes are enabled
  9. Confirmed that brave news inline content ads are served to the user when Brave news is enabled
  10. Confirmed that users are rewarded for viewing brave news inline content ads, New tab page ads and Notification ads
  11. Confirmed that counter on each ad types is shown correctly after viewing ads
  12. Verified the toggle ON/OFF new tab page ads and confirmed that this works by checking the New Tab Page for New Tab Page ads, and that the ads viewed counter is working for this ad unit
  13. Go into “Settings->New tab page->Show Sponsored Images” via 3 dot menu, and toggle ON/OFF sponsored images settings and then look in brave://rewards Manage Brave Ads and onfirmed the new tab page ads toggle updates its state accordingly.
  14. Toggle ON/OFF new tab page ads via brave://rewards Manage Brave Ads, and confirmed that the toggle in “Settings->New tab page->Show Sponsored Images” updates its state accordingly.
  15. Exception case: Make sure New Tab Page ads are ON inside Customize Dashboard. Then, turn off background images completely.
    a. New Tab Page ads should still be on in Manage Brave Ads
    b. Turn off New Tab Page ads in Manage Brave Ads
    c. Enable background images in Customize Dashboard
    d. Check that the New Tab Page ads/sponsored images toggle in Customize Dashboard is OFF (matches Manage Brave Ads state)
    e. Then toggle New Tab Page ads on in Customize Dashboard, and check if state updates and matches in Manage Brave Ads
  16. Connect a custodian, and then check that the blue notice telling users to connect to a custodian (“Ready to start earning?”) no longer appears, and that things still appear to be working properly.
Example Example Example Example Example Example Example
Screenshot_20230907-201142_Brave - Beta Screenshot_20230907-201357_Brave - Beta Screenshot_20230907-203630_Brave - Beta Screenshot_20230907-210100_Brave - Beta Screenshot_20230907-210148_Brave - Beta Screenshot_20230907-210253_Brave - Beta Screenshot_20230907-210504_Brave - Beta

Step 14

Example Example
Screenshot_20230908-170019_Brave - Beta Screenshot_20230908-170033_Brave - Beta

Step 15

Example Example
Screenshot_20230908-170033_Brave - Beta Screenshot_20230908-170019_Brave - Beta

Step 16

Example Example Example Example Example Example
Screenshot_20230908-170539_Brave - Beta Screenshot_20230908-170613_Brave - Beta Screenshot_20230908-170620_Brave - Beta Screenshot_20230908-170650_Brave - Beta Screenshot_20230908-170726_Brave - Beta Screenshot_20230908-170730_Brave - Beta

Step 17

Example Example
Screenshot_20230908-172049_Brave - Beta Screenshot_20230908-171953_Brave - Beta

Notification ads logs

2023-09-07 20:36:19.098 8387-8387/? V/chromium: [VERBOSE1:notification_ad_handler.cc(185)] Served notification ad:
      placementId: 0a8274c3-e269-418e-9a8b-50d6c4e03886
      creativeInstanceId: 98bd3e17-2733-4365-89d3-7baae4bb571b
      creativeSetId: 0c5dbff2-ae64-4997-97ab-eae435fee259
      campaignId: 770bd7ed-0ba8-48d8-8dfb-5f86f6d3e005
      advertiserId: 86025555-2064-4671-b1b6-765c64cf023c
      segment: untargeted
      title: Download Brave on your desktop
      body: Watch YouTube videos ad-free on your desktop!
      targetUrl: https://brave.com/?ref=YMS691/
2023-09-07 20:36:19.143 8387-8387/? V/chromium: [VERBOSE1:notification_ad_serving.cc(161)] Maybe serve notification ad in 0 hours, 6 minutes, 0 seconds at 20:42:19.111
2023-09-07 20:36:19.148 8387-8387/? V/chromium: [VERBOSE3:notification_ad_handler.cc(196)] Served notification ad with placement id 0a8274c3-e269-418e-9a8b-50d6c4e03886 and creative instance id 98bd3e17-2733-4365-89d3-7baae4bb571b
2023-09-07 20:36:19.152 8387-8387/? V/chromium: [VERBOSE3:notification_ad_handler.cc(205)] Viewed notification ad with placement id 0a8274c3-e269-418e-9a8b-50d6c4e03886 and creative instance id 98bd3e17-2733-4365-89d3-7baae4bb571b
2023-09-07 20:36:19.158 8387-8387/? V/chromium: [VERBOSE3:account.cc(242)] Successfully processed deposit for ad_notification with creative instance id 98bd3e17-2733-4365-89d3-7baae4bb571b and view valued at 0.01

New tab page ads logs

2023-09-07 20:27:27.458 32615-32615/? V/chromium: [VERBOSE1:new_tab_page_ad_handler.cc(166)] Served new tab page ad:
      placementId: 6fb2bdfc-5ef2-4674-bc34-14742df54eef
      creativeInstanceId: 1c531704-1887-448d-b603-f2e8ba3bce52
      creativeSetId: b0096651-d3ce-4de0-968a-725c65cdbfc7
      campaignId: 9c25e7a1-1a8e-4821-94c1-ef4c11f58618
      advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
      segment: untargeted
      companyName: Brave VPN
      imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/183f3cfe-9479-4c5e-9ea5-68582510844c.png
      alt: Brave VPN - Cover all your devices with 1 VPN, across Android iOS & desktop. Right from the browser - Get Brave VPN
      targetUrl: https://brave.com/firewall-vpn/?mtm_source=brave-browser&mtm_medium=brave-ntp&mtm_campaign=brave-vpn&mtm_content=%%CREATIVE_INSTANCE%%&mtm_date=20230907
      wallpaper:
        imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/46299a16-c025-4383-b8db-8189efa697ff.jpg
        focalPoint:
          x: 1119
          y: 720
2023-09-07 20:27:27.465 32615-32615/? V/chromium: [VERBOSE3:new_tab_page_ad_handler.cc(173)] Served new tab page ad with placement id 6fb2bdfc-5ef2-4674-bc34-14742df54eef and creative instance id 1c531704-1887-448d-b603-f2e8ba3bce52
2023-09-07 20:27:27.489 10266-11479/? W/chromium: [WARNING:ev_root_ca_metadata.cc(118)] Not implemented
2023-09-07 20:27:27.721 32615-32615/? V/chromium: [VERBOSE3:account.cc(242)] Successfully processed deposit for new_tab_page_ad with creative instance id 1c531704-1887-448d-b603-f2e8ba3bce52 and view valued at 0.005

Inline content ads logs

2023-09-07 21:16:19.375 18397-18397/? V/chromium: [VERBOSE1:inline_content_ad_handler.cc(130)] Served inline content ad:
      placementId: 5256b084-2096-4c92-8ce0-ef5a983dae38
      creativeInstanceId: 877231dc-1675-43bb-9757-f3369b0ddcd8
      creativeSetId: df061ee5-c016-4ad8-b6d7-98b2218e6e92
      campaignId: 10ee7a4b-cfb5-4501-b6d4-59f7d8ca23db
      advertiserId: 6a231afd-670a-49dc-915f-8dad52266dcb
      segment: untargeted
      title: Explore multichain Web3. Select Wallet from the browser settings menu to get started!
      description: Brave
      imageUrl: https://pcdn.brave.com/brave-news-ads/8af2a80b-d368-4ff7-8bfe-8ea24a37edeb.jpg.pad
      dimensions: 900x750
      ctaText: Learn More
      targetUrl: https://brave.com/wallet/?brave-creative-id=877231dc-1675-43bb-9757-f3369b0ddcd8&source=news
2023-09-07 21:16:19.379 18397-18397/? V/chromium: [VERBOSE3:inline_content_ad_handler.cc(137)] Served inline content ad with placement id 5256b084-2096-4c92-8ce0-ef5a983dae38 and creative instance id 877231dc-1675-43bb-9757-f3369b0ddcd8
2023-09-07 21:16:22.349 18397-18397/? V/chromium: [VERBOSE3:account.cc(242)] Successfully processed deposit for inline_content_ad with creative instance id 877231dc-1675-43bb-9757-f3369b0ddcd8 and view valued at 0.025
Upgrade profile case (view counts and ad settings) - PASSED

Note: Main things to worry about are turning on ads for someone who had them off in previous version.

  1. Create profile prior to existence of Manage Brave Ads (where it still has Brave Private Ads section).
  2. Enable Rewards, and see some New Tab Page ads and some push notification ads.
  3. Disable New Tab Page ads via Settings->New tab page
  4. Set max ads frequency to 0 in Brave Private Ads (this corresponds to push notification ads)
  5. Upgrade to version with Manage Brave Ads and make sure Manage Brave Ads is there.
  6. Check that Notification Ads are toggled OFF in Manage Brave Ads, given that ads frequency was set to 0 in step 3. (There is no more “ads frequency = 0 / none” option in the notification ads dropdown) ---> FAILED, logged follow up issue Notification ads incorrectly enabled on upgrade when None/zero ads per hour set on previous version - Follow up to 30637 #32651.
  7. Check that New Tab Page ads are OFF, given that they were turned off in step 2.
  8. Check that breakdown of ad views per ad unit in Manage Brave Ads makes sense with how many ads you saw in step 2.
**1.57.x ** 1.57.x 1.57.x
Screenshot_20230908-140933_Brave - Beta Screenshot_20230908-141226_Brave - Beta Screenshot_20230908-141237_Brave - Beta
1.58.x 1.58.x
Screenshot_20230908-141331_Brave - Beta Screenshot_20230908-141507_Brave - Beta
  1. Re-enable New Tab Page ads and notification ads via toggles in Manage Brave Ads, and make sure that everything works, and that the New Tab Page ads toggle in Manage Brave Ads corresponds with the toggle in Customize Dashboard.
  • Confirmed that new tab page ads are served in an upgraded profile after enabling the new tab page ads switch via Manage Brave Ads page
  • Confirmed that notification ads are served in an upgraded profile after changing "None" to a different value in the list:
2023-09-08 14:18:29.780 9485-9485/? V/chromium: [VERBOSE1:notification_ad_serving.cc(136)] Maximum notification ads per hour changed to 10
1.58.x 1.58.x 1.58.x
Screenshot_20230908-141531_Brave - Beta Screenshot_20230908-141540_Brave - Beta Screenshot_20230908-141559_Brave - Beta
Reset Rewards case - PASSED
  1. Create new profile and go to brave://rewards > Manage Brave Ads
  2. Toggle off New tab page ads and Notification ads in Manage Brave Ads
  3. Reset Rewards profile
  4. Ensure that the new Rewards profile has New tab page ads OFF, and notification ads ON
Example Example Example Example
Screenshot_20230908-164540_Brave - Beta Screenshot_20230908-164549_Brave - Beta Screenshot_20230908-164605_Brave - Beta Screenshot_20230908-164610_Brave - Beta
New profile in no custodian region - PASSED
  1. Create new profile and set Rewards region to somewhere with no custodial support (like Antarctica)
  2. Go to brave://rewards for Manage Brave Ads and make sure that it shows the “There is no available custodian in your region” notice in the Manage Brave Ads section.
Example Example
Screenshot_20230908-165142_Brave - Beta Screenshot_20230908-165154_Brave - Beta

Additional cases

Install 1.57.x and view notification ad, NTP ad and inline content ad and then upgrade to 1.58.x_PASSED
  1. Clean profile 1.57.x
  2. Enable rewards
  3. View notification ad, NTP ad and inline content ads (I have viewed 6 - inline content ads, 1-notification ad, 1- NTP ad)
  4. Upgrade the profile to 1.58.x
  5. Confirm that counter for each ad type is shown correctly (1-notification ad, 1- NTP ad, 3 - Inline content ad)
  6. View few more inline content ads, notfication ad and NTP ad in an upgraded profile 1.58.x
  7. Confirmed that counter for each ad type is increased correctly
1.57.x 1.58.x - step 5 1.58.x - step 7
Screenshot_20230908-124144_Brave - Beta Screenshot_20230908-130649_Brave - Beta Screenshot_20230908-135402_Brave - Beta

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 13, 2023

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.58.121

New profile test case - PASSED
  1. Clean profile 1.58.x
  2. Enable rewards
  3. Confirmed that the Manage Brave Ads section is shown in the brave://rewards page
  4. Confirmed that New tab page ads and Notification ads switches are enabled by default
  5. Confirmed that Max 10 ads per hour option is selected by default
  6. Confirmed that tooltip next to Brave News ads says that Brave News is disabled and digit on the right is grayed out
  7. Confirmed that Brave News ads tooltip says that Brave News Ads cannot be independently disabled and confirmed that the digit is no longer grayed out when brave news is enabled and the counter is working.
  8. Confirmed that New tab page ads and Notification ads are served to the users when the swicthes are enabled
  9. Confirmed that brave news inline content ads are served to the user when Brave news is enabled
  10. Confirmed that users are rewarded for viewing brave news inline content ads, New tab page ads and Notification ads
  11. Confirmed that counter on each ad types is shown correctly after viewing ads
  12. Verified the toggle ON/OFF new tab page ads and confirmed that this works by checking the New Tab Page for New Tab Page ads, and that the ads viewed counter is working for this ad unit
  13. Go into “Settings->New tab page->Show Sponsored Images” via 3 dot menu, and toggle ON/OFF sponsored images settings and then look in brave://rewards Manage Brave Ads and onfirmed the new tab page ads toggle updates its state accordingly.
  14. Toggle ON/OFF new tab page ads via brave://rewards Manage Brave Ads, and confirmed that the toggle in “Settings->New tab page->Show Sponsored Images” updates its state accordingly.
  15. Exception case: Make sure New Tab Page ads are ON inside Customize Dashboard. Then, turn off background images completely.
    a. New Tab Page ads should still be on in Manage Brave Ads
    b. Turn off New Tab Page ads in Manage Brave Ads
    c. Enable background images in Customize Dashboard
    d. Check that the New Tab Page ads/sponsored images toggle in Customize Dashboard is OFF (matches Manage Brave Ads state)
    e. Then toggle New Tab Page ads on in Customize Dashboard, and check if state updates and matches in Manage Brave Ads
  16. Connect a custodian, and then check that the blue notice telling users to connect to a custodian (“Ready to start earning?”) no longer appears, and that things still appear to be working properly.

Steps 1-11

Example Example Example Example Example Example
Screenshot_20230913-181907_Brave Screenshot_20230913-181914_Brave Screenshot_20230913-181939_Brave Screenshot_20230913-182714_Brave Screenshot_20230914-101938_Brave Screenshot_20230914-110316_Brave

Steps 12 - 14

Example Example
Screenshot_20230914-104207_Brave Screenshot_20230914-104219_Brave
Screenshot_20230914-104912_Brave Screenshot_20230914-104917_Brave

Step 15 - 16

Example Example Example Example Example Example Example Example
Screenshot_20230914-111344_Brave Screenshot_20230914-111402_Brave Screenshot_20230914-111433_Brave Screenshot_20230914-111444_Brave Screenshot_20230914-111514_Brave Screenshot_20230914-111535_Brave Screenshot_20230914-111541_Brave Screenshot_20230914-112143_Brave

Notification ads logs

2023-09-14 09:50:33.138 4953-4953/? V/chromium: [VERBOSE1:notification_ad_handler.cc(185)] Served notification ad:
      placementId: 52082815-248b-4bc1-aa8a-9924877be9dc
      creativeInstanceId: 6e38e175-8641-44ca-9df1-8091e94fdb3c
      creativeSetId: 8e3d382f-f2e8-4fbc-836b-8a1f80b5de4b
      campaignId: 4ad70d08-af13-4e8f-ac09-8b635c0668b5
      advertiserId: 8fc94bb9-2ab3-49df-a5a7-8ee680384dec
      segment: untargeted
      title: Brave Wallet - Hold your own
      body: Self-custody ETH, EVM, SOL & Filecoin with Brave Wallet
      targetUrl: https://brave.com/wallet/?mtm_source=brave-browser&mtm_medium=brave-push&mtm_campaign=brave-wallet&mtm_content=6e38e175-8641-44ca-9df1-8091e94fdb3c
2023-09-14 09:50:33.339 4953-4953/? V/chromium: [VERBOSE1:notification_ad_serving.cc(151)] Maybe serve notification ad in 0 hours, 6 minutes, 0 seconds at 09:56:33.217
2023-09-14 09:50:33.357 4953-4953/? V/chromium: [VERBOSE3:notification_ad_handler.cc(196)] Served notification ad with placement id 52082815-248b-4bc1-aa8a-9924877be9dc and creative instance id 6e38e175-8641-44ca-9df1-8091e94fdb3c
2023-09-14 09:50:33.368 4953-4953/? V/chromium: [VERBOSE3:notification_ad_handler.cc(205)] Viewed notification ad with placement id 52082815-248b-4bc1-aa8a-9924877be9dc and creative instance id 6e38e175-8641-44ca-9df1-8091e94fdb3c
2023-09-14 09:50:33.389 4953-4953/? V/chromium: [VERBOSE3:account.cc(242)] Successfully processed deposit for ad_notification with creative instance id 6e38e175-8641-44ca-9df1-8091e94fdb3c and view valued at 0.01

New tab page ads logs

2023-09-14 09:48:57.652 4953-4953/? V/chromium: [VERBOSE1:new_tab_page_ad_handler.cc(166)] Served new tab page ad:
      placementId: f93bf287-921a-4fb5-af48-71a5443fce04
      creativeInstanceId: 30b83854-b4a5-43d2-a541-ba590d237f28
      creativeSetId: 3490d51b-a46f-4fef-aa8c-55196d557737
      campaignId: 47299322-4c41-40d3-a9c6-02245a1405d5
      advertiserId: 2318807a-a4bb-4b81-bbc8-abd71af01800
      segment: untargeted
      companyName: ev.io
      imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/001adb5a-7626-4e5a-aac6-2eac890bb32a.png
      alt: ev.io - Fast-Paced, Action Packed Ability Shooter. 
      targetUrl: https://ev.io/brave
      wallpaper:
        imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/477cfd39-46c1-4ccc-ba6b-83311aa11c30.jpg
        focalPoint:
          x: 1280
          y: 720
2023-09-14 09:48:57.659 4953-4953/? V/chromium: [VERBOSE3:new_tab_page_ad_handler.cc(173)] Served new tab page ad with placement id f93bf287-921a-4fb5-af48-71a5443fce04 and creative instance id 30b83854-b4a5-43d2-a541-ba590d237f28
2023-09-14 09:49:03.114 4953-4953/? V/chromium: [VERBOSE3:account.cc(242)] Successfully processed deposit for new_tab_page_ad with creative instance id 30b83854-b4a5-43d2-a541-ba590d237f28 and view valued at 0.001

Inline content ads logs

2023-09-14 10:07:11.146 4953-4953/? V/chromium: [VERBOSE1:inline_content_ad_handler.cc(130)] Served inline content ad:
      placementId: 7ca2b887-5526-43e8-87eb-972c6e644362
      creativeInstanceId: 98c122b3-cd85-40a6-aaa0-88f1d125a61a
      creativeSetId: c1e0324a-e898-43e3-a5ff-88837d495533
      campaignId: a41049b8-2d51-4a11-8987-850f6d21d417
      advertiserId: 4f8e8f8a-a577-4276-bfea-c2601ca4a4bf
      segment: untargeted
      title: Discover the current rate of attack, and the most common root causes of attacks.
      description: Sophos
      imageUrl: https://pcdn.brave.com/brave-news-ads/4adfa9a6-fd7b-4e74-b508-68af3b3ed2b8.jpg.pad
      dimensions: 900x750
      ctaText: Get The Report!
      targetUrl: https://www.sophos.com/en-us/content/state-of-ransomware?cmp=155748&utm_source=Brave&utm_campaign=India|Brave|Ransomware|BraveNews|RansomwareReport2023&utm_medium=cpc&utm_content=SM120407
2023-09-14 10:07:11.156 4953-4953/? V/chromium: [VERBOSE3:inline_content_ad_handler.cc(137)] Served inline content ad with placement id 48ccb2ca-97c0-47b4-baaf-76fc984b3ad1 and creative instance id 3dcfe076-8ae4-40d8-98dc-c9234546ff08
2023-09-14 10:07:18.329 4953-4953/? V/chromium: [VERBOSE3:account.cc(242)] Successfully processed deposit for inline_content_ad with creative instance id 98c122b3-cd85-40a6-aaa0-88f1d125a61a and view valued at 0.05
Upgrade profile case (view counts and ad settings) - PASSED
  1. Create profile prior to existence of Manage Brave Ads (where it still has Brave Private Ads section).
  2. Enable Rewards, and see some New Tab Page ads and some push notification ads.
  3. Disable New Tab Page ads via Settings->New tab page
  4. Set max ads frequency to 0 in Brave Private Ads (this corresponds to push notification ads)
  5. Upgrade to version with Manage Brave Ads and make sure Manage Brave Ads is there.
  6. Check that Notification Ads are toggled OFF in Manage Brave Ads, given that ads frequency was set to 0 in step 3. (There is no more “ads frequency = 0 / none” option in the notification ads dropdown) ---> FAILED, logged follow up issue Notification ads incorrectly enabled on upgrade when None/zero ads per hour set on previous version - Follow up to 30637 #32651.
  7. Check that New Tab Page ads are OFF, given that they were turned off in step 2.
  8. Check that breakdown of ad views per ad unit in Manage Brave Ads makes sense with how many ads you saw in step 2.
**1.57.x ** 1.57.x 1.57.x
Screenshot_20230914-121427_Brave Screenshot_20230914-121656_Brave Screenshot_20230914-121736_Brave
1.58.x 1.58.x
Screenshot_20230914-121929_Brave Screenshot_20230914-122115_Brave
  1. Re-enable New Tab Page ads and notification ads via toggles in Manage Brave Ads, and make sure that everything works, and that the New Tab Page ads toggle in Manage Brave Ads corresponds with the toggle in Customize Dashboard.
  • Confirmed that new tab page ads are served in an upgraded profile after enabling the new tab page ads switch via Manage Brave Ads page
  • Confirmed that notification ads are served in an upgraded profile after changing "None" to a different value in the list:
2023-09-14 12:49:23.898 12627-12627/? V/chromium: [VERBOSE1:notification_ad_serving.cc(136)] Maximum notification ads per hour changed to 5
1.58.x 1.58.x
Screenshot_20230914-124940_Brave Screenshot_20230914-125054_Brave
Reset Rewards case - PASSED
  1. Create new profile and go to brave://rewards > Manage Brave Ads
  2. Toggle off New tab page ads and Notification ads in Manage Brave Ads
  3. Reset Rewards profile
  4. Ensure that the new Rewards profile has New tab page ads OFF, and notification ads ON
Example Example Example
Screenshot_20230914-125304_Brave Screenshot_20230914-125312_Brave Screenshot_20230914-125324_Brave
New profile in no custodian region - PASSED
  1. Create new profile and set Rewards region to somewhere with no custodial support (like Antarctica)
  2. Go to brave://rewards for Manage Brave Ads and make sure that it shows the “There is no available custodian in your region” notice in the Manage Brave Ads section.
Example Example
Screenshot_20230914-125702_Brave Screenshot_20230914-125717_Brave

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 13, 2023

Verified on Pixel 2 XL running Android 8.1.0 using version:

Brave	1.58.124 Chromium: 117.0.5938.62 (Official Build) (64-bit) 
Revision	5c0e98018fb16948401122cb9af1a5a0a6b40865
OS	Android 8.1.0; Build/OPM2.171026.006.H1; 27; REL

Clean Profile - Toggles

Case 1: Both the switches ON - PASSED
  • When rewards is enabled, both the switches New tab page ads and Notification ads switches are enabled by default
  • Confirmed that both New tab page ads and Notification ads are served to the user when both the switches are ON
Example Example
Screenshot 2023-09-13 at 6 37 31 PM Screenshot 2023-09-13 at 7 10 58 PM
Case 2: Both the switches OFF - PASSED
  • Disable both the switches New tab page ads and Notification ads via the brave://rewards
  • Confirmed that New tab page ads and Notification ads are NOT served to user when both the switches are OFF (opened several new tabs, no NTP SI observed. Navigated around for a bit, no notification ads observed)
  • Confirmed toggling New tab page ads OFF via brave://rewards also toggled off Show Sponsored Images under "Customize Dashboard" on the NTP
Example Example
Screenshot 2023-09-13 at 6 41 49 PM Screenshot 2023-09-13 at 6 40 07 PM
Case 3: When `Notification ads` switch is disabled - PASSED
  • Confirmed that Default notification ads are NOT served to the user - PASSED
  • Confirmed that new tab page ads are served to the user - PASSED
0103
Case 4: When `New tab page ads` switch is disabled - PASSED
  • Confirmed that default ad notification are served when the Notification ads switch is enabled
  • Confirmed that New tab page ads are NOT served to the user
  • Confirmed toggling New tab page ads OFF via brave://rewards also toggled off Show Sponsored Images under "Customize Dashboard" on the NTP
0103

Existing Profile - Toggles

Case: Ad stats on existing profile - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards
  3. View a default notification (also viewed an NTP SI ad)
  4. Enable Brave news via NTP
  5. View a Inline content Ad
  6. Upgrade the profile to 1.58.x
  7. Confirmed that Inline content ads switch is enabled and counter next to inline content ads switch shows the correct number
  8. Confirmed NTP and notification ad switches are on and count displays as expected
  9. Open the ads history and confirmed that the ads history is shown correctly in an upgraded profile
0201

General

New Profile Use Cases
  1. Clean profile 1.58.x
  2. Enable rewards
  3. Confirmed that the Manage Brave Ads section is shown in the brave://rewards page
  4. Confirmed that New tab page ads and Notification ads switches are enabled by default
  5. Confirmed that Max 10 ads per hour option is selected by default
  6. Confirmed that tooltip next to Brave News ads says that Brave News is disabled and digit on the right is grayed out
  7. Confirmed that Brave News ads tooltip says that Brave News Ads cannot be independently disabled and confirmed that the digit is no longer grayed out when brave news is enabled and the counter is working.
  8. Confirmed that New tab page ads and Notification ads are served to the users when the swicthes are enabled
  9. Confirmed that brave news inline content ads are served to the user when Brave news is enabled
  10. Confirmed that users are rewarded for viewing brave news inline content ads, New tab page ads and Notification ads
  11. Confirmed that counter on each ad types is shown correctly after viewing ads
  12. Verified the toggle ON/OFF new tab page ads and confirmed that this works by checking the New Tab Page for New Tab Page ads, and that the ads viewed counter is working for this ad unit
  13. Go into “Settings->New tab page->Show Sponsored Images” via 3 dot menu, and toggle ON/OFF sponsored images settings and then look in brave://rewards Manage Brave Ads and onfirmed the new tab page ads toggle updates its state accordingly.
  14. Toggle ON/OFF new tab page ads via brave://rewards Manage Brave Ads, and confirmed that the toggle in “Settings->New tab page->Show Sponsored Images” updates its state accordingly.
  15. Exception case: Make sure New Tab Page ads are ON inside Customize Dashboard. Then, turn off background images completely.
    a. New Tab Page ads should still be on in Manage Brave Ads
    b. Turn off New Tab Page ads in Manage Brave Ads
    c. Enable background images in Customize Dashboard
    d. Check that the New Tab Page ads/sponsored images toggle in Customize Dashboard is OFF (matches Manage Brave
    Ads state)
    e. Then toggle New Tab Page ads on in Customize Dashboard, and check if state updates and matches in Manage Brave
    Ads
  16. Connect a custodian, and then check that the blue notice telling users to connect to a custodian (“Ready to start earning?”) no longer appears, and that things still appear to be working properly.
Disconnected Connected
Screenshot 2023-09-14 at 10 19 05 AM Screenshot 2023-09-14 at 10 28 09 AM
Upgraded Profile Use Cases
  • Verified ads can be enabled after upgrading version when they were disabled.
Reset Rewards
  1. Create new profile and go to brave://rewards > Manage Brave Ads
  2. Toggle off New tab page ads and Notification ads in Manage Brave Ads
  3. Reset Rewards profile
  4. Ensure that the new Rewards profile has New tab page ads OFF, and notification ads ON
Example Example Example Example
Screenshot 2023-09-14 at 10 41 50 AM Screenshot 2023-09-14 at 10 41 55 AM Screenshot 2023-09-14 at 10 42 03 AM Screenshot 2023-09-14 at 10 42 07 AM

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 13, 2023
@Uni-verse Uni-verse added QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 14, 2023
@btlechowski
Copy link

Verification passed on Brave v1.58.121 on Lenovo TB-8506FS (Android 11.0)

Verified general regression ads testing

Notification ads

NTP SI

Brave News/Inline ads

Unblinded tokens

Payment tokens redemption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/ads feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

8 participants