Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsequent delta updates on Windows fail #30748

Closed
mherrmann opened this issue Jun 1, 2023 · 21 comments · Fixed by brave/brave-core#18714
Closed

Subsequent delta updates on Windows fail #30748

mherrmann opened this issue Jun 1, 2023 · 21 comments · Fixed by brave/brave-core#18714

Comments

@mherrmann
Copy link
Collaborator

This issue behaves exactly like #29469, except the reason now is different.

The present reason is that after a normal installation, setup.exe in Brave's installation directory is code signed. But delta updates put a non-signed version of setup.exe into the installation directory. When the next delta update runs, it expects the code signed file. It sees a "different" file and falls back to the full update.

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jun 12, 2023

Verification In progress using

Brave | 1.54.53 Chromium: 114.0.5735.110 (Official Build) nightly (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Verified as following for 1.54.43 -->1.54.48-->1.53.53

Run following Pre-requisites:

  • Uninstall Brave from your system (all channels)
  • Run the following in an Administrator command prompt: "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
  • The following registry key should now not exist: HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\Clients.
  • Delete the following file if it exists: C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log.
  • Set the registry value HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\IsEnabledLogToFile to DWORD 1.
  1. Install Brave 1.54.43 using its offline installer.
  2. Accept the UAC prompt to perform a system-wide installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->"Run as Administrator").
  5. Download the delta installer to go from Brave 1.54.43 to 1.54.48.
  6. Enter the following in the command prompt:
    • set BraveSoftwareUpdateIsMachine=1
  7. Execute the delta installer in the same command prompt for Nightly. For example by typing:
    • C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-sxs
  8. Repeat steps 5 - 7 for the delta installer to go from Brave 1.54.48 to 1.54.53
  9. Start Brave

Actual Results:
Delta updates fail for the upgrades and they fall back to Full update.

  • first upgrade 1.54.43-->1.54.48
  • second upgrade 1.54.48 -->1.54.53
    two . tmp files are created in downloads folder
[06/12/23 16:45:39.008][BraveUpdate:goopdate][22764:8884][Installing][display name: Brave-Browser-Nightly][app id: {C6CB981E-DB30-4876-8639-109F8933582C}][installer path: C:\Program Files (x86)\BraveSoftware\Update\Install\{215E5439-16C1-46EB-8DEF-7EBA1E02ECB7}\brave_installer.exe][manifest args: --do-not-launch-chrome --chrome-sxs][installer data: ][untrusted data: ][priority: 10]
[06/12/23 16:45:39.008][BraveUpdate:goopdate][22764:8884][Running installer][C:\Program Files (x86)\BraveSoftware\Update\Install\{215E5439-16C1-46EB-8DEF-7EBA1E02ECB7}\brave_installer.exe][--do-not-launch-chrome --chrome-sxs][{C6CB981E-DB30-4876-8639-109F8933582C}]
[06/12/23 16:45:44.740][BraveUpdate:goopdate][22764:8884][InstallerResult][{C6CB981E-DB30-4876-8639-109F8933582C}][0]
[06/12/23 16:45:44.740][BraveUpdate:goopdate][22764:8884][InstallApp returned][0x0][{C6CB981E-DB30-4876-8639-109F8933582C}][type:1][code: 0][]["C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe" --from-installer]
[06/12/23 16:45:44.791][BraveUpdate:goopdate][22764:8884][Started process][18520]
1.54.43 BraveUpdate (1.54.43) first install(1.54.48) second install(1.54.53 Example Example Example
image initialinstall15443 afterupgrade15448 secondupgrade15453 image image image

Scenario 2:

  1. Install Brave 1.54.43 using its offline installer.
  2. Accept the UAC prompt to perform a system-wide installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->"Run as Administrator").
  5. Download the delta installer to go from Brave 1.54.43 to 1.54.48.
  6. Enter the following in the command prompt:
    • set BraveSoftwareUpdateIsMachine=1
  7. Execute the delta installer in the same command prompt for Nightly. For example by typing:
    • C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-sxs
  8. Start Brave
  9. open brave://settings/help to update Brave

Actual Results:

  • Instead of Delta update, it fell back to full update for the first upgrade 1.54.43-->1.54.48
  • Started Brave and updated via brave://settings/help
  • Brave updated to 1.54.53.
  • Logs show update happened via delta installer brave_installer-delta-x64.exe
1.54.43 intial install (1.54.43) update (1.54.48) 1.54.48 brave://settings/help upgrade upgrade delta (brave://settings/help)
image scenario 2 - 15443 scenario 2 - 15448 scenario 2 - 15448-brave image image image image

@MadhaviSeelam
Copy link
Collaborator

@mherrmann I am not seeing delta updates. Can you check the Actual Results above please?

@mherrmann
Copy link
Collaborator Author

mherrmann commented Jun 13, 2023

@MadhaviSeelam the steps you documented are really clear to understand. Thank you!

When you invoke brave_installer-delta-x64.exe from the command line, then the contents of BraveUpdate.log do not matter. All that matters is that brave://version shows the expected new version.

Let me explain why.

Brave's update mechanism on Windows works as follows: It asks the update server for a new version. If there is a new version, then the server returns the URL to a .exe file. The updater downloads and runs this file. As it performs these steps, it writes to BraveUpdate.log.

If the .exe fails with a non-zero exit code, then the updater repeats the process on the same channel, but with -full appended to the channel name. This lets the updater fall back to the full update when a delta update fails. For example: The typical Nightly channel is x64-ni. Say the updater obtained a delta update brave_installer-delta-x64.exe from there, but this .exe fails. Then the updater performs an update check on x64-ni-full. This returns the full installer, and so (hopefully) the update goes through even though the delta update failed.

Now to tie this back to BraveUpdate.log: When we manually execute brave_installer-delta-x64.exe on the command line, then we are simulating the updater. The reason why we do it this way is that the updater would receive the full update 1.54.43 -->1.54.53 from the server, which would prevent us from testing the delta 1.54.43 -->1.54.48. The relevant log file for brave_installer-delta-x64.exe is C:\Users\<user>\AppData\Local\Temp\chromium_installer.log.

I hope this helps clarify the context?

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jul 26, 2023

Verification In progress using

Brave | 1.57.16 Chromium: 115.0.5790.98 (Official Build) beta (64-bit)
-- | --
Revision | d6c8a44fbe78ae6ee53d838307b4d17bec8de940
OS | Windows 11 Version 22H2 (Build 22621.1992)

Verified upgrade check with 1.57.16 -->1.57.18 -->1.57.24

Run following Pre-requisites:

  • Uninstall Brave from your system (all channels)
  • Run the following in an Administrator command prompt: "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
  • The following registry key should now not exist: HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\Clients.
  • Delete the following file if it exists: C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log.
  • Set the registry value HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\IsEnabledLogToFile to DWORD 1.
  1. Install Brave 1.57.16 using it's offline installer, BraveBrowserStandaloneBetaSetup.exe
  2. Accept the UAC prompt to perform a system-wide installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->"Run as Administrator").
  5. Download the delta installer to go from Brave 1.57.16 to 1.57.18
  6. Enter the following in the command prompt:
    • set BraveSoftwareUpdateIsMachine=1
  7. Execute the delta installer in the same command prompt for beta. For example by typing:
    • C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta
  8. Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.18 to 1.57.24
  9. Connect to Internet
  10. Start Brave
  11. update Brave via brave://settings/help and confirmed successfully updated
  12. verify the logs in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  13. verify brave_installer-delta-x64.exe in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log

Actual Results:

  • successfully updated via brave://settings/help (in step 11) to 1.57.24
  • However, I see following:
    - I don't see brave_installer-delta-x64.exe in the chromium_installer.log
    - failed to apply patcherror is shown in thechromium_installer.log- BraveUpdate.log showsMain failed`
registry value step 1 step 6 step 7 step 8 step 10 step 11a step 11b step 12 step 13
image image image image image image image image image image
chromium_installer.log BraveUpdate.log
image image

@mherrmann
Copy link
Collaborator Author

mherrmann commented Jul 27, 2023

Thank you @MadhaviSeelam. I followed your steps on two Windows 10 machines but (unfortunately?) the problem did not appear for me.

Does the problem also appear for you on Windows 10? And - ignoring the log files for now - do you see the correct version in brave://settings/help when you (re-)start the browser after applying the delta installers?

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Jul 28, 2023

@mherrmann - I have verified twice on Win 10 following steps from above. Here are the actual results:

  • successfully updated via brave://settings/help to 1.57.27
  • BraveUpdate.log file do not show Main failed error
  • However:
    • failed to apply patcherror is shown in thechromium_installer.log` during second time testing.
    • Also the difference between first and second, the entries for installers 1.57.18, 1.57.24, 1.57.27 are shown and no failed to apply patch error is shown. But the second time I see the installer entry for 1.57.18 and not for 1.57.24 & 1.57.27
ex ex BraveUpdate chromium_installer
image image image image

@mherrmann
Copy link
Collaborator Author

mherrmann commented Jul 28, 2023

@MadhaviSeelam let's ignore the log files for now please.

By "successfully updated via brave://settings/help", do you mean that you had internet access and updated from a previous Brave version by opening that page?

What I want to know please is if, after running brave_installer-delta-x64.exe and without internet access, do you see the correct version in brave://settings/help?

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Aug 1, 2023

Verification PASSED using

Brave | 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (64-bit)
-- | --
Revision | 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS | Windows 11 Version 22H2 (Build 22621.1992)

Win 11 x64 - Machine-wide install - PASSED

Verified with public beta releases 1.57.27 -->1.57.33 --> 1.57.35

  1. Install Brave 1.57.27 using it's offline installer, BraveBrowserStandaloneBetaSetup.exe
  2. Accept the UAC prompt to perform a system-wide installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->"Run as Administrator").
  5. Download the delta installer to go from Brave 1.57.27 to 1.57.33
  6. Enter the following in the command prompt:
    - set BraveSoftwareUpdateIsMachine=1
  7. Execute the delta installer in the same command prompt for beta. For example by typing:
    - C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta
  8. Start Brave (without internet)
  9. Verified Brave updated to 1.57.33 via brave://setting/help
  10. Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
  11. Start Brave (without internet)
  12. Verified brave updated to 1.57.35 via brave://settings/help
  13. Verified correct logs shown in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  14. Verified correct installed versions shown in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
  15. Verified on-demand updates are successful after connecting to Internet via brave://settings/help

Confirmed:

  • Brave is updated to 1.57.33 & 1.57.35 and verified via brave://version
  • C:\Users\...\AppData\Local\Temp\chromium_installer.log shows correct Brave versions and no errors shown
  • C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log shows correct logs.
  • On-demand updates were successful via brave://settings/help
Step 1 Step 6-7 Step 9 Step 10 Step 12 Step 13 Step 14 Step 15
image image image image image image image image

Win 11 x64 -Per- User Install - PASSED

  1. Install Brave 1.57.27 using it's offline installer, BraveBrowserStandaloneBetaSetup.exe
  2. Do not accept the UAC prompt and install without administrator privileges to perform Per-user installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt (without Administrator privileges)
  5. Download the delta installer to go from Brave 1.57.27 to 1.57.33
  6. Open Windows command prompt (without Administrator privileges)
  7. Execute the delta installer in the same command prompt for beta. For example by typing:
    - C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta
  8. Start Brave (without internet)
  9. Verified Brave updated to 1.57.33 via brave://setting/help
  10. Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
  11. Start Brave (without internet)
  12. Verified brave updated to 1.57.35 via brave://settings/help
  13. Verified correct logs shown in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  14. Verified correct installed versions shown in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
  15. Verified on-demand updates are successful after connecting to Internet via brave://settings/help

Confirmed:

  • Brave is updated to 1.57.33 & 1.57.35 and verified via brave://version
  • C:\Users\...\AppData\Local\Temp\chromium_installer.log shows correct Brave versions and no errors shown
  • C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log shows correct logs.
  • On-demand updates were successful via brave://settings/help
Step 1 Step 6-7 Step 9 Step 10 Step 12 Step 13 Step 14 Step 15
image image image image image image image image

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Aug 1, 2023

@mherrmann so the update is successful without connecting to internet which was verified via brave://version. However, when I checked via brave://settings/help, got an error Unable to connect to Internet (which is expected, I suppose)
No errors are shown this time in chromium_installer.log & BraveUpdate.log files

@mherrmann
Copy link
Collaborator Author

@MadhaviSeelam yes, Unable to connect to Internet is expected. It seems like everything worked now. Thank you for checking again! 🙏

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Aug 3, 2023

@GeetaSarvadnya This issue is passed on Win 11 x64 and I am yet verify in Win arm64. When you get a chance, please test this issue on Win 10.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Aug 4, 2023

Verification PASSED on

Brave | 1.57.35 Chromium: 115.0.5790.171 (Official Build) beta (64-bit)
-- | --
Revision | 776897328898241b35b83878040730e73e749c06
OS | Windows 10 Version 22H2 (Build 19045.3208)

Win x64 - Machine wide Install - PASSED

Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35

Pre-requisites: Run Brave Manager and make sure all the brave instances from your computer is uninstalled

  1. Install Brave 1.57.27 using it's offline installer, [BraveBrowserStandaloneBetaSetupx64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupx64.exe
  2. Accept the UAC prompt to perform a system-wide installation.
  3. Close Brave and disconnect from the internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->"Run as Administrator").
  5. Download the delta installer to go from Brave 1.57.27 to 1.57.33
  6. Enter the following in the command prompt:
    - set BraveSoftwareUpdateIsMachine=1
  7. Execute the delta installer in the same command prompt for beta. For example by typing:
    - C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta
  8. Start Brave (without internet)
  9. updates via brave://setting/help failed as the internet is off
  10. verified the new updated version via brave://version
  11. Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
  12. Start Brave (without internet)
  13. updates via brave://setting/help failed as the internet is off
  14. verified the new updated version via brave://version
  15. verify the logs in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  16. verify brave_installer-delta-x64.exe in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
  17. connected to internet

Actual Results:

  • When Brave started without internet, Brave is updated to 1.57.33 & 1.57.35 as shown in brave://version.
  • After connecting to the internet, no errors were shown on the brave://settings/help page and the correct version 1.57.35 was shown.
step 1 step 6-7 step 9 step 10 step11 step 13 step 14 step 15 step 16 step 17
image image image image image image image image image image

Win x64 - Per-user Install - PASSED

Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35

  1. Run Brave Manager and make sure all the brave instances from your computer is uninstalled
  2. Go to local profile folder directory and make sure Update folder is deleted to make sure there is no updater running in your computer
  3. Open the Registry Editor without admin rights
  4. Navigate to Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\Update\
  5. Make sure there are no Clients and Clientstates under Update folder in the path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\Update\
  6. Download [BraveBrowserStandaloneBetaSetupx64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupx64.exe
  7. Download the delta installer to go from Brave 1.57.27 to 1.57.33
  8. Download delta installer to go from Brave 1.57.33 to 1.57.35
  9. Install Brave 1.57.27 using it's offline installer, [BraveBrowserStandaloneBetaSetupx64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupx64.exe
  10. Do not accept the UAC prompt and install without administrator privileges to perform Per-user installation.
  11. Make sure the intended version is installed
  12. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  13. Execute the delta installer in the same command prompt for beta. For example by typing:
    C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta
  14. Start Brave (without internet)
  15. Make sure brave is updated from 1.57.27 to 1.57.33 via brave://setting/help and update check is failed as the internet is off that is expected
  16. Verified the new updated version via brave://version
  17. Close the brave
  18. Repeat the step 13 and 14 [Important: Please make sure to move the download file for 1.57.33 delta installer to other folder after running step 15, if you just execute the step 13 without moving 1.5.33 installer it may run the 1.57.33 delta installer again, so please make sure you are running the correct version 1.57.35 in the step 18 ]
  19. Open brave://setting/help
  20. Make sure brave is updated from 1.57.33 to 1.57.35 via brave://setting/help and update check is failed as the internet is off that is expected
  21. Verified the new updated version via brave://version
  22. Verify the logs in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  23. Verify brave_installer-delta-x64.exe in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
  24. Connected to internet and make sure on demand updates is happening correctly via brave://settings/help
  25. Check the registry and make sure correct client version is shown

Actual Results:

  • Updates are happening from 1.5.27 ->1.57.33->1.5.35
  • .......\AppData\Local\Temp\chromium_installer.log shows the correct logs
  • C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log shows the correct logs
  • After connecting internet, on demand updates is happening correctly via brave://settings/help
step 5 step 11 step 13 step 15 step 16 step 18 step 20 step 21 step 22 step 23 step 24 step 25 step 25 (1)
image (1) image image 3 4 image 6 7 8 9 image 11 12

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Aug 4, 2023

Verification PASSED using

Brave | 1.57.27 Chromium: 115.0.5790.114 (Official Build) beta (arm64)
-- | --
Revision | 18977fb43f693d5a8deeb48bd1cfa52651d3f73e
OS | Windows 11 Version 22H2 (Build 22621.1992)

Win arm64 - Machine wide Install - PASSED

Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35

  1. Install Brave 1.57.27 using it's offline installer, [BraveBrowserStandaloneBetaSetupArm64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupArm64.exe
  2. Accept the UAC prompt to perform a system-wide installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt with Administrator privileges (right-click->"Run as Administrator").
  5. Download the delta installer to go from Brave 1.57.27 to 1.57.33
  6. Enter the following in the command prompt:
    - set BraveSoftwareUpdateIsMachine=1
  7. Execute the delta installer in the same command prompt for beta. For example by typing:
    - C:\Users\mseel\Downloads\brave_installer-delta-arm64.exe --chrome-beta
  8. Start Brave (without internet)
  9. Verified the new updated version, 1.57.33 via brave://version
  10. Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
  11. Start Brave (without internet)
  12. Verified the new updated version, 1.57.35 via brave://version
  13. Verified correct logs shown in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  14. Verified correct versions shown in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
  15. Verified on-demand updates are successful after connecting to Internet via brave://settings/help

Confirmed:

  • Brave is updated to 1.57.33 & 1.57.35 and verified via brave://version
  • C:\Users\mseel\AppData\Local\Temp\chromium_installer.log shows correct Brave versions and no errors shown
  • C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log shows correct logs.
  • On-demand updates were successful via brave://settings/help
step 1 step 6-7 step 9 step10 step 12 step 13 step 14 step 15
image image image image image image image image

Win arm64 - Per-user Install - PASSED

Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35

  1. Install Brave 1.57.27 using it's offline installer, [BraveBrowserStandaloneBetaSetupArm64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupArm64.exe
  2. Do not accept the UAC prompt and install without without administrator privileges to perform Per-user installation.
  3. Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
  4. Open a Windows command prompt (without Administrator privileges)
  5. Download the delta installer to go from Brave 1.57.27 to 1.57.33
  6. Execute the delta installer in the same command prompt for beta. For example by typing:
    - C:\Users\mseel\Downloads\brave_installer-delta-arm64.exe --chrome-beta
  7. Start Brave (without internet)
  8. Verified the new updated version,1.57.33, via brave://version
  9. Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
  10. Start Brave (without internet)
  11. Verified the new updated version,1.57.35, via brave://version
  12. Verified correct logs via C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
  13. Verified correct Brave versions show via C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
  14. Verified on-demand updates after connecting to Internet via brave://settings/help

Confirmed:

  • Brave is updated to 1.57.33 & 1.57.35 and verified via brave://version
  • C:\Users....\AppData\Local\Temp\chromium_installer.log shows correct Brave versions and no errors shown
  • C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log shows correct logs.
  • On-demand updates shows errors via brave://settings/help
step 1 step 6 step 9 step10 step 12 step 13 step 14 step 15
image image image image image image image image

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Aug 6, 2023

@mherrmann Delta updates are failing for Per-user installs for both Win 11 x64 & Win arm64. No issues with Machine-wide install and the delta updates are successful.
(However, on-demand updates were successful in Win 11 x64 but they are failing as well in Win arm64. Currently this is a known issue as it was found via #31696 testing. Will file an issue for it)

Win 11 x64 -Per- User Install - Failed - #30748 (comment) (Please see actual results)
Win arm64 - Per-user Install - Failed - #30748 (comment) - (Please see actual results)

@mherrmann
Copy link
Collaborator Author

@MadhaviSeelam thank you for checking this. I need to aplogise: The instructions were not correct for per-user installations. For per-user installations, we want to use a normal command prompt, not an Administrator command prompt, and we should not set BraveSoftwareUpdateIsMachine=1. Your replication steps work for me with these adjustments. Can you check whether they work for you too? Sorry for the trouble.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Aug 8, 2023

@MadhaviSeelam I have done testing on Windows 10 x64, please add the QA pass label once you're done with the per-user installations testing on windows 11. Thanks!

@MadhaviSeelam
Copy link
Collaborator

MadhaviSeelam commented Aug 8, 2023

@mherrmann: Followed your modified test steps for Per-user install on both Win 11 x64 & Win arm64.
(linking screenshots for Win arm64 testing)

  • Open normal command prompt (without admin)
  • Do not set BraveSoftwareUpdateIsMachine=1
  • run C:\Users\...\Downloads\brave_installer-delta-arm64.exe --chrome-beta
image

Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35.
However, I am still seeing some messages in the logs as below. Not sure if these are expected.|

C:\Users....\AppData\Local\Temp\chromium_installer.log

  • Failed creating a fire rules. Continuing with install.
  • Failed to create Software/Microsoft\MediaPlayer\ShimInclusionList
  • Could not add Chrome to media player inclusion list
image

C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log

  • Elevated metainstaller failed`
image

Additionally Main failed entry is shown in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log . However, this entry is not shown when installed with Network/WiFi is on for Machine-wide installs

image

@mherrmann
Copy link
Collaborator Author

Thank you @MadhaviSeelam. Do you see the correct versions in brave://version?

@MadhaviSeelam
Copy link
Collaborator

@mherrmann Yes. I see correct versions. (Verified logs in C:\Users....\AppData\Local\Temp\chromium_installer.log and in brave://version after each update)

@mherrmann
Copy link
Collaborator Author

@MadhaviSeelam great, thanks. As long as the correct version is shown in brave://version, then I don't consider the log files important.

@MadhaviSeelam
Copy link
Collaborator

@mherrmann sounds good. QA passing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants