"Show tab search button" setting resets when a new window is open

[Brave-Matt]

Description

In Brave on macOS, if the Show tab search button option in Settings --> Appearance --> Tabs is toggled "off", the tab search button stops displaying as intended. However if a new window is opened, not only does the tab search button reappear, but the setting itself is toggled back "on" for both windows that are open.

This option should persist across Windows and browsing sessions.

Steps to Reproduce

Launch Brave

1. Go to Settings --> Appearance --> Tabs
2. Toggle Show tab search button option “off” so that the tab search button does not display in the top-right
3. Open a new browser window (Cmd + N)
4. Observe that the tab search button is now showing. Further, observe that the setting in the original window you opened is now toggled back “on”

Reproduces how often:

Every time

Brave version (brave://version info)

Version 1.52.117 Chromium: 114.0.5735.90 (Official Build) (arm64)

Version/Channel Information:

In the Beta, Dev and Nightly builds, the same behavior happens, except for the option in Settings is not toggled back on (that is, it stays toggled "off"), but the button does appear. To clarify, for all builds other than Stable:

1. Go to Settings --> Appearance --> Tabs
2. Toggle Show tab search button option “off” so that the tab search button does not display in the top-right
3. Open a new browser window (Cmd + N)
4. Observe that the tab search button is now showing in the new window.
5. Close this window and observe that in the original window, the tab button is now showing, but the toggle option in Settings stays "off"

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

[chunga2020]

I'm using 1.52.117 Chromium: 114.0.5735.90 (Official Build) (64-bit) on Arch Linux (linux kernel 6.3.5), and I experience similar behavior. However, on my system, the tab button remains hidden in the original window

[sangwoo108]

I can't reproduce the preference part, but the button's visibility is definitely a regression from vertical tabs. I'm on it.

[kjozwiak]

The above requires 1.52.125 or higher for 1.52.x verification 👍

[LaurenWags]

Verified with

Brave | 1.52.125 Chromium: 114.0.5735.110 (Official Build) (x86_64)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | macOS Version 13.4 (Build 22F66)

Reproduced the original issue using the STR/Cases outlined via #30829 (comment) running 1.52.122 Chromium: 114.0.5735.110 (Official Build) (x86_64) as per the following:

• Disabled Show tab search button and the button was still appearing when opening new windows

Using the STR/Cases outlined via #30829 (comment), verified that the search button was being removed correctly as per the following:

• ensured that toggling Show tab search button via brave://settings/appearance correctly removes the search button
  • ensured it's being removed from the current active window
  • ensured it's being removed from all other currently opened windows
  • ensured it's not being added when opening new windows
• ensured that the Show tab search button state is persistent (not being enabled/disabled when it shouldn't)
  • ensured that the Show tab search button state is persistent across several restarts

[MadhaviSeelam]

Verification PASSED using

Brave | 1.52.125 Chromium: 114.0.5735.110 (Official Build) (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Linux

Reproduced the issue in 1.52.122. As the tab search button is hidden in the original but is shown in the new window when Show tab search button is toggle Off

Using the STR/Cases outlined via #30829 (comment), verified that the search button was being removed correctly as per the following:

• ensured that toggling Show tab search button via brave://settings/appearance correctly removes the search button
  • ensured it's being removed from the current active window
  • ensured it's being removed from all other currently opened windows
  • ensured it's not being added when opening new windows
• ensured that the Show tab search button state is persistent (not being enabled/disabled when it shouldn't)
  • ensured that the Show tab search button state is persistent across several restarts

Show tab search button (off)	Show tab search button (on)