Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 114.0.5735.90 to Chromium 114.0.5735.110 #30830

Closed
emerick opened this issue Jun 5, 2023 · 9 comments · Fixed by brave/brave-core#18764
Closed

Upgrade from Chromium 114.0.5735.90 to Chromium 114.0.5735.110 #30830

emerick opened this issue Jun 5, 2023 · 9 comments · Fixed by brave/brave-core#18764

Comments

@emerick
Copy link
Contributor

emerick commented Jun 5, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/114.0.5735.90..114.0.5735.110?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2023

@brave/qa-team re: Android, we'll need to make sure that there's nothing new added into Settings as per @samartnik.

@kjozwiak kjozwiak closed this as completed Jun 6, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2023

The above requires 1.52.122 or higher for 1.52.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Jun 6, 2023

Verified with

Brave	1.52.122 Chromium: 114.0.5735.110 (Official Build) (arm64) 
Revision	1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS	macOS Version 13.4 (Build 22F66)

M1


Verified with

Brave | 1.52.122 Chromium: 114.0.5735.110 (Official Build) (x86_64)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | macOS Version 13.4 (Build 22F66)
Intel

@btlechowski
Copy link

Verification passed on

Brave 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)
Revision 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS Ubuntu 18.04 LTS

image

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Windows 10 Version 22H2 (Build 19045.2965)

image

@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2023

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit)
--- | ---
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Android 13; Build/TP1A.220624.014; 33; REL

As per #30830 (comment), compared all the Settings against 1.52.120 Chromium: 114.0.5735.90 and ensured there was nothing new added or removed.

Example Example
Screenshot_20230606_123051_Brave Screenshot_20230606_123116_Brave

@hffvld
Copy link
Contributor

hffvld commented Jun 6, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB2.230407.019 release-keys]
Brave build: 1.52.122
Chromium: 114.0.5735.110 (Official Build) (64-bit)
Revision: 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}

As per #30830 (comment) compared the new build Brave: 1.52.122 Chromium: 114.0.5735.110 (Official Build) (64-bit) with previous build Brave: 1.52.120 Chromium 114.0.5735.90 (Official Build) (64-bit) and didn't find any changes in the app Settings.

1 2
1 2
114.0.5735.90 114.0.5735.110
1 2

@ikibalnyi
Copy link

Please pay attention It's been reported that this chromium version (114.0.5735.110) contains security vulnerability https://nvd.nist.gov/vuln/detail/CVE-2023-3079

@emerick
Copy link
Contributor Author

emerick commented Jun 8, 2023

@ikibalnyi I believe it's saying that versions prior to 114.0.5735.110 have the vulnerability.

cc'ing: @diracdeltas just to be safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment