Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You don't have enough tokens message is not refreshed/removed from the tipping banner when the tip amount is lesser than the wallet balance #30907

Closed
GeetaSarvadnya opened this issue Jun 8, 2023 · 2 comments · Fixed by brave/brave-core#18841

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #28149
You don't have enough tokens message is not refreshed/removed from the tipping banner when the tip amount is lesser than the wallet balance

Steps to reproduce

  1. Clean profile 1.53.x
  2. Enable rewards and connect uphold custodian
  3. Open the uphold verified creator laurenwags.github.io
  4. Open the tipping banner and click on the Custom
  5. Enter the custom amount which is greater than the wallet balance
  6. Confirm that the You don't have enough tokens message is displayed as expected
  7. Enter the custom tip amount lesser than the wallet balance
  8. You don't have enough tokens message is STILL disaplyed which is not correct

Actual result

You don't have enough tokens message is not refreshed/removed from the tipping banner when the tip amount is lesser than the wallet balance
Screenshot_20230609_145909

Expected result

You don't have enough tokens message should not be shown when the tip amount is lesser than the wallet balance

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet):all
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@kjozwiak
Copy link
Member

The above requires 1.53.96 or higher for 1.53.x verification 👍

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 19, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.53.99

One-time tip

Example Example
Screenshot_20230619_154208 Screenshot_20230619_154213

Monthly tips

Example Example
Screenshot_20230619_154228 Screenshot_20230619_154233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants