Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You don't have enough token message is shown when USD to BAT or vice versa conversion #30911

Closed
GeetaSarvadnya opened this issue Jun 8, 2023 · 2 comments · Fixed by brave/brave-core#18841
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #28149
You don't have enough token message is shown when USD to BAT or vice versa conversion

Steps to reproduce

  1. Clean profile 1.53.x
  2. Enable rewards and connect uphold custodian
  3. Open the uphold verified creator laurenwags.github.io
  4. Open the tipping banner and click on the up and down arrow multiple times for the 0.0 BAT BAT and USD conversion
  5. Make sure 0.0 BAT is at the left side and 0.0 USD is at the right side
  6. Select the default tip amount 5.0 BAT or any default value
  7. Click on the up and down arrow multiple times for the USD and BAT conversion
  8. Incorrect 25.25 BAT values is shown in the tipping banner which is incorrect
  9. You don't have enough token message is shown which is incorrect

Note: : Repeat the steps above for the default values 10.5 BAT and 1.25 BAT

Actual result

You don't have enough token message is shown when USD to BAT or vice versa conversion
image

Expected result

USD to BAT or vice versa conversion should happen correctly and You don't have enough token message should not be shown when the tip amount is lesser than the wallet balance

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@kjozwiak
Copy link
Member

The above requires 1.53.96 or higher for 1.53.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.53.99

vidma_recorder_19062023_150931.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants